All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v2 10/14] dt-bindings: soc: qcom: apr: correct service children
Date: Wed, 7 Sep 2022 13:01:03 -0500	[thread overview]
Message-ID: <20220907180103.GA3803351-robh@kernel.org> (raw)
In-Reply-To: <20220907101556.37394-11-krzysztof.kozlowski@linaro.org>

On Wed, 07 Sep 2022 12:15:52 +0200, Krzysztof Kozlowski wrote:
> The APR bindings were not describing properly children nodes for DAIs.
> None of the DTSes use unit addresses for the children, so correct the
> nodes and reference their schema: clock-controller, dais and routing.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> ---
> 
> Changes since v1:
> 1. Correct also sound/qcom,q6apm-dai.yaml (Rob)
> ---
>  .../bindings/soc/qcom/qcom,apr.yaml           | 68 ++++++++++++++++---
>  .../bindings/sound/qcom,q6apm-dai.yaml        | 10 +--
>  .../sound/qcom,q6dsp-lpass-clocks.yaml        | 16 ++---
>  .../sound/qcom,q6dsp-lpass-ports.yaml         | 16 ++---
>  4 files changed, 66 insertions(+), 44 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
	Andy Gross <agross@kernel.org>
Subject: Re: [PATCH v2 10/14] dt-bindings: soc: qcom: apr: correct service children
Date: Wed, 7 Sep 2022 13:01:03 -0500	[thread overview]
Message-ID: <20220907180103.GA3803351-robh@kernel.org> (raw)
In-Reply-To: <20220907101556.37394-11-krzysztof.kozlowski@linaro.org>

On Wed, 07 Sep 2022 12:15:52 +0200, Krzysztof Kozlowski wrote:
> The APR bindings were not describing properly children nodes for DAIs.
> None of the DTSes use unit addresses for the children, so correct the
> nodes and reference their schema: clock-controller, dais and routing.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> ---
> 
> Changes since v1:
> 1. Correct also sound/qcom,q6apm-dai.yaml (Rob)
> ---
>  .../bindings/soc/qcom/qcom,apr.yaml           | 68 ++++++++++++++++---
>  .../bindings/sound/qcom,q6apm-dai.yaml        | 10 +--
>  .../sound/qcom,q6dsp-lpass-clocks.yaml        | 16 ++---
>  .../sound/qcom,q6dsp-lpass-ports.yaml         | 16 ++---
>  4 files changed, 66 insertions(+), 44 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2022-09-07 18:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 10:15 [PATCH v2 00/14] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 01/14] arm64: dts: qcom: sdm630: align APR services node names with dtschema Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 02/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 03/14] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 04/14] arm64: dts: qcom: msm8996: fix APR services nodes Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 05/14] arm64: dts: qcom: sdm845: align dai node names with dtschema Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 06/14] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 07/14] arm64: dts: qcom: qrb5165-rb5: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 08/14] arm64: dts: qcom: sm8250: use generic name for LPASS clock controller Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 09/14] ASoC: dt-bindings:: qcom,q6asm: convert to dtschema Krzysztof Kozlowski
2022-09-07 17:57   ` Rob Herring
2022-09-07 17:57     ` Rob Herring
2022-09-08  9:05     ` Krzysztof Kozlowski
2022-09-08  9:05       ` Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 10/14] dt-bindings: soc: qcom: apr: correct service children Krzysztof Kozlowski
2022-09-07 18:01   ` Rob Herring [this message]
2022-09-07 18:01     ` Rob Herring
2022-09-07 10:15 ` [PATCH v2 11/14] ASoC: dt-bindings: qcom, q6dsp-lpass-ports: cleanup example Krzysztof Kozlowski
2022-09-07 10:15   ` [PATCH v2 11/14] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 12/14] ASoC: dt-bindings: qcom, q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-07 10:15   ` [PATCH v2 12/14] ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 13/14] ASoC: dt-bindings: qcom, q6apm-dai: adjust indentation in example Krzysztof Kozlowski
2022-09-07 10:15   ` [PATCH v2 13/14] ASoC: dt-bindings: qcom,q6apm-dai: " Krzysztof Kozlowski
2022-09-07 10:15 ` [PATCH v2 14/14] dt-bindings: soc: qcom: apr: add missing properties Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220907180103.GA3803351-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.