From: Asutosh Das <quic_asutoshd@quicinc.com>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "mani@kernel.org" <mani@kernel.org>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
"quic_rampraka@quicinc.com" <quic_rampraka@quicinc.com>,
"quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue capability
Date: Mon, 26 Sep 2022 14:34:13 -0700 [thread overview]
Message-ID: <20220926213413.GD15228@asutoshd-linux1.qualcomm.com> (raw)
In-Reply-To: <DM6PR04MB6575F55C0A33C049E22C72B6FC509@DM6PR04MB6575.namprd04.prod.outlook.com>
On Sat, Sep 24 2022 at 01:14 -0700, Avri Altman wrote:
>>
>> + hba->mcq_sup = (hba->capabilities & MASK_MCQ_SUPPORT) >>
>> MCQ_SUPP_SHIFT;
>Since you are just testing for bit30, MASK_MCQ_SUPPORT is not really needed.
>Maybe just:
>hba->mcq_sup = (hba->capabilities >> MCQ_SUPP_SHIFT) & 1;
>
Thanks. Yeah, Mani suggested FIELD* macros as an option too.
Let me check that as well and address this in the next version.
-asd
WARNING: multiple messages have this Message-ID (diff)
From: Asutosh Das <quic_asutoshd@quicinc.com>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "mani@kernel.org" <mani@kernel.org>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
"quic_rampraka@quicinc.com" <quic_rampraka@quicinc.com>,
"quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue capability
Date: Mon, 26 Sep 2022 14:34:13 -0700 [thread overview]
Message-ID: <20220926213413.GD15228@asutoshd-linux1.qualcomm.com> (raw)
In-Reply-To: <DM6PR04MB6575F55C0A33C049E22C72B6FC509@DM6PR04MB6575.namprd04.prod.outlook.com>
On Sat, Sep 24 2022 at 01:14 -0700, Avri Altman wrote:
>>
>> + hba->mcq_sup = (hba->capabilities & MASK_MCQ_SUPPORT) >>
>> MCQ_SUPP_SHIFT;
>Since you are just testing for bit30, MASK_MCQ_SUPPORT is not really needed.
>Maybe just:
>hba->mcq_sup = (hba->capabilities >> MCQ_SUPP_SHIFT) & 1;
>
Thanks. Yeah, Mani suggested FIELD* macros as an option too.
Let me check that as well and address this in the next version.
-asd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-26 21:34 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 1:05 [PATCH v1 00/16] Add Multi Circular Queue Support Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 01/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-26 14:08 ` Manivannan Sadhasivam
2022-09-26 14:08 ` Manivannan Sadhasivam
2022-09-30 18:23 ` Bart Van Assche
2022-09-30 18:23 ` Bart Van Assche
2022-10-04 22:09 ` Asutosh Das
2022-10-04 22:09 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-24 8:13 ` Avri Altman
2022-09-24 8:13 ` Avri Altman
2022-09-26 21:34 ` Asutosh Das [this message]
2022-09-26 21:34 ` Asutosh Das
2022-09-26 14:27 ` Manivannan Sadhasivam
2022-09-26 14:27 ` Manivannan Sadhasivam
2022-09-23 1:05 ` [PATCH v1 03/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-30 18:32 ` Bart Van Assche
2022-09-30 18:32 ` Bart Van Assche
2022-10-04 18:51 ` Asutosh Das
2022-10-04 18:51 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 04/16] ufs: core: mcq: Introduce Multi Circular Queue Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-26 14:49 ` Manivannan Sadhasivam
2022-09-26 14:49 ` Manivannan Sadhasivam
2022-09-26 21:32 ` Asutosh Das
2022-09-26 21:32 ` Asutosh Das
2022-09-30 18:37 ` Bart Van Assche
2022-09-30 18:37 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 05/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-26 15:07 ` Manivannan Sadhasivam
2022-09-26 15:07 ` Manivannan Sadhasivam
2022-09-30 18:42 ` Bart Van Assche
2022-09-30 18:42 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 06/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-26 15:22 ` Manivannan Sadhasivam
2022-09-26 15:22 ` Manivannan Sadhasivam
2022-09-26 21:23 ` Asutosh Das
2022-09-26 21:23 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 07/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-26 15:45 ` Manivannan Sadhasivam
2022-09-26 15:45 ` Manivannan Sadhasivam
2022-10-03 20:25 ` Asutosh Das
2022-10-03 20:25 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 08/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 09/16] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 10/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 11/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 12/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-30 20:43 ` Bart Van Assche
2022-09-30 20:43 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 13/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-30 20:41 ` Bart Van Assche
2022-09-30 20:41 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 14/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-23 1:05 ` [PATCH v1 15/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-30 20:32 ` Bart Van Assche
2022-09-30 20:32 ` Bart Van Assche
2022-09-23 1:05 ` [PATCH v1 16/16] ufs: qcom-host: Enable multi circular queue capability Asutosh Das
2022-09-23 1:05 ` Asutosh Das
2022-09-26 13:49 ` [PATCH v1 00/16] Add Multi Circular Queue Support Manivannan Sadhasivam
2022-09-26 13:49 ` Manivannan Sadhasivam
2022-09-26 18:55 ` Asutosh Das
2022-09-26 18:55 ` Asutosh Das
2022-09-30 20:44 ` Bart Van Assche
2022-09-30 20:44 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926213413.GD15228@asutoshd-linux1.qualcomm.com \
--to=quic_asutoshd@quicinc.com \
--cc=Avri.Altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.