All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: mustafa.ismail@intel.com, netdev@vger.kernel.org,
	leszek.kaliszczuk@intel.com, przemyslaw.kitszel@intel.com,
	edumazet@google.com, intel-wired-lan@lists.osuosl.org,
	jiri@nvidia.com, pabeni@redhat.com, shiraz.saleem@intel.com,
	davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next 12/13] ice, irdma: prepare reservation of MSI-X to reload
Date: Mon, 14 Nov 2022 21:08:56 -0800	[thread overview]
Message-ID: <20221114210856.0d76bb2c@kernel.org> (raw)
In-Reply-To: <20221114125755.13659-13-michal.swiatkowski@linux.intel.com>

On Mon, 14 Nov 2022 13:57:54 +0100 Michal Swiatkowski wrote:
> Move MSI-X number for LAN and RDMA to structure to have it in one
> place. Use req_msix to store how many MSI-X for each feature user
> requested. Structure msix is used to store the current number of MSI-X.
> 
> The MSI-X number needs to be adjust if kernel doesn't support that many
> MSI-X or if hardware doesn't support it. Rewrite MSI-X adjustment
> function to use it in both cases.
> 
> Use the same algorithm like previously. First allocate minimum MSI-X for
> each feature than if there is enough MSI-X distribute it equally between
> each one.

drivers/net/ethernet/intel/ice/ice_lib.c:455: warning: Function parameter or member 'vsi' not described in 'ice_vsi_alloc_def'
drivers/net/ethernet/intel/ice/ice_lib.c:455: warning: Excess function parameter 'vsi_type' description in 'ice_vsi_alloc_def'
drivers/net/ethernet/intel/ice/ice_main.c:4026:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
        return err;
               ^~~
drivers/net/ethernet/intel/ice/ice_main.c:4001:29: note: initialize the variable 'err' to silence this warning
        int v_wanted, v_actual, err, i;
                                   ^
                                    = 0
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
	edumazet@google.com, intel-wired-lan@lists.osuosl.org,
	jiri@nvidia.com, anthony.l.nguyen@intel.com,
	alexandr.lobakin@intel.com, sridhar.samudrala@intel.com,
	wojciech.drewek@intel.com, lukasz.czapnik@intel.com,
	shiraz.saleem@intel.com, jesse.brandeburg@intel.com,
	mustafa.ismail@intel.com, przemyslaw.kitszel@intel.com,
	piotr.raczynski@intel.com, jacob.e.keller@intel.com,
	david.m.ertman@intel.com, leszek.kaliszczuk@intel.com
Subject: Re: [PATCH net-next 12/13] ice, irdma: prepare reservation of MSI-X to reload
Date: Mon, 14 Nov 2022 21:08:56 -0800	[thread overview]
Message-ID: <20221114210856.0d76bb2c@kernel.org> (raw)
In-Reply-To: <20221114125755.13659-13-michal.swiatkowski@linux.intel.com>

On Mon, 14 Nov 2022 13:57:54 +0100 Michal Swiatkowski wrote:
> Move MSI-X number for LAN and RDMA to structure to have it in one
> place. Use req_msix to store how many MSI-X for each feature user
> requested. Structure msix is used to store the current number of MSI-X.
> 
> The MSI-X number needs to be adjust if kernel doesn't support that many
> MSI-X or if hardware doesn't support it. Rewrite MSI-X adjustment
> function to use it in both cases.
> 
> Use the same algorithm like previously. First allocate minimum MSI-X for
> each feature than if there is enough MSI-X distribute it equally between
> each one.

drivers/net/ethernet/intel/ice/ice_lib.c:455: warning: Function parameter or member 'vsi' not described in 'ice_vsi_alloc_def'
drivers/net/ethernet/intel/ice/ice_lib.c:455: warning: Excess function parameter 'vsi_type' description in 'ice_vsi_alloc_def'
drivers/net/ethernet/intel/ice/ice_main.c:4026:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
        return err;
               ^~~
drivers/net/ethernet/intel/ice/ice_main.c:4001:29: note: initialize the variable 'err' to silence this warning
        int v_wanted, v_actual, err, i;
                                   ^
                                    = 0

  reply	other threads:[~2022-11-15  5:09 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 12:57 [Intel-wired-lan] [PATCH net-next 00/13] resource management using devlink reload Michal Swiatkowski
2022-11-14 12:57 ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 01/13] ice: move RDMA init to ice_idc.c Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 02/13] ice: alloc id for RDMA using xa_array Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 03/13] ice: cleanup in VSI config/deconfig code Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 04/13] ice: split ice_vsi_setup into smaller functions Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-15  5:08   ` [Intel-wired-lan] " Jakub Kicinski
2022-11-15  5:08     ` Jakub Kicinski
2022-11-15  6:49     ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15  6:49       ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 05/13] ice: stop hard coding the ICE_VSI_CTRL location Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 06/13] ice: split probe into smaller functions Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 07/13] ice: sync netdev filters after clearing VSI Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 08/13] ice: move VSI delete outside deconfig Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 09/13] ice: update VSI instead of init in some case Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 10/13] ice: implement devlink reinit action Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 11/13] ice: introduce eswitch capable flag Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 12/13] ice, irdma: prepare reservation of MSI-X to reload Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-15  5:08   ` Jakub Kicinski [this message]
2022-11-15  5:08     ` Jakub Kicinski
2022-11-15  6:49     ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15  6:49       ` Michal Swiatkowski
2022-11-14 12:57 ` [Intel-wired-lan] [PATCH net-next 13/13] devlink, ice: add MSIX vectors as devlink resource Michal Swiatkowski
2022-11-14 12:57   ` Michal Swiatkowski
2022-11-14 15:28   ` [Intel-wired-lan] " Jiri Pirko
2022-11-14 15:28     ` Jiri Pirko
2022-11-14 16:03     ` [Intel-wired-lan] " Piotr Raczynski
2022-11-14 16:03       ` Piotr Raczynski
2022-11-15  6:56       ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15  6:56         ` Michal Swiatkowski
2022-11-15 12:08       ` [Intel-wired-lan] " Jiri Pirko
2022-11-15 12:08         ` Jiri Pirko
2022-11-14 13:23 ` [Intel-wired-lan] [PATCH net-next 00/13] resource management using devlink reload Leon Romanovsky
2022-11-14 13:23   ` Leon Romanovsky
2022-11-14 15:31   ` [Intel-wired-lan] " Samudrala, Sridhar
2022-11-14 15:31     ` Samudrala, Sridhar
2022-11-14 16:58     ` [Intel-wired-lan] " Keller, Jacob E
2022-11-14 16:58       ` Keller, Jacob E
2022-11-14 17:09       ` [Intel-wired-lan] " Leon Romanovsky
2022-11-14 17:09         ` Leon Romanovsky
2022-11-15  7:00         ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15  7:00           ` Michal Swiatkowski
2022-11-14 17:07     ` [Intel-wired-lan] " Leon Romanovsky
2022-11-14 17:07       ` Leon Romanovsky
2022-11-15  7:12       ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15  7:12         ` Michal Swiatkowski
2022-11-15  8:11         ` [Intel-wired-lan] " Leon Romanovsky
2022-11-15  8:11           ` Leon Romanovsky
2022-11-15  9:04           ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15  9:04             ` Michal Swiatkowski
2022-11-15  9:32             ` [Intel-wired-lan] " Leon Romanovsky
2022-11-15  9:32               ` Leon Romanovsky
2022-11-15 10:16               ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15 10:16                 ` Michal Swiatkowski
2022-11-15 12:12                 ` [Intel-wired-lan] " Leon Romanovsky
2022-11-15 12:12                   ` Leon Romanovsky
2022-11-15 14:02                   ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-15 14:02                     ` Michal Swiatkowski
2022-11-15 17:57                     ` [Intel-wired-lan] " Leon Romanovsky
2022-11-15 17:57                       ` Leon Romanovsky
2022-11-16  1:59                       ` [Intel-wired-lan] " Samudrala, Sridhar
2022-11-16  1:59                         ` Samudrala, Sridhar
2022-11-16  6:04                         ` [Intel-wired-lan] " Leon Romanovsky
2022-11-16  6:04                           ` Leon Romanovsky
2022-11-16 12:04                           ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-16 12:04                             ` Michal Swiatkowski
2022-11-16 17:59                             ` [Intel-wired-lan] " Leon Romanovsky
2022-11-16 17:59                               ` Leon Romanovsky
2022-11-17 11:10                               ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-17 11:10                                 ` Michal Swiatkowski
2022-11-17 11:45                                 ` [Intel-wired-lan] " Leon Romanovsky
2022-11-17 11:45                                   ` Leon Romanovsky
2022-11-17 13:39                                   ` [Intel-wired-lan] " Michal Swiatkowski
2022-11-17 13:39                                     ` Michal Swiatkowski
2022-11-17 17:38                                     ` [Intel-wired-lan] " Leon Romanovsky
2022-11-17 17:38                                       ` Leon Romanovsky
2022-11-18  3:36                                       ` [Intel-wired-lan] " Jakub Kicinski
2022-11-18  3:36                                         ` Jakub Kicinski
2022-11-18  6:20                                         ` [Intel-wired-lan] " Leon Romanovsky
2022-11-18  6:20                                           ` Leon Romanovsky
2022-11-18 14:23                                           ` [Intel-wired-lan] " Saleem, Shiraz
2022-11-18 14:23                                             ` Saleem, Shiraz
2022-11-18 17:31                                             ` [Intel-wired-lan] " Leon Romanovsky
2022-11-18 17:31                                               ` Leon Romanovsky
2022-11-20 22:24                                               ` [Intel-wired-lan] " Samudrala, Sridhar
2022-11-20 22:24                                                 ` Samudrala, Sridhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221114210856.0d76bb2c@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jiri@nvidia.com \
    --cc=leszek.kaliszczuk@intel.com \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=mustafa.ismail@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=shiraz.saleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.