All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag
@ 2022-12-02 10:04 Manorit Chawdhry
  2022-12-03  2:04 ` Ryan Eatmon
  0 siblings, 1 reply; 6+ messages in thread
From: Manorit Chawdhry @ 2022-12-02 10:04 UTC (permalink / raw)
  To: meta-ti
  Cc: Andrew Davis, Ryan Eatmon, Jayesh Choudhary, Praneeth Bajjuri,
	Manorit Chawdhry

optee-os was updated to 3.19 tag but the others were still outdated.

Updates other optee components to 3.19 tag

Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
---
 recipes-security/optee/optee-client_%.bbappend   | 4 ++--
 recipes-security/optee/optee-examples_%.bbappend | 4 ++--
 recipes-security/optee/optee-test_%.bbappend     | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/recipes-security/optee/optee-client_%.bbappend b/recipes-security/optee/optee-client_%.bbappend
index 5675570a..6737ba92 100644
--- a/recipes-security/optee/optee-client_%.bbappend
+++ b/recipes-security/optee/optee-client_%.bbappend
@@ -1,2 +1,2 @@
-PV_ti-soc = "3.17.0+git${SRCPV}"
-SRCREV_ti-soc = "a5c30b1277466a9bf85b62f45a6b00e79774e29c"
+PV_ti-soc = "3.19.0+git${SRCPV}"
+SRCREV_ti-soc = "140bf463046071d3ca5ebbde3fb21ee0854e1951"
diff --git a/recipes-security/optee/optee-examples_%.bbappend b/recipes-security/optee/optee-examples_%.bbappend
index 9941b345..dda7cbbf 100644
--- a/recipes-security/optee/optee-examples_%.bbappend
+++ b/recipes-security/optee/optee-examples_%.bbappend
@@ -1,5 +1,5 @@
-PV_ti-soc = "3.17.0+git${SRCPV}"
-SRCREV_ti-soc = "65fc74309e12189ad5b6ce3ffec37c8011088a5a"
+PV_ti-soc = "3.19.0+git${SRCPV}"
+SRCREV_ti-soc = "f301ee9df2129c0db683e726c91dc2cefe4cdb65"
 SRC_URI_ti-soc = "git://github.com/linaro-swg/optee_examples.git;protocol=https"
 
 DEPENDS_append_ti-soc = " python3-cryptography-native"
diff --git a/recipes-security/optee/optee-test_%.bbappend b/recipes-security/optee/optee-test_%.bbappend
index d81ae521..79b4b4d6 100644
--- a/recipes-security/optee/optee-test_%.bbappend
+++ b/recipes-security/optee/optee-test_%.bbappend
@@ -1,5 +1,5 @@
-PV_ti-soc = "3.17.0+git${SRCPV}"
-SRCREV_ti-soc = "8a698baf9e8e010e4d8d52e6aded42dfc31e5b25"
+PV_ti-soc = "3.19.0+git${SRCPV}"
+SRCREV_ti-soc = "ab9863cc187724e54c032b738c28bd6e9460a4db"
 SRC_URI_ti-soc = "git://github.com/OP-TEE/optee_test.git;protocol=https"
 
 DEPENDS_append_ti-soc = " python3-cryptography-native"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag
  2022-12-02 10:04 [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag Manorit Chawdhry
@ 2022-12-03  2:04 ` Ryan Eatmon
  2022-12-03 15:48   ` Denys Dmytriyenko
  0 siblings, 1 reply; 6+ messages in thread
From: Ryan Eatmon @ 2022-12-03  2:04 UTC (permalink / raw)
  To: Manorit Chawdhry, meta-ti
  Cc: Andrew Davis, Jayesh Choudhary, Praneeth Bajjuri



On 12/2/2022 4:04, Manorit Chawdhry wrote:
> optee-os was updated to 3.19 tag but the others were still outdated.
> 
> Updates other optee components to 3.19 tag
> 
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
>   recipes-security/optee/optee-client_%.bbappend   | 4 ++--
>   recipes-security/optee/optee-examples_%.bbappend | 4 ++--
>   recipes-security/optee/optee-test_%.bbappend     | 4 ++--
>   3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/recipes-security/optee/optee-client_%.bbappend b/recipes-security/optee/optee-client_%.bbappend
> index 5675570a..6737ba92 100644
> --- a/recipes-security/optee/optee-client_%.bbappend
> +++ b/recipes-security/optee/optee-client_%.bbappend
> @@ -1,2 +1,2 @@
> -PV_ti-soc = "3.17.0+git${SRCPV}"
> -SRCREV_ti-soc = "a5c30b1277466a9bf85b62f45a6b00e79774e29c"
> +PV_ti-soc = "3.19.0+git${SRCPV}"
> +SRCREV_ti-soc = "140bf463046071d3ca5ebbde3fb21ee0854e1951"

optee-client will not build against this SRCREV.  They added a call to 
pkg-config which is not readily available to the recipe without a change 
to your patch.

You need to add:

DEPENDS += "pkgconfig"


Please do so and resubmit the patch.


> diff --git a/recipes-security/optee/optee-examples_%.bbappend b/recipes-security/optee/optee-examples_%.bbappend
> index 9941b345..dda7cbbf 100644
> --- a/recipes-security/optee/optee-examples_%.bbappend
> +++ b/recipes-security/optee/optee-examples_%.bbappend
> @@ -1,5 +1,5 @@
> -PV_ti-soc = "3.17.0+git${SRCPV}"
> -SRCREV_ti-soc = "65fc74309e12189ad5b6ce3ffec37c8011088a5a"
> +PV_ti-soc = "3.19.0+git${SRCPV}"
> +SRCREV_ti-soc = "f301ee9df2129c0db683e726c91dc2cefe4cdb65"
>   SRC_URI_ti-soc = "git://github.com/linaro-swg/optee_examples.git;protocol=https"
>   
>   DEPENDS_append_ti-soc = " python3-cryptography-native"
> diff --git a/recipes-security/optee/optee-test_%.bbappend b/recipes-security/optee/optee-test_%.bbappend
> index d81ae521..79b4b4d6 100644
> --- a/recipes-security/optee/optee-test_%.bbappend
> +++ b/recipes-security/optee/optee-test_%.bbappend
> @@ -1,5 +1,5 @@
> -PV_ti-soc = "3.17.0+git${SRCPV}"
> -SRCREV_ti-soc = "8a698baf9e8e010e4d8d52e6aded42dfc31e5b25"
> +PV_ti-soc = "3.19.0+git${SRCPV}"
> +SRCREV_ti-soc = "ab9863cc187724e54c032b738c28bd6e9460a4db"
>   SRC_URI_ti-soc = "git://github.com/OP-TEE/optee_test.git;protocol=https"
>   
>   DEPENDS_append_ti-soc = " python3-cryptography-native"

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag
  2022-12-03  2:04 ` Ryan Eatmon
@ 2022-12-03 15:48   ` Denys Dmytriyenko
  2022-12-03 17:04     ` Ryan Eatmon
  0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2022-12-03 15:48 UTC (permalink / raw)
  To: reatmon
  Cc: Manorit Chawdhry, meta-ti, Andrew Davis, Jayesh Choudhary,
	Praneeth Bajjuri

On Fri, Dec 02, 2022 at 08:04:52PM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 12/2/2022 4:04, Manorit Chawdhry wrote:
> >optee-os was updated to 3.19 tag but the others were still outdated.
> >
> >Updates other optee components to 3.19 tag
> >
> >Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> >---
> >  recipes-security/optee/optee-client_%.bbappend   | 4 ++--
> >  recipes-security/optee/optee-examples_%.bbappend | 4 ++--
> >  recipes-security/optee/optee-test_%.bbappend     | 4 ++--
> >  3 files changed, 6 insertions(+), 6 deletions(-)
> >
> >diff --git a/recipes-security/optee/optee-client_%.bbappend b/recipes-security/optee/optee-client_%.bbappend
> >index 5675570a..6737ba92 100644
> >--- a/recipes-security/optee/optee-client_%.bbappend
> >+++ b/recipes-security/optee/optee-client_%.bbappend
> >@@ -1,2 +1,2 @@
> >-PV_ti-soc = "3.17.0+git${SRCPV}"
> >-SRCREV_ti-soc = "a5c30b1277466a9bf85b62f45a6b00e79774e29c"
> >+PV_ti-soc = "3.19.0+git${SRCPV}"
> >+SRCREV_ti-soc = "140bf463046071d3ca5ebbde3fb21ee0854e1951"
> 
> optee-client will not build against this SRCREV.  They added a call
> to pkg-config which is not readily available to the recipe without a
> change to your patch.
> 
> You need to add:
> 
> DEPENDS += "pkgconfig"

You probably don't want a target pkgconfig, but a native one.
Do this instead:

inherit pkgconfig


> Please do so and resubmit the patch.
> 
> 
> >diff --git a/recipes-security/optee/optee-examples_%.bbappend b/recipes-security/optee/optee-examples_%.bbappend
> >index 9941b345..dda7cbbf 100644
> >--- a/recipes-security/optee/optee-examples_%.bbappend
> >+++ b/recipes-security/optee/optee-examples_%.bbappend
> >@@ -1,5 +1,5 @@
> >-PV_ti-soc = "3.17.0+git${SRCPV}"
> >-SRCREV_ti-soc = "65fc74309e12189ad5b6ce3ffec37c8011088a5a"
> >+PV_ti-soc = "3.19.0+git${SRCPV}"
> >+SRCREV_ti-soc = "f301ee9df2129c0db683e726c91dc2cefe4cdb65"
> >  SRC_URI_ti-soc = "git://github.com/linaro-swg/optee_examples.git;protocol=https"
> >  DEPENDS_append_ti-soc = " python3-cryptography-native"
> >diff --git a/recipes-security/optee/optee-test_%.bbappend b/recipes-security/optee/optee-test_%.bbappend
> >index d81ae521..79b4b4d6 100644
> >--- a/recipes-security/optee/optee-test_%.bbappend
> >+++ b/recipes-security/optee/optee-test_%.bbappend
> >@@ -1,5 +1,5 @@
> >-PV_ti-soc = "3.17.0+git${SRCPV}"
> >-SRCREV_ti-soc = "8a698baf9e8e010e4d8d52e6aded42dfc31e5b25"
> >+PV_ti-soc = "3.19.0+git${SRCPV}"
> >+SRCREV_ti-soc = "ab9863cc187724e54c032b738c28bd6e9460a4db"
> >  SRC_URI_ti-soc = "git://github.com/OP-TEE/optee_test.git;protocol=https"
> >  DEPENDS_append_ti-soc = " python3-cryptography-native"
> 
> -- 
> Ryan Eatmon                reatmon@ti.com
> -----------------------------------------
> Texas Instruments, Inc.  -  LCPD  -  MGTS

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15397): https://lists.yoctoproject.org/g/meta-ti/message/15397
> Mute This Topic: https://lists.yoctoproject.org/mt/95403088/3617104
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [denis@denix.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag
  2022-12-03 15:48   ` Denys Dmytriyenko
@ 2022-12-03 17:04     ` Ryan Eatmon
  2022-12-04 22:56       ` Denys Dmytriyenko
  0 siblings, 1 reply; 6+ messages in thread
From: Ryan Eatmon @ 2022-12-03 17:04 UTC (permalink / raw)
  To: Denys Dmytriyenko
  Cc: Manorit Chawdhry, meta-ti, Andrew Davis, Jayesh Choudhary,
	Praneeth Bajjuri



On 12/3/2022 9:48, Denys Dmytriyenko wrote:
> On Fri, Dec 02, 2022 at 08:04:52PM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
>>
>>
>> On 12/2/2022 4:04, Manorit Chawdhry wrote:
>>> optee-os was updated to 3.19 tag but the others were still outdated.
>>>
>>> Updates other optee components to 3.19 tag
>>>
>>> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
>>> ---
>>>   recipes-security/optee/optee-client_%.bbappend   | 4 ++--
>>>   recipes-security/optee/optee-examples_%.bbappend | 4 ++--
>>>   recipes-security/optee/optee-test_%.bbappend     | 4 ++--
>>>   3 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/recipes-security/optee/optee-client_%.bbappend b/recipes-security/optee/optee-client_%.bbappend
>>> index 5675570a..6737ba92 100644
>>> --- a/recipes-security/optee/optee-client_%.bbappend
>>> +++ b/recipes-security/optee/optee-client_%.bbappend
>>> @@ -1,2 +1,2 @@
>>> -PV_ti-soc = "3.17.0+git${SRCPV}"
>>> -SRCREV_ti-soc = "a5c30b1277466a9bf85b62f45a6b00e79774e29c"
>>> +PV_ti-soc = "3.19.0+git${SRCPV}"
>>> +SRCREV_ti-soc = "140bf463046071d3ca5ebbde3fb21ee0854e1951"
>>
>> optee-client will not build against this SRCREV.  They added a call
>> to pkg-config which is not readily available to the recipe without a
>> change to your patch.
>>
>> You need to add:
>>
>> DEPENDS += "pkgconfig"
> 
> You probably don't want a target pkgconfig, but a native one.
> Do this instead:
> 
> inherit pkgconfig

Actually, I thought that at first too and tried all variations of the 
native (inherit, depends, hosttools, etc...).  The only thing that 
actually made it work was the above.

In this case, pkg-config is not being called from configure, but from 
the Makefile.  The Makefile is trying to make sure that libuuid is 
installed for the target.  And the native would only make sure it is 
installed on the native side, where as pkgconfig for target looks in all 
of the places for the target library.  At least that was my 
understanding in reading online docs about it.

But depending on pkgconfig (for target) actually fixed the compile 
issue.  If you want to verify that or disprove it I would be most 
appreciative.  I spent a few hours banging my head on this one.


>> Please do so and resubmit the patch.
>>
>>
>>> diff --git a/recipes-security/optee/optee-examples_%.bbappend b/recipes-security/optee/optee-examples_%.bbappend
>>> index 9941b345..dda7cbbf 100644
>>> --- a/recipes-security/optee/optee-examples_%.bbappend
>>> +++ b/recipes-security/optee/optee-examples_%.bbappend
>>> @@ -1,5 +1,5 @@
>>> -PV_ti-soc = "3.17.0+git${SRCPV}"
>>> -SRCREV_ti-soc = "65fc74309e12189ad5b6ce3ffec37c8011088a5a"
>>> +PV_ti-soc = "3.19.0+git${SRCPV}"
>>> +SRCREV_ti-soc = "f301ee9df2129c0db683e726c91dc2cefe4cdb65"
>>>   SRC_URI_ti-soc = "git://github.com/linaro-swg/optee_examples.git;protocol=https"
>>>   DEPENDS_append_ti-soc = " python3-cryptography-native"
>>> diff --git a/recipes-security/optee/optee-test_%.bbappend b/recipes-security/optee/optee-test_%.bbappend
>>> index d81ae521..79b4b4d6 100644
>>> --- a/recipes-security/optee/optee-test_%.bbappend
>>> +++ b/recipes-security/optee/optee-test_%.bbappend
>>> @@ -1,5 +1,5 @@
>>> -PV_ti-soc = "3.17.0+git${SRCPV}"
>>> -SRCREV_ti-soc = "8a698baf9e8e010e4d8d52e6aded42dfc31e5b25"
>>> +PV_ti-soc = "3.19.0+git${SRCPV}"
>>> +SRCREV_ti-soc = "ab9863cc187724e54c032b738c28bd6e9460a4db"
>>>   SRC_URI_ti-soc = "git://github.com/OP-TEE/optee_test.git;protocol=https"
>>>   DEPENDS_append_ti-soc = " python3-cryptography-native"
>>
>> -- 
>> Ryan Eatmon                reatmon@ti.com
>> -----------------------------------------
>> Texas Instruments, Inc.  -  LCPD  -  MGTS
> 
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#15397): https://lists.yoctoproject.org/g/meta-ti/message/15397
>> Mute This Topic: https://lists.yoctoproject.org/mt/95403088/3617104
>> Group Owner: meta-ti+owner@lists.yoctoproject.org
>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [denis@denix.org]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
> 
> 

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag
  2022-12-03 17:04     ` Ryan Eatmon
@ 2022-12-04 22:56       ` Denys Dmytriyenko
  2022-12-05 14:23         ` Ryan Eatmon
  0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2022-12-04 22:56 UTC (permalink / raw)
  To: Ryan Eatmon
  Cc: Manorit Chawdhry, meta-ti, Andrew Davis, Jayesh Choudhary,
	Praneeth Bajjuri

On Sat, Dec 03, 2022 at 11:04:00AM -0600, Ryan Eatmon wrote:
> 
> 
> On 12/3/2022 9:48, Denys Dmytriyenko wrote:
> >On Fri, Dec 02, 2022 at 08:04:52PM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> >>
> >>
> >>On 12/2/2022 4:04, Manorit Chawdhry wrote:
> >>>optee-os was updated to 3.19 tag but the others were still outdated.
> >>>
> >>>Updates other optee components to 3.19 tag
> >>>
> >>>Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> >>>---
> >>>  recipes-security/optee/optee-client_%.bbappend   | 4 ++--
> >>>  recipes-security/optee/optee-examples_%.bbappend | 4 ++--
> >>>  recipes-security/optee/optee-test_%.bbappend     | 4 ++--
> >>>  3 files changed, 6 insertions(+), 6 deletions(-)
> >>>
> >>>diff --git a/recipes-security/optee/optee-client_%.bbappend b/recipes-security/optee/optee-client_%.bbappend
> >>>index 5675570a..6737ba92 100644
> >>>--- a/recipes-security/optee/optee-client_%.bbappend
> >>>+++ b/recipes-security/optee/optee-client_%.bbappend
> >>>@@ -1,2 +1,2 @@
> >>>-PV_ti-soc = "3.17.0+git${SRCPV}"
> >>>-SRCREV_ti-soc = "a5c30b1277466a9bf85b62f45a6b00e79774e29c"
> >>>+PV_ti-soc = "3.19.0+git${SRCPV}"
> >>>+SRCREV_ti-soc = "140bf463046071d3ca5ebbde3fb21ee0854e1951"
> >>
> >>optee-client will not build against this SRCREV.  They added a call
> >>to pkg-config which is not readily available to the recipe without a
> >>change to your patch.
> >>
> >>You need to add:
> >>
> >>DEPENDS += "pkgconfig"
> >
> >You probably don't want a target pkgconfig, but a native one.
> >Do this instead:
> >
> >inherit pkgconfig
> 
> Actually, I thought that at first too and tried all variations of
> the native (inherit, depends, hosttools, etc...).  The only thing
> that actually made it work was the above.
> 
> In this case, pkg-config is not being called from configure, but
> from the Makefile.  The Makefile is trying to make sure that libuuid
> is installed for the target.  And the native would only make sure it
> is installed on the native side, where as pkgconfig for target looks
> in all of the places for the target library.  At least that was my
> understanding in reading online docs about it.
> 
> But depending on pkgconfig (for target) actually fixed the compile
> issue.  If you want to verify that or disprove it I would be most
> appreciative.  I spent a few hours banging my head on this one.

Looks like you've done your research - it's a bit strange use of pkgconfig 
by optee-client, not a basic normal use case I was referring to.

If the Makefile is trying to check if libuuid is installed, don't you need to 
also have it the DEPENDS?

And we'll see how meta-arm/master handles it soon enough, when updating to 
3.19 upstream...

-- 
Denys


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag
  2022-12-04 22:56       ` Denys Dmytriyenko
@ 2022-12-05 14:23         ` Ryan Eatmon
  0 siblings, 0 replies; 6+ messages in thread
From: Ryan Eatmon @ 2022-12-05 14:23 UTC (permalink / raw)
  To: Denys Dmytriyenko
  Cc: Manorit Chawdhry, meta-ti, Andrew Davis, Jayesh Choudhary,
	Praneeth Bajjuri



On 12/4/2022 16:56, Denys Dmytriyenko wrote:
> On Sat, Dec 03, 2022 at 11:04:00AM -0600, Ryan Eatmon wrote:
>>
>>
>> On 12/3/2022 9:48, Denys Dmytriyenko wrote:
>>> On Fri, Dec 02, 2022 at 08:04:52PM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
>>>>
>>>>
>>>> On 12/2/2022 4:04, Manorit Chawdhry wrote:
>>>>> optee-os was updated to 3.19 tag but the others were still outdated.
>>>>>
>>>>> Updates other optee components to 3.19 tag
>>>>>
>>>>> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
>>>>> ---
>>>>>   recipes-security/optee/optee-client_%.bbappend   | 4 ++--
>>>>>   recipes-security/optee/optee-examples_%.bbappend | 4 ++--
>>>>>   recipes-security/optee/optee-test_%.bbappend     | 4 ++--
>>>>>   3 files changed, 6 insertions(+), 6 deletions(-)
>>>>>
>>>>> diff --git a/recipes-security/optee/optee-client_%.bbappend b/recipes-security/optee/optee-client_%.bbappend
>>>>> index 5675570a..6737ba92 100644
>>>>> --- a/recipes-security/optee/optee-client_%.bbappend
>>>>> +++ b/recipes-security/optee/optee-client_%.bbappend
>>>>> @@ -1,2 +1,2 @@
>>>>> -PV_ti-soc = "3.17.0+git${SRCPV}"
>>>>> -SRCREV_ti-soc = "a5c30b1277466a9bf85b62f45a6b00e79774e29c"
>>>>> +PV_ti-soc = "3.19.0+git${SRCPV}"
>>>>> +SRCREV_ti-soc = "140bf463046071d3ca5ebbde3fb21ee0854e1951"
>>>>
>>>> optee-client will not build against this SRCREV.  They added a call
>>>> to pkg-config which is not readily available to the recipe without a
>>>> change to your patch.
>>>>
>>>> You need to add:
>>>>
>>>> DEPENDS += "pkgconfig"
>>>
>>> You probably don't want a target pkgconfig, but a native one.
>>> Do this instead:
>>>
>>> inherit pkgconfig
>>
>> Actually, I thought that at first too and tried all variations of
>> the native (inherit, depends, hosttools, etc...).  The only thing
>> that actually made it work was the above.
>>
>> In this case, pkg-config is not being called from configure, but
>> from the Makefile.  The Makefile is trying to make sure that libuuid
>> is installed for the target.  And the native would only make sure it
>> is installed on the native side, where as pkgconfig for target looks
>> in all of the places for the target library.  At least that was my
>> understanding in reading online docs about it.
>>
>> But depending on pkgconfig (for target) actually fixed the compile
>> issue.  If you want to verify that or disprove it I would be most
>> appreciative.  I spent a few hours banging my head on this one.
> 
> Looks like you've done your research - it's a bit strange use of pkgconfig
> by optee-client, not a basic normal use case I was referring to.
> 
> If the Makefile is trying to check if libuuid is installed, don't you need to
> also have it the DEPENDS?
> 
> And we'll see how meta-arm/master handles it soon enough, when updating to
> 3.19 upstream...
> 

I was thinking about the libuuid dependency over the weekend.

And I agree, I can't wait to see how upstream meta-arm handles this. 
Luckily this is just a "temporary" patch to get it working for us since 
our preference is to get upstream to handle things like this and not 
carry patches like this in the long term in meta-ti.



-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-12-05 14:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-02 10:04 [meta-ti][dunfell][PATCH] optee: update optee-client, optee-test, optee-examples to 3.19 tag Manorit Chawdhry
2022-12-03  2:04 ` Ryan Eatmon
2022-12-03 15:48   ` Denys Dmytriyenko
2022-12-03 17:04     ` Ryan Eatmon
2022-12-04 22:56       ` Denys Dmytriyenko
2022-12-05 14:23         ` Ryan Eatmon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.