All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alvaro Karsz <alvaro.karsz@solid-run.com>
To: virtualization@lists.linux-foundation.org, linux-pci@vger.kernel.org
Cc: bhelgaas@google.com, Alvaro Karsz <alvaro.karsz@solid-run.com>
Subject: [RESEND PATCH 2/3] New PCI quirk for SolidRun SNET DPU.
Date: Mon, 19 Dec 2022 10:35:10 +0200	[thread overview]
Message-ID: <20221219083511.73205-3-alvaro.karsz@solid-run.com> (raw)
In-Reply-To: <20221219083511.73205-1-alvaro.karsz@solid-run.com>

The DPU advertises FLR, but it may cause the device to hang.
This only happens with revision 0x1.

Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
---
 drivers/pci/quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 285acc4aacc..809d03272c2 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5343,6 +5343,14 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x149c, quirk_no_flr);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1502, quirk_no_flr);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1503, quirk_no_flr);
 
+/* FLR may cause the SolidRun SNET DPU (rev 0x1) to hang */
+static void quirk_no_flr_snet(struct pci_dev *dev)
+{
+	if (dev->revision == 0x1)
+		quirk_no_flr(dev);
+}
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLIDRUN, 0x1000, quirk_no_flr_snet);
+
 static void quirk_no_ext_tags(struct pci_dev *pdev)
 {
 	struct pci_host_bridge *bridge = pci_find_host_bridge(pdev->bus);
-- 
2.32.0


WARNING: multiple messages have this Message-ID (diff)
From: Alvaro Karsz <alvaro.karsz@solid-run.com>
To: virtualization@lists.linux-foundation.org, linux-pci@vger.kernel.org
Cc: bhelgaas@google.com
Subject: [RESEND PATCH 2/3] New PCI quirk for SolidRun SNET DPU.
Date: Mon, 19 Dec 2022 10:35:10 +0200	[thread overview]
Message-ID: <20221219083511.73205-3-alvaro.karsz@solid-run.com> (raw)
In-Reply-To: <20221219083511.73205-1-alvaro.karsz@solid-run.com>

The DPU advertises FLR, but it may cause the device to hang.
This only happens with revision 0x1.

Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
---
 drivers/pci/quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 285acc4aacc..809d03272c2 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5343,6 +5343,14 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x149c, quirk_no_flr);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1502, quirk_no_flr);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1503, quirk_no_flr);
 
+/* FLR may cause the SolidRun SNET DPU (rev 0x1) to hang */
+static void quirk_no_flr_snet(struct pci_dev *dev)
+{
+	if (dev->revision == 0x1)
+		quirk_no_flr(dev);
+}
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLIDRUN, 0x1000, quirk_no_flr_snet);
+
 static void quirk_no_ext_tags(struct pci_dev *pdev)
 {
 	struct pci_host_bridge *bridge = pci_find_host_bridge(pdev->bus);
-- 
2.32.0

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2022-12-19  8:35 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19  8:35 [RESEND PATCH 0/3] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-19  8:35 ` Alvaro Karsz
2022-12-19  8:35 ` [RESEND PATCH 1/3] Add SolidRun vendor id Alvaro Karsz
2022-12-19  8:35   ` Alvaro Karsz
2022-12-29 19:55   ` Bjorn Helgaas
2022-12-29 19:55     ` Bjorn Helgaas
2022-12-29 21:06     ` Alvaro Karsz
2022-12-29 21:06       ` Alvaro Karsz
2022-12-29 21:29       ` Bjorn Helgaas
2022-12-29 21:29         ` Bjorn Helgaas
2022-12-29 22:27         ` Michael S. Tsirkin
2022-12-29 22:27           ` Michael S. Tsirkin
2022-12-19  8:35 ` Alvaro Karsz [this message]
2022-12-19  8:35   ` [RESEND PATCH 2/3] New PCI quirk for SolidRun SNET DPU Alvaro Karsz
2022-12-29 19:55   ` Bjorn Helgaas
2022-12-29 19:55     ` Bjorn Helgaas
2022-12-19  8:35 ` [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-19  8:35   ` Alvaro Karsz
2022-12-19 10:43   ` Michael S. Tsirkin
2022-12-19 10:43     ` Michael S. Tsirkin
2022-12-19 10:44     ` Michael S. Tsirkin
2022-12-19 10:44       ` Michael S. Tsirkin
2022-12-19 10:49   ` Michael S. Tsirkin
2022-12-19 10:49     ` Michael S. Tsirkin
2022-12-19 10:55     ` Alvaro Karsz
2022-12-19 10:55       ` Alvaro Karsz
2022-12-19 11:03       ` Michael S. Tsirkin
2022-12-19 11:03         ` Michael S. Tsirkin
2022-12-19 11:32         ` Alvaro Karsz
2022-12-19 11:32           ` Alvaro Karsz
2022-12-19 16:40           ` Michael S. Tsirkin
2022-12-19 16:40             ` Michael S. Tsirkin
2022-12-20  6:50   ` Jason Wang
2022-12-20  6:50     ` Jason Wang
2022-12-20  7:25     ` Alvaro Karsz
2022-12-20  7:25       ` Alvaro Karsz
2022-12-20  8:54       ` Jason Wang
2022-12-20  8:54         ` Jason Wang
2022-12-20 16:32   ` Nathan Chancellor
2022-12-20 16:46     ` Alvaro Karsz
2022-12-20 16:46       ` Alvaro Karsz
2022-12-20 20:49       ` Nathan Chancellor
2022-12-20 23:20         ` Michael S. Tsirkin
2022-12-20 23:20           ` Michael S. Tsirkin
2022-12-20 21:48       ` Arnd Bergmann
2022-12-20 21:48         ` Arnd Bergmann
2022-12-21  6:40       ` Michael S. Tsirkin
2022-12-21  6:40         ` Michael S. Tsirkin
2022-12-21  7:05         ` Alvaro Karsz
2022-12-21  7:05           ` Alvaro Karsz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221219083511.73205-3-alvaro.karsz@solid-run.com \
    --to=alvaro.karsz@solid-run.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.