From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
virtualization@lists.linux-foundation.org,
linux-pci@vger.kernel.org, bhelgaas@google.com,
Jason Wang <jasowang@redhat.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
llvm@lists.linux.dev
Subject: Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.
Date: Wed, 21 Dec 2022 01:40:15 -0500 [thread overview]
Message-ID: <20221221013907-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJs=3_B7WoERAiXPyvz=6d7O5rcwXMfWZJFsi_ds-OAemvfcgQ@mail.gmail.com>
On Tue, Dec 20, 2022 at 06:46:20PM +0200, Alvaro Karsz wrote:
> Hi Nathan,
>
> > This does not appear to be a false positive but what was the intent
> > here? Should the local name variables increase their length or should
> > the buffer length be reduced?
>
> You're right, the local name variables and snprintf argument don't match.
> Thanks for noticing.
> I think that we should increase the name variables to be
> SNET_NAME_SIZE bytes long.
>
> How should I proceed from here?
> Should I create a new version for this patch, or should I fix it in a
> follow up patch?
>
> Thanks,
> Alvaro
Please post a follow-up ASAP. I can squash myself if I rebase.
Thanks!
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-pci@vger.kernel.org, llvm@lists.linux.dev,
virtualization@lists.linux-foundation.org,
Nathan Chancellor <nathan@kernel.org>,
bhelgaas@google.com, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver.
Date: Wed, 21 Dec 2022 01:40:15 -0500 [thread overview]
Message-ID: <20221221013907-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJs=3_B7WoERAiXPyvz=6d7O5rcwXMfWZJFsi_ds-OAemvfcgQ@mail.gmail.com>
On Tue, Dec 20, 2022 at 06:46:20PM +0200, Alvaro Karsz wrote:
> Hi Nathan,
>
> > This does not appear to be a false positive but what was the intent
> > here? Should the local name variables increase their length or should
> > the buffer length be reduced?
>
> You're right, the local name variables and snprintf argument don't match.
> Thanks for noticing.
> I think that we should increase the name variables to be
> SNET_NAME_SIZE bytes long.
>
> How should I proceed from here?
> Should I create a new version for this patch, or should I fix it in a
> follow up patch?
>
> Thanks,
> Alvaro
Please post a follow-up ASAP. I can squash myself if I rebase.
Thanks!
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-12-21 6:41 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 8:35 [RESEND PATCH 0/3] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-19 8:35 ` Alvaro Karsz
2022-12-19 8:35 ` [RESEND PATCH 1/3] Add SolidRun vendor id Alvaro Karsz
2022-12-19 8:35 ` Alvaro Karsz
2022-12-29 19:55 ` Bjorn Helgaas
2022-12-29 19:55 ` Bjorn Helgaas
2022-12-29 21:06 ` Alvaro Karsz
2022-12-29 21:06 ` Alvaro Karsz
2022-12-29 21:29 ` Bjorn Helgaas
2022-12-29 21:29 ` Bjorn Helgaas
2022-12-29 22:27 ` Michael S. Tsirkin
2022-12-29 22:27 ` Michael S. Tsirkin
2022-12-19 8:35 ` [RESEND PATCH 2/3] New PCI quirk for SolidRun SNET DPU Alvaro Karsz
2022-12-19 8:35 ` Alvaro Karsz
2022-12-29 19:55 ` Bjorn Helgaas
2022-12-29 19:55 ` Bjorn Helgaas
2022-12-19 8:35 ` [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-19 8:35 ` Alvaro Karsz
2022-12-19 10:43 ` Michael S. Tsirkin
2022-12-19 10:43 ` Michael S. Tsirkin
2022-12-19 10:44 ` Michael S. Tsirkin
2022-12-19 10:44 ` Michael S. Tsirkin
2022-12-19 10:49 ` Michael S. Tsirkin
2022-12-19 10:49 ` Michael S. Tsirkin
2022-12-19 10:55 ` Alvaro Karsz
2022-12-19 10:55 ` Alvaro Karsz
2022-12-19 11:03 ` Michael S. Tsirkin
2022-12-19 11:03 ` Michael S. Tsirkin
2022-12-19 11:32 ` Alvaro Karsz
2022-12-19 11:32 ` Alvaro Karsz
2022-12-19 16:40 ` Michael S. Tsirkin
2022-12-19 16:40 ` Michael S. Tsirkin
2022-12-20 6:50 ` Jason Wang
2022-12-20 6:50 ` Jason Wang
2022-12-20 7:25 ` Alvaro Karsz
2022-12-20 7:25 ` Alvaro Karsz
2022-12-20 8:54 ` Jason Wang
2022-12-20 8:54 ` Jason Wang
2022-12-20 16:32 ` Nathan Chancellor
2022-12-20 16:46 ` Alvaro Karsz
2022-12-20 16:46 ` Alvaro Karsz
2022-12-20 20:49 ` Nathan Chancellor
2022-12-20 23:20 ` Michael S. Tsirkin
2022-12-20 23:20 ` Michael S. Tsirkin
2022-12-20 21:48 ` Arnd Bergmann
2022-12-20 21:48 ` Arnd Bergmann
2022-12-21 6:40 ` Michael S. Tsirkin [this message]
2022-12-21 6:40 ` Michael S. Tsirkin
2022-12-21 7:05 ` Alvaro Karsz
2022-12-21 7:05 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221013907-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=bhelgaas@google.com \
--cc=jasowang@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.