All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergiu Moga <sergiu.moga@microchip.com>
To: <marex@denx.de>, <michal.simek@amd.com>, <jim.t90615@gmail.com>,
	<sumit.garg@linaro.org>, <weijie.gao@mediatek.com>,
	<sjg@chromium.org>, <sergiu.moga@microchip.com>,
	<eugen.hristev@microchip.com>, <cristian.birsan@microchip.com>
Cc: <u-boot@lists.denx.de>, Mihai Sain <mihai.sain@microchip.com>
Subject: [PATCH 3/4] usb: ohci-at91: Add `ohci_t` field in `ohci_at91_priv`
Date: Fri, 23 Dec 2022 14:34:54 +0200	[thread overview]
Message-ID: <20221223123454.362757-4-sergiu.moga@microchip.com> (raw)
In-Reply-To: <20221223123454.362757-1-sergiu.moga@microchip.com>

From: Cristian Birsan <cristian.birsan@microchip.com>

The `ohci_register` function expects that the OHCI driver's
priv is a struct whose first field is of type `ohci_t`.
The original conversion to DM did not have it and this
inconsistency revealed itself whenever U-Boot required
multiple memory allocations resulting in a memory overwrite
of where this field would supposedly be.

Thus, add this missing field and automatically increase
the implicit size of the driver's priv to avoid whatever
future memory allocations may take place from overwriting
it.

Fixes: de1cf0a9c6 ("drivers: usb: ohci-at91: Enable OHCI functionality and register into DM")
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
Tested-by: Mihai Sain <mihai.sain@microchip.com>
---
 drivers/usb/host/ohci-at91.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index 9ae55c6e5d..5cf8f283e5 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -86,6 +86,7 @@ struct at91_usbh_data {
 };
 
 struct ohci_at91_priv {
+	ohci_t ohci;
 	struct clk *iclk;
 	struct clk *fclk;
 	struct clk *hclk;
-- 
2.34.1


  parent reply	other threads:[~2022-12-23 12:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 12:34 [PATCH 0/4] Register at91 OHCI into DM and add SAMA7 USB PHY's Sergiu Moga
2022-12-23 12:34 ` [PATCH 1/4] phy: at91: Add support for the USB 2.0 PHY's of SAMA7 Sergiu Moga
2022-12-23 12:34 ` [PATCH 2/4] usb: ohci-at91: Enable OHCI functionality and register into DM Sergiu Moga
2023-01-02 23:26   ` Marek Vasut
2023-01-03 12:11     ` Sergiu.Moga
2023-01-03 14:34       ` Marek Vasut
2023-01-03 15:49         ` Sergiu.Moga
2023-01-03 15:57           ` Marek Vasut
2023-01-03 16:01             ` Sergiu.Moga
2023-01-03 16:04               ` Marek Vasut
2022-12-23 12:34 ` Sergiu Moga [this message]
2023-01-02 23:27   ` [PATCH 3/4] usb: ohci-at91: Add `ohci_t` field in `ohci_at91_priv` Marek Vasut
2022-12-23 12:34 ` [PATCH 4/4] usb: ohci-at91: Add USB PHY functionality Sergiu Moga
2023-01-02 23:33   ` Marek Vasut
2023-01-03 13:02     ` Sergiu.Moga
2023-01-03 14:38       ` Marek Vasut
2022-12-23 12:44 ` [PATCH 0/4] Register at91 OHCI into DM and add SAMA7 USB PHY's Sergiu.Moga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221223123454.362757-4-sergiu.moga@microchip.com \
    --to=sergiu.moga@microchip.com \
    --cc=cristian.birsan@microchip.com \
    --cc=eugen.hristev@microchip.com \
    --cc=jim.t90615@gmail.com \
    --cc=marex@denx.de \
    --cc=michal.simek@amd.com \
    --cc=mihai.sain@microchip.com \
    --cc=sjg@chromium.org \
    --cc=sumit.garg@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.