All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Sergiu.Moga@microchip.com, michal.simek@amd.com,
	jim.t90615@gmail.com, sumit.garg@linaro.org,
	weijie.gao@mediatek.com, sjg@chromium.org,
	Eugen.Hristev@microchip.com, Cristian.Birsan@microchip.com
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 2/4] usb: ohci-at91: Enable OHCI functionality and register into DM
Date: Tue, 3 Jan 2023 16:57:55 +0100	[thread overview]
Message-ID: <36beada3-02ff-f33f-dc4e-517ccbc8cdf3@denx.de> (raw)
In-Reply-To: <a614b3b8-a865-72d7-b0b8-a35e68d4f2ad@microchip.com>

On 1/3/23 16:49, Sergiu.Moga@microchip.com wrote:
> On 03.01.2023 16:34, Marek Vasut wrote:
>> On 1/3/23 13:11, Sergiu.Moga@microchip.com wrote:
>>> On 03.01.2023 01:26, Marek Vasut wrote:
>>>> On 12/23/22 13:34, Sergiu Moga wrote:
>>>>
>>>> [...]
>>>>
>>>>> diff --git a/drivers/usb/host/ohci-at91.c
>>>>> b/drivers/usb/host/ohci-at91.c
>>>>> index 9b955c1bd6..9ae55c6e5d 100644
>>>>> --- a/drivers/usb/host/ohci-at91.c
>>>>> +++ b/drivers/usb/host/ohci-at91.c
>>>>> @@ -5,6 +5,9 @@
>>>>>      */
>>>>>
>>>>>     #include <common.h>
>>>>> +
>>>>> +#if !(CONFIG_IS_ENABLED(DM_USB))
>>>>> +
>>>>>     #include <asm/arch/clk.h>
>>>>>
>>>>>     int usb_cpu_init(void)
>>>>> @@ -62,3 +65,183 @@ int usb_cpu_init_fail(void)
>>>>>     {
>>>>>         return usb_cpu_stop();
>>>>>     }
>>>>
>>>> Would it be possible to just remove the non-DM functionality ?
>>>>
>>>
>>> Unfortunately, the other older boards would not build and work anymore
>>> if I were to remove this.
>>
>> Any chance they can be converted to DM ?
>>
> 
> Not at the moment, no.

Why ?

  reply	other threads:[~2023-01-03 15:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 12:34 [PATCH 0/4] Register at91 OHCI into DM and add SAMA7 USB PHY's Sergiu Moga
2022-12-23 12:34 ` [PATCH 1/4] phy: at91: Add support for the USB 2.0 PHY's of SAMA7 Sergiu Moga
2022-12-23 12:34 ` [PATCH 2/4] usb: ohci-at91: Enable OHCI functionality and register into DM Sergiu Moga
2023-01-02 23:26   ` Marek Vasut
2023-01-03 12:11     ` Sergiu.Moga
2023-01-03 14:34       ` Marek Vasut
2023-01-03 15:49         ` Sergiu.Moga
2023-01-03 15:57           ` Marek Vasut [this message]
2023-01-03 16:01             ` Sergiu.Moga
2023-01-03 16:04               ` Marek Vasut
2022-12-23 12:34 ` [PATCH 3/4] usb: ohci-at91: Add `ohci_t` field in `ohci_at91_priv` Sergiu Moga
2023-01-02 23:27   ` Marek Vasut
2022-12-23 12:34 ` [PATCH 4/4] usb: ohci-at91: Add USB PHY functionality Sergiu Moga
2023-01-02 23:33   ` Marek Vasut
2023-01-03 13:02     ` Sergiu.Moga
2023-01-03 14:38       ` Marek Vasut
2022-12-23 12:44 ` [PATCH 0/4] Register at91 OHCI into DM and add SAMA7 USB PHY's Sergiu.Moga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36beada3-02ff-f33f-dc4e-517ccbc8cdf3@denx.de \
    --to=marex@denx.de \
    --cc=Cristian.Birsan@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Sergiu.Moga@microchip.com \
    --cc=jim.t90615@gmail.com \
    --cc=michal.simek@amd.com \
    --cc=sjg@chromium.org \
    --cc=sumit.garg@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.