Re: [PATCH 2/4] usb: ohci-at91: Enable OHCI functionality and register into DM

[<Sergiu.Moga@microchip.com>]

On 03.01.2023 17:57, Marek Vasut wrote:
> On 1/3/23 16:49, Sergiu.Moga@microchip.com wrote:
>> On 03.01.2023 16:34, Marek Vasut wrote:
>>> On 1/3/23 13:11, Sergiu.Moga@microchip.com wrote:
>>>> On 03.01.2023 01:26, Marek Vasut wrote:
>>>>> On 12/23/22 13:34, Sergiu Moga wrote:
>>>>>
>>>>> [...]
>>>>>
>>>>>> diff --git a/drivers/usb/host/ohci-at91.c
>>>>>> b/drivers/usb/host/ohci-at91.c
>>>>>> index 9b955c1bd6..9ae55c6e5d 100644
>>>>>> --- a/drivers/usb/host/ohci-at91.c
>>>>>> +++ b/drivers/usb/host/ohci-at91.c
>>>>>> @@ -5,6 +5,9 @@
>>>>>>      */
>>>>>>
>>>>>>     #include <common.h>
>>>>>> +
>>>>>> +#if !(CONFIG_IS_ENABLED(DM_USB))
>>>>>> +
>>>>>>     #include <asm/arch/clk.h>
>>>>>>
>>>>>>     int usb_cpu_init(void)
>>>>>> @@ -62,3 +65,183 @@ int usb_cpu_init_fail(void)
>>>>>>     {
>>>>>>         return usb_cpu_stop();
>>>>>>     }
>>>>>
>>>>> Would it be possible to just remove the non-DM functionality ?
>>>>>
>>>>
>>>> Unfortunately, the other older boards would not build and work anymore
>>>> if I were to remove this.
>>>
>>> Any chance they can be converted to DM ?
>>>
>>
>> Not at the moment, no.
> 
> Why ?

My apologies, but I do not have these boards at my disposal to test them 
and they are not the focus of this patch series. The reason I kept the 
non-DM part is that so the build on the other boards does not break. 
Perhaps in the future there will be plans to convert these as well but 
at the moment I can not say for sure.