All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2
Date: Wed, 28 Dec 2022 10:03:12 +0000	[thread overview]
Message-ID: <20221228100321.15949-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20221228100321.15949-1-linux.amoon@gmail.com>

On Odroid c2 previously use gpio-hog to reset the usb hub,
switch to used on-board usb hub reset to enable the usb hub
and enable power to hub.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 .../boot/dts/amlogic/meson-gxbb-odroidc2.dts  | 29 +++++++++----------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..3d3e61cf65a8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -208,6 +208,20 @@ codec-0 {
 			};
 		};
 	};
+
+	usb {
+		dr_mode = "host";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hub@1 {
+			/* Genesys Logic GL852G-OHG usb hub */
+			compatible = "genesys,usb5e3,610";
+			reg = <1>;
+			vdd-supply = <&usb_otg_pwr>;
+			reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
+		};
+	};
 };
 
 &aiu {
@@ -250,21 +264,6 @@ eth_phy0: ethernet-phy@0 {
 	};
 };
 
-&gpio_ao {
-	/*
-	 * WARNING: The USB Hub on the Odroid-C2 needs a reset signal
-	 * to be turned high in order to be detected by the USB Controller
-	 * This signal should be handled by a USB specific power sequence
-	 * in order to reset the Hub when USB bus is powered down.
-	 */
-	hog-0 {
-		gpio-hog;
-		gpios = <GPIOAO_4 GPIO_ACTIVE_HIGH>;
-		output-high;
-		line-name = "usb-hub-reset";
-	};
-};
-
 &hdmi_tx {
 	status = "okay";
 	pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
-- 
2.38.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2
Date: Wed, 28 Dec 2022 10:03:12 +0000	[thread overview]
Message-ID: <20221228100321.15949-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20221228100321.15949-1-linux.amoon@gmail.com>

On Odroid c2 previously use gpio-hog to reset the usb hub,
switch to used on-board usb hub reset to enable the usb hub
and enable power to hub.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 .../boot/dts/amlogic/meson-gxbb-odroidc2.dts  | 29 +++++++++----------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..3d3e61cf65a8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -208,6 +208,20 @@ codec-0 {
 			};
 		};
 	};
+
+	usb {
+		dr_mode = "host";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hub@1 {
+			/* Genesys Logic GL852G-OHG usb hub */
+			compatible = "genesys,usb5e3,610";
+			reg = <1>;
+			vdd-supply = <&usb_otg_pwr>;
+			reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
+		};
+	};
 };
 
 &aiu {
@@ -250,21 +264,6 @@ eth_phy0: ethernet-phy@0 {
 	};
 };
 
-&gpio_ao {
-	/*
-	 * WARNING: The USB Hub on the Odroid-C2 needs a reset signal
-	 * to be turned high in order to be detected by the USB Controller
-	 * This signal should be handled by a USB specific power sequence
-	 * in order to reset the Hub when USB bus is powered down.
-	 */
-	hog-0 {
-		gpio-hog;
-		gpios = <GPIOAO_4 GPIO_ACTIVE_HIGH>;
-		output-high;
-		line-name = "usb-hub-reset";
-	};
-};
-
 &hdmi_tx {
 	status = "okay";
 	pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
-- 
2.38.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2
Date: Wed, 28 Dec 2022 10:03:12 +0000	[thread overview]
Message-ID: <20221228100321.15949-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20221228100321.15949-1-linux.amoon@gmail.com>

On Odroid c2 previously use gpio-hog to reset the usb hub,
switch to used on-board usb hub reset to enable the usb hub
and enable power to hub.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 .../boot/dts/amlogic/meson-gxbb-odroidc2.dts  | 29 +++++++++----------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 201596247fd9..3d3e61cf65a8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -208,6 +208,20 @@ codec-0 {
 			};
 		};
 	};
+
+	usb {
+		dr_mode = "host";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		hub@1 {
+			/* Genesys Logic GL852G-OHG usb hub */
+			compatible = "genesys,usb5e3,610";
+			reg = <1>;
+			vdd-supply = <&usb_otg_pwr>;
+			reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
+		};
+	};
 };
 
 &aiu {
@@ -250,21 +264,6 @@ eth_phy0: ethernet-phy@0 {
 	};
 };
 
-&gpio_ao {
-	/*
-	 * WARNING: The USB Hub on the Odroid-C2 needs a reset signal
-	 * to be turned high in order to be detected by the USB Controller
-	 * This signal should be handled by a USB specific power sequence
-	 * in order to reset the Hub when USB bus is powered down.
-	 */
-	hog-0 {
-		gpio-hog;
-		gpios = <GPIOAO_4 GPIO_ACTIVE_HIGH>;
-		output-high;
-		line-name = "usb-hub-reset";
-	};
-};
-
 &hdmi_tx {
 	status = "okay";
 	pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
-- 
2.38.1


  parent reply	other threads:[~2022-12-28 10:05 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 10:03 [PATCH v1 00/11] Used onboard HUB to reset and add power to hub Anand Moon
2022-12-28 10:03 ` [PATCH v1 01/11] dt-bindings: usb: Add device id for Genesys Logic hub controller Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:08   ` Icenowy Zheng
2022-12-28 10:08     ` Icenowy Zheng
2022-12-28 10:29     ` Anand Moon
2022-12-28 10:29       ` Anand Moon
2023-01-04 22:54       ` Matthias Kaehlcke
2023-01-04 22:54         ` Matthias Kaehlcke
2023-01-07 15:01         ` Anand Moon
2023-01-07 15:01           ` Anand Moon
2023-01-09 16:29           ` Matthias Kaehlcke
2023-01-09 16:29             ` Matthias Kaehlcke
2023-01-09 17:48             ` Anand Moon
2023-01-09 17:48               ` Anand Moon
2022-12-28 15:08   ` Krzysztof Kozlowski
2022-12-28 15:08     ` Krzysztof Kozlowski
2022-12-28 15:18     ` Anand Moon
2022-12-28 15:18       ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 02/11] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 15:08   ` Krzysztof Kozlowski
2022-12-28 15:08     ` Krzysztof Kozlowski
2022-12-28 15:08     ` Krzysztof Kozlowski
2023-01-07 14:59     ` Anand Moon
2023-01-07 14:59       ` Anand Moon
2023-01-07 14:59       ` Anand Moon
2022-12-28 10:03 ` Anand Moon [this message]
2022-12-28 10:03   ` [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 12:51   ` Martin Blumenstingl
2022-12-28 12:51     ` Martin Blumenstingl
2022-12-28 12:51     ` Martin Blumenstingl
2022-12-28 14:44     ` Anand Moon
2022-12-28 14:44       ` Anand Moon
2022-12-28 14:44       ` Anand Moon
2023-01-04  8:13       ` Anand Moon
2023-01-04  8:13         ` Anand Moon
2023-01-04  8:13         ` Anand Moon
2023-01-04  8:56         ` Neil Armstrong
2023-01-04  8:56           ` Neil Armstrong
2023-01-04  8:56           ` Neil Armstrong
2023-01-04  9:17           ` Anand Moon
2023-01-04  9:17             ` Anand Moon
2023-01-04  9:17             ` Anand Moon
2023-01-04  9:36         ` Alexander Stein
2023-01-04  9:36           ` Alexander Stein
2023-01-04  9:36           ` Alexander Stein
2023-01-07 14:56           ` Anand Moon
2023-01-07 14:56             ` Anand Moon
2023-01-07 14:56             ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 04/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid n2 Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 05/11] usb: misc: onboard_usb_hub: add Genesys Logic GL852G-OHG hub support Anand Moon
2022-12-28 10:03   ` Anand Moon
2023-01-04 20:28   ` Matthias Kaehlcke
2023-01-04 20:28     ` Matthias Kaehlcke
2023-01-04 20:53     ` Matthias Kaehlcke
2023-01-04 20:53       ` Matthias Kaehlcke
2023-01-07 14:56       ` Anand Moon
2023-01-07 14:56         ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 06/11] usb: misc: onboard_usb_hub: add Genesys Logic GL3523-QFN76 " Anand Moon
2022-12-28 10:03   ` Anand Moon
2023-01-04 20:43   ` Matthias Kaehlcke
2023-01-04 20:43     ` Matthias Kaehlcke
2023-01-07 14:58     ` Anand Moon
2023-01-07 14:58       ` Anand Moon
2023-01-09 16:22       ` Matthias Kaehlcke
2023-01-09 16:22         ` Matthias Kaehlcke
2022-12-28 10:03 ` [PATCH v1 07/11] vendor-prefixes: Add VIA Labs, Inc Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 15:11   ` Krzysztof Kozlowski
2022-12-28 15:11     ` Krzysztof Kozlowski
2022-12-28 10:03 ` [PATCH v1 08/11] dt-bindings: usb: Add binding for Via lab VL817Q7 hub controller Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 11:02   ` Johan Hovold
2022-12-28 11:02     ` Johan Hovold
2022-12-28 11:09     ` Anand Moon
2022-12-28 11:09       ` Anand Moon
2022-12-28 17:16   ` Rob Herring
2022-12-28 17:16     ` Rob Herring
2023-01-04 22:37   ` Matthias Kaehlcke
2023-01-04 22:37     ` Matthias Kaehlcke
2023-01-07 15:00     ` Anand Moon
2023-01-07 15:00       ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 09/11] arm64: dts: meson-sm1-odroid-c4: Used onboard usb hub reset on odroid c4 Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 10/11] usb: misc: onboard_usb_hub: add VIA LAB VL817Q7 hub support Anand Moon
2022-12-28 10:03   ` Anand Moon
2023-01-04 20:22   ` Matthias Kaehlcke
2023-01-04 20:22     ` Matthias Kaehlcke
2023-01-07 14:59     ` Anand Moon
2023-01-07 14:59       ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 11/11] arm64: defconfig: Enable USB onboard HUB driver Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221228100321.15949-4-linux.amoon@gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.