All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 05/11] usb: misc: onboard_usb_hub: add Genesys Logic GL852G-OHG hub support
Date: Wed, 4 Jan 2023 20:28:18 +0000	[thread overview]
Message-ID: <Y7XhYm0nvBsSS8MN@google.com> (raw)
In-Reply-To: <20221228100321.15949-6-linux.amoon@gmail.com>

On Wed, Dec 28, 2022 at 10:03:14AM +0000, Anand Moon wrote:
> Genesys Logic GL852G-OHG is a 4-port USB 2.0 STT hub that has a reset pin to
> toggle and a 5.0V core supply exported though an integrated LDO is
> available for powering it.
> 
> Add the support for this hub, for controlling the reset pin and the core
> power supply.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  drivers/usb/misc/onboard_usb_hub.c | 1 +
>  drivers/usb/misc/onboard_usb_hub.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c
> index 94e7966e199d..c0e8e6f4ec0a 100644
> --- a/drivers/usb/misc/onboard_usb_hub.c
> +++ b/drivers/usb/misc/onboard_usb_hub.c
> @@ -409,6 +409,7 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev)
>  
>  static const struct usb_device_id onboard_hub_id_table[] = {
>  	{ USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */
> +	{ USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G-OHG USB 2.0 */
>  	{ USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */
>  	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 */
>  	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */
> diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h
> index 62129a6a1ba5..2ee1b0032d23 100644
> --- a/drivers/usb/misc/onboard_usb_hub.h
> +++ b/drivers/usb/misc/onboard_usb_hub.h
> @@ -31,6 +31,7 @@ static const struct of_device_id onboard_hub_match[] = {
>  	{ .compatible = "usb451,8140", .data = &ti_tusb8041_data, },
>  	{ .compatible = "usb451,8142", .data = &ti_tusb8041_data, },
>  	{ .compatible = "usb5e3,608", .data = &genesys_gl850g_data, },
> +	{ .compatible = "genesys,usb5e3,610", .data = &genesys_gl850g_data, },

s/genesys,//

>  	{ .compatible = "usbbda,411", .data = &realtek_rts5411_data, },
>  	{ .compatible = "usbbda,5411", .data = &realtek_rts5411_data, },
>  	{ .compatible = "usbbda,414", .data = &realtek_rts5411_data, },
> -- 
> 2.38.1
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 05/11] usb: misc: onboard_usb_hub: add Genesys Logic GL852G-OHG hub support
Date: Wed, 4 Jan 2023 20:28:18 +0000	[thread overview]
Message-ID: <Y7XhYm0nvBsSS8MN@google.com> (raw)
In-Reply-To: <20221228100321.15949-6-linux.amoon@gmail.com>

On Wed, Dec 28, 2022 at 10:03:14AM +0000, Anand Moon wrote:
> Genesys Logic GL852G-OHG is a 4-port USB 2.0 STT hub that has a reset pin to
> toggle and a 5.0V core supply exported though an integrated LDO is
> available for powering it.
> 
> Add the support for this hub, for controlling the reset pin and the core
> power supply.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  drivers/usb/misc/onboard_usb_hub.c | 1 +
>  drivers/usb/misc/onboard_usb_hub.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c
> index 94e7966e199d..c0e8e6f4ec0a 100644
> --- a/drivers/usb/misc/onboard_usb_hub.c
> +++ b/drivers/usb/misc/onboard_usb_hub.c
> @@ -409,6 +409,7 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev)
>  
>  static const struct usb_device_id onboard_hub_id_table[] = {
>  	{ USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */
> +	{ USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G-OHG USB 2.0 */
>  	{ USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */
>  	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 */
>  	{ USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */
> diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h
> index 62129a6a1ba5..2ee1b0032d23 100644
> --- a/drivers/usb/misc/onboard_usb_hub.h
> +++ b/drivers/usb/misc/onboard_usb_hub.h
> @@ -31,6 +31,7 @@ static const struct of_device_id onboard_hub_match[] = {
>  	{ .compatible = "usb451,8140", .data = &ti_tusb8041_data, },
>  	{ .compatible = "usb451,8142", .data = &ti_tusb8041_data, },
>  	{ .compatible = "usb5e3,608", .data = &genesys_gl850g_data, },
> +	{ .compatible = "genesys,usb5e3,610", .data = &genesys_gl850g_data, },

s/genesys,//

>  	{ .compatible = "usbbda,411", .data = &realtek_rts5411_data, },
>  	{ .compatible = "usbbda,5411", .data = &realtek_rts5411_data, },
>  	{ .compatible = "usbbda,414", .data = &realtek_rts5411_data, },
> -- 
> 2.38.1
> 

  reply	other threads:[~2023-01-04 20:28 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 10:03 [PATCH v1 00/11] Used onboard HUB to reset and add power to hub Anand Moon
2022-12-28 10:03 ` [PATCH v1 01/11] dt-bindings: usb: Add device id for Genesys Logic hub controller Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:08   ` Icenowy Zheng
2022-12-28 10:08     ` Icenowy Zheng
2022-12-28 10:29     ` Anand Moon
2022-12-28 10:29       ` Anand Moon
2023-01-04 22:54       ` Matthias Kaehlcke
2023-01-04 22:54         ` Matthias Kaehlcke
2023-01-07 15:01         ` Anand Moon
2023-01-07 15:01           ` Anand Moon
2023-01-09 16:29           ` Matthias Kaehlcke
2023-01-09 16:29             ` Matthias Kaehlcke
2023-01-09 17:48             ` Anand Moon
2023-01-09 17:48               ` Anand Moon
2022-12-28 15:08   ` Krzysztof Kozlowski
2022-12-28 15:08     ` Krzysztof Kozlowski
2022-12-28 15:18     ` Anand Moon
2022-12-28 15:18       ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 02/11] ARM: dts: amlogic: Used onboard usb hub reset to enable usb hub Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 15:08   ` Krzysztof Kozlowski
2022-12-28 15:08     ` Krzysztof Kozlowski
2022-12-28 15:08     ` Krzysztof Kozlowski
2023-01-07 14:59     ` Anand Moon
2023-01-07 14:59       ` Anand Moon
2023-01-07 14:59       ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 12:51   ` Martin Blumenstingl
2022-12-28 12:51     ` Martin Blumenstingl
2022-12-28 12:51     ` Martin Blumenstingl
2022-12-28 14:44     ` Anand Moon
2022-12-28 14:44       ` Anand Moon
2022-12-28 14:44       ` Anand Moon
2023-01-04  8:13       ` Anand Moon
2023-01-04  8:13         ` Anand Moon
2023-01-04  8:13         ` Anand Moon
2023-01-04  8:56         ` Neil Armstrong
2023-01-04  8:56           ` Neil Armstrong
2023-01-04  8:56           ` Neil Armstrong
2023-01-04  9:17           ` Anand Moon
2023-01-04  9:17             ` Anand Moon
2023-01-04  9:17             ` Anand Moon
2023-01-04  9:36         ` Alexander Stein
2023-01-04  9:36           ` Alexander Stein
2023-01-04  9:36           ` Alexander Stein
2023-01-07 14:56           ` Anand Moon
2023-01-07 14:56             ` Anand Moon
2023-01-07 14:56             ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 04/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid n2 Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 05/11] usb: misc: onboard_usb_hub: add Genesys Logic GL852G-OHG hub support Anand Moon
2022-12-28 10:03   ` Anand Moon
2023-01-04 20:28   ` Matthias Kaehlcke [this message]
2023-01-04 20:28     ` Matthias Kaehlcke
2023-01-04 20:53     ` Matthias Kaehlcke
2023-01-04 20:53       ` Matthias Kaehlcke
2023-01-07 14:56       ` Anand Moon
2023-01-07 14:56         ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 06/11] usb: misc: onboard_usb_hub: add Genesys Logic GL3523-QFN76 " Anand Moon
2022-12-28 10:03   ` Anand Moon
2023-01-04 20:43   ` Matthias Kaehlcke
2023-01-04 20:43     ` Matthias Kaehlcke
2023-01-07 14:58     ` Anand Moon
2023-01-07 14:58       ` Anand Moon
2023-01-09 16:22       ` Matthias Kaehlcke
2023-01-09 16:22         ` Matthias Kaehlcke
2022-12-28 10:03 ` [PATCH v1 07/11] vendor-prefixes: Add VIA Labs, Inc Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 15:11   ` Krzysztof Kozlowski
2022-12-28 15:11     ` Krzysztof Kozlowski
2022-12-28 10:03 ` [PATCH v1 08/11] dt-bindings: usb: Add binding for Via lab VL817Q7 hub controller Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 11:02   ` Johan Hovold
2022-12-28 11:02     ` Johan Hovold
2022-12-28 11:09     ` Anand Moon
2022-12-28 11:09       ` Anand Moon
2022-12-28 17:16   ` Rob Herring
2022-12-28 17:16     ` Rob Herring
2023-01-04 22:37   ` Matthias Kaehlcke
2023-01-04 22:37     ` Matthias Kaehlcke
2023-01-07 15:00     ` Anand Moon
2023-01-07 15:00       ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 09/11] arm64: dts: meson-sm1-odroid-c4: Used onboard usb hub reset on odroid c4 Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 10/11] usb: misc: onboard_usb_hub: add VIA LAB VL817Q7 hub support Anand Moon
2022-12-28 10:03   ` Anand Moon
2023-01-04 20:22   ` Matthias Kaehlcke
2023-01-04 20:22     ` Matthias Kaehlcke
2023-01-07 14:59     ` Anand Moon
2023-01-07 14:59       ` Anand Moon
2022-12-28 10:03 ` [PATCH v1 11/11] arm64: defconfig: Enable USB onboard HUB driver Anand Moon
2022-12-28 10:03   ` Anand Moon
2022-12-28 10:03   ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7XhYm0nvBsSS8MN@google.com \
    --to=mka@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.