From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <vkoul@kernel.org>, <yung-chuan.liao@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>, <sanyog.r.kale@intel.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
Richard Fitzgerald <rf@opensource.cirrus.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers
Date: Mon, 23 Jan 2023 16:49:47 +0000 [thread overview]
Message-ID: <20230123164949.245898-1-rf@opensource.cirrus.com> (raw)
Writing zero to the page registers after each message transaction can add
up to a lot of overhead for codecs that need to transfer large amount of
data - for example a firmware download.
There's no spec reason I can see for this zeroing. The page registers are
only used for a paged address. The bus code uses a non-paged address for
registers in page 0. It always writes the page registers at the start of
a paged transaction.
If this zeroing was a workaround for anything, let me know and I will
re-implement the zeroing as a quirk that can be enabled only when it is
necessary.
Changes since v1:
- Reworded the commit message to patch #1:
- say that this is for devices that support paging
- mention bit 15 as the paging flag
- split a long sentence into two sentences.
No code changes.
Richard Fitzgerald (2):
soundwire: bus: Don't zero page registers after every transaction
soundwire: bus: Remove unused reset_page_addr() callback
drivers/soundwire/bus.c | 23 -----------------------
drivers/soundwire/cadence_master.c | 14 --------------
drivers/soundwire/cadence_master.h | 3 ---
drivers/soundwire/intel_auxdevice.c | 1 -
include/linux/soundwire/sdw.h | 3 ---
5 files changed, 44 deletions(-)
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <vkoul@kernel.org>, <yung-chuan.liao@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>, <sanyog.r.kale@intel.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers
Date: Mon, 23 Jan 2023 16:49:47 +0000 [thread overview]
Message-ID: <20230123164949.245898-1-rf@opensource.cirrus.com> (raw)
Writing zero to the page registers after each message transaction can add
up to a lot of overhead for codecs that need to transfer large amount of
data - for example a firmware download.
There's no spec reason I can see for this zeroing. The page registers are
only used for a paged address. The bus code uses a non-paged address for
registers in page 0. It always writes the page registers at the start of
a paged transaction.
If this zeroing was a workaround for anything, let me know and I will
re-implement the zeroing as a quirk that can be enabled only when it is
necessary.
Changes since v1:
- Reworded the commit message to patch #1:
- say that this is for devices that support paging
- mention bit 15 as the paging flag
- split a long sentence into two sentences.
No code changes.
Richard Fitzgerald (2):
soundwire: bus: Don't zero page registers after every transaction
soundwire: bus: Remove unused reset_page_addr() callback
drivers/soundwire/bus.c | 23 -----------------------
drivers/soundwire/cadence_master.c | 14 --------------
drivers/soundwire/cadence_master.h | 3 ---
drivers/soundwire/intel_auxdevice.c | 1 -
include/linux/soundwire/sdw.h | 3 ---
5 files changed, 44 deletions(-)
--
2.30.2
next reply other threads:[~2023-01-23 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 16:49 Richard Fitzgerald [this message]
2023-01-23 16:49 ` [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers Richard Fitzgerald
2023-01-23 16:49 ` [PATCH v2 1/2] soundwire: bus: Don't zero page registers after every transaction Richard Fitzgerald
2023-01-23 16:49 ` Richard Fitzgerald
2023-01-23 16:49 ` [PATCH v2 2/2] soundwire: bus: Remove unused reset_page_addr() callback Richard Fitzgerald
2023-01-23 16:49 ` Richard Fitzgerald
2023-01-31 12:06 ` [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers Vinod Koul
2023-01-31 12:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123164949.245898-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.