From: Vinod Koul <vkoul@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
pierre-louis.bossart@linux.intel.com,
linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
yung-chuan.liao@linux.intel.com
Subject: Re: [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers
Date: Tue, 31 Jan 2023 17:36:23 +0530 [thread overview]
Message-ID: <Y9kEP+ozg8eyYLbS@matsya> (raw)
In-Reply-To: <20230123164949.245898-1-rf@opensource.cirrus.com>
On 23-01-23, 16:49, Richard Fitzgerald wrote:
> Writing zero to the page registers after each message transaction can add
> up to a lot of overhead for codecs that need to transfer large amount of
> data - for example a firmware download.
>
> There's no spec reason I can see for this zeroing. The page registers are
> only used for a paged address. The bus code uses a non-paged address for
> registers in page 0. It always writes the page registers at the start of
> a paged transaction.
>
> If this zeroing was a workaround for anything, let me know and I will
> re-implement the zeroing as a quirk that can be enabled only when it is
> necessary.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers
Date: Tue, 31 Jan 2023 17:36:23 +0530 [thread overview]
Message-ID: <Y9kEP+ozg8eyYLbS@matsya> (raw)
In-Reply-To: <20230123164949.245898-1-rf@opensource.cirrus.com>
On 23-01-23, 16:49, Richard Fitzgerald wrote:
> Writing zero to the page registers after each message transaction can add
> up to a lot of overhead for codecs that need to transfer large amount of
> data - for example a firmware download.
>
> There's no spec reason I can see for this zeroing. The page registers are
> only used for a paged address. The bus code uses a non-paged address for
> registers in page 0. It always writes the page registers at the start of
> a paged transaction.
>
> If this zeroing was a workaround for anything, let me know and I will
> re-implement the zeroing as a quirk that can be enabled only when it is
> necessary.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2023-01-31 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 16:49 [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers Richard Fitzgerald
2023-01-23 16:49 ` Richard Fitzgerald
2023-01-23 16:49 ` [PATCH v2 1/2] soundwire: bus: Don't zero page registers after every transaction Richard Fitzgerald
2023-01-23 16:49 ` Richard Fitzgerald
2023-01-23 16:49 ` [PATCH v2 2/2] soundwire: bus: Remove unused reset_page_addr() callback Richard Fitzgerald
2023-01-23 16:49 ` Richard Fitzgerald
2023-01-31 12:06 ` Vinod Koul [this message]
2023-01-31 12:06 ` [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9kEP+ozg8eyYLbS@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=sanyog.r.kale@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.