From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Ani Sinha <ani@anisinha.ca>
Subject: Re: [PATCH 00/40] x86: fixing and cleaning up ACPI PCI code part 3
Date: Wed, 25 Jan 2023 18:02:09 +0100 [thread overview]
Message-ID: <20230125180209.597c0983@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20230112140312.3096331-1-imammedo@redhat.com>
On Thu, 12 Jan 2023 15:02:32 +0100
Igor Mammedov <imammedo@redhat.com> wrote:
ping,
Michael can you take a look at this series and queue it
if it looks acceptable to you.
PS:
I'm waiting on this being merged, to send acpi-index
support on non-hotpluggable ports (due to heavy dependency
on this refactoring). After which I plan to post
series that allows resources reallocation on bridges.
(both should be doable in 8.0 timeframe)
(the rest: acpi-index for pxb and other targets/machines,
pci-hostbridge cleanups will be after that but probably
won't make into 8.0)
> Series continues refactoring on top of [1].
>
> It focuses on isolating creation of non hotplug and
> hotplug slot descriptions. In state it's posted, it's
> not complete, but pretty close to it. The series contains
> stable patches from refactoring and is already too large
> to keep it to myself, hence I'm publishing it fro review.
>
> It will be followed by separate series on top of this one,
> that will finish concrete feature[s] in following order:
> 1 introduce acpi-index support for non-hotpluggable PCI
> devices (i.e. NICs directly attached to Q35 host-bridge)
> making acpi-index support complete within pc/q35 machines.
> 2 let guest OS to re-arrange bridge resources when ACPI PCI
> hotplug is enabled. (should fix insuficient resources issue
> during PCI hotplug)
> 3 finish isolating hotplug code from non-hotplug one,
> which should allow to re-use non-hotplug parts in other
> machines (arm/virt and microvm) and bring acpi-index
> support there.
>
> PS:
> Refactoring also adds testing for various corner cases
> and fixes (present/latent/imagined) bugs where they were
> spotted.
>
> 1) "[PATCH 00/11] x86: clean up ACPI PCI code part 2"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg915493.html
>
> CC: "Michael S. Tsirkin" <mst@redhat.com>
> CC: Ani Sinha <ani@anisinha.ca>
>
> Igor Mammedov (40):
> tests: qtest: print device_add error before failing test
> tests: acpi: cleanup arguments to make them more readable
> tests: acpi: whitelist DSDT blobs for tests that use pci-bridges
> tests: acpi: extend pcihp with nested bridges
> tests: acpi: update expected blobs
> tests: acpi: cleanup use_uefi argument usage
> pci_bridge: remove whitespace
> x86: acpi: pcihp: clean up duplicate bridge_in_acpi assignment
> pci: acpi hotplug: rename x-native-hotplug to
> x-do-not-expose-native-hotplug-cap
> pcihp: piix4: do not call acpi_pcihp_reset() when ACPI PCI hotplug is
> disabled
> pci: acpihp: assign BSEL only to coldplugged bridges
> x86: pcihp: fix invalid AML PCNT calls to hotplugged bridges
> tests: boot_sector_test: avoid crashing if status is not available yet
> tests: acpi: extend bridge tests with hotplugged bridges
> tests: boot_sector_test(): make it multi-shot
> tests: acpi: add reboot cycle to bridge test
> tests: acpi: whitelist DSDT before refactoring acpi based PCI hotplug
> machinery
> pcihp: drop pcihp_bridge_en dependency when composing PCNT method
> tests: acpi: update expected blobs
> tests: acpi: whitelist DSDT before refactoring acpi based PCI hotplug
> machinery
> pcihp: compose PCNT callchain right before its user _GPE._E01
> pcihp: do not put empty PCNT in DSDT
> tests: acpi: update expected blobs
> whitelist DSDT before adding endpoint devices to bridge testcases
> tests: acpi: add endpoint devices to bridges
> tests: acpi: update expected blobs
> x86: pcihp: acpi: prepare slot ignore rule to work with self
> describing bridges
> pci: acpi: wire up AcpiDevAmlIf interface to generic bridge
> pcihp: make bridge describe itself using
> AcpiDevAmlIfClass:build_dev_aml
> pci: make sure pci_bus_is_express() won't error out with "discards
> ‘const’ qualifier"
> pcihp: isolate rule whether slot should be described in DSDT
> tests: acpi: whitelist DSDT before decoupling PCI hotplug code from
> basic slots description
> pcihp: acpi: decouple hotplug and generic slots description
> tests: acpi: update expected blobs
> tests: acpi: whitelist DSDT blobs before removing dynamic _DSM on
> coldplugged bridges
> pcihp: acpi: ignore coldplugged bridges when composing hotpluggable
> slots
> tests: acpi: update expected blobs
> tests: acpi: whitelist DSDT before moving non-hotpluggble slots
> description from hotplug path
> pcihp: generate populated non-hotpluggble slot descriptions on
> non-hotplug path
> tests: acpi: update expected blobs
>
> include/hw/acpi/pci.h | 4 +
> include/hw/pci/pci.h | 2 +-
> include/hw/pci/pcie_port.h | 3 +-
> hw/acpi/Kconfig | 4 +
> hw/acpi/meson.build | 4 +-
> hw/acpi/pci-bridge-stub.c | 20 ++
> hw/acpi/pci-bridge.c | 27 ++
> hw/acpi/pcihp.c | 35 ++-
> hw/acpi/piix4.c | 4 +-
> hw/i386/Kconfig | 1 +
> hw/i386/acpi-build.c | 279 ++++++++++--------
> hw/i386/pc_q35.c | 5 +-
> hw/pci-bridge/gen_pcie_root_port.c | 7 +-
> hw/pci-bridge/pci_bridge_dev.c | 1 -
> hw/pci/pci.c | 2 +-
> hw/pci/pci_bridge.c | 14 +
> hw/pci/pcie.c | 6 +-
> hw/pci/pcie_port.c | 3 +-
> tests/data/acpi/pc/DSDT | Bin 6458 -> 6360 bytes
> tests/data/acpi/pc/DSDT.acpierst | Bin 6418 -> 6283 bytes
> tests/data/acpi/pc/DSDT.acpihmat | Bin 7783 -> 7685 bytes
> tests/data/acpi/pc/DSDT.bridge | Bin 9532 -> 12487 bytes
> tests/data/acpi/pc/DSDT.cphp | Bin 6922 -> 6824 bytes
> tests/data/acpi/pc/DSDT.dimmpxm | Bin 8112 -> 8014 bytes
> tests/data/acpi/pc/DSDT.hpbridge | Bin 6418 -> 6289 bytes
> tests/data/acpi/pc/DSDT.hpbrroot | Bin 3064 -> 3081 bytes
> tests/data/acpi/pc/DSDT.ipmikcs | Bin 6530 -> 6432 bytes
> tests/data/acpi/pc/DSDT.memhp | Bin 7817 -> 7719 bytes
> tests/data/acpi/pc/DSDT.nohpet | Bin 6316 -> 6218 bytes
> tests/data/acpi/pc/DSDT.numamem | Bin 6464 -> 6366 bytes
> tests/data/acpi/pc/DSDT.roothp | Bin 6656 -> 9745 bytes
> tests/data/acpi/q35/DSDT | Bin 8310 -> 8252 bytes
> tests/data/acpi/q35/DSDT.acpierst | Bin 8327 -> 8269 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9635 -> 9577 bytes
> tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8589 -> 8531 bytes
> tests/data/acpi/q35/DSDT.applesmc | Bin 8356 -> 8298 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 11439 -> 11481 bytes
> tests/data/acpi/q35/DSDT.core-count2 | Bin 32450 -> 32392 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8774 -> 8716 bytes
> tests/data/acpi/q35/DSDT.cxl | Bin 9636 -> 9578 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9964 -> 9906 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 8385 -> 8327 bytes
> tests/data/acpi/q35/DSDT.ipmismbus | Bin 8398 -> 8340 bytes
> tests/data/acpi/q35/DSDT.ivrs | Bin 8327 -> 8269 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9669 -> 9611 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 9440 -> 9382 bytes
> tests/data/acpi/q35/DSDT.multi-bridge | Bin 8630 -> 12337 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 8168 -> 8110 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 8316 -> 8258 bytes
> tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8411 -> 8353 bytes
> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8916 -> 8858 bytes
> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8942 -> 8884 bytes
> tests/data/acpi/q35/DSDT.viot | Bin 9419 -> 9361 bytes
> tests/data/acpi/q35/DSDT.xapic | Bin 35673 -> 35615 bytes
> tests/qtest/bios-tables-test.c | 144 ++++++---
> tests/qtest/boot-sector.c | 6 +-
> tests/qtest/libqtest.c | 4 +
> 57 files changed, 394 insertions(+), 181 deletions(-)
> create mode 100644 hw/acpi/pci-bridge-stub.c
> create mode 100644 hw/acpi/pci-bridge.c
>
next prev parent reply other threads:[~2023-01-25 17:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 14:02 [PATCH 00/40] x86: fixing and cleaning up ACPI PCI code part 3 Igor Mammedov
2023-01-12 14:02 ` [PATCH 01/40] tests: qtest: print device_add error before failing test Igor Mammedov
2023-01-12 14:02 ` [PATCH 02/40] tests: acpi: cleanup arguments to make them more readable Igor Mammedov
2023-01-12 14:02 ` [PATCH 03/40] tests: acpi: whitelist DSDT blobs for tests that use pci-bridges Igor Mammedov
2023-01-12 14:02 ` [PATCH 04/40] tests: acpi: extend pcihp with nested bridges Igor Mammedov
2023-01-12 14:02 ` [PATCH 05/40] tests: acpi: update expected blobs Igor Mammedov
2023-01-12 14:02 ` [PATCH 06/40] tests: acpi: cleanup use_uefi argument usage Igor Mammedov
2023-01-12 14:02 ` [PATCH 07/40] pci_bridge: remove whitespace Igor Mammedov
2023-01-12 14:02 ` [PATCH 08/40] x86: acpi: pcihp: clean up duplicate bridge_in_acpi assignment Igor Mammedov
2023-01-12 14:02 ` [PATCH 09/40] pci: acpi hotplug: rename x-native-hotplug to x-do-not-expose-native-hotplug-cap Igor Mammedov
2023-01-12 14:02 ` [PATCH 10/40] pcihp: piix4: do not call acpi_pcihp_reset() when ACPI PCI hotplug is disabled Igor Mammedov
2023-01-12 14:02 ` [PATCH 11/40] pci: acpihp: assign BSEL only to coldplugged bridges Igor Mammedov
2023-01-12 14:02 ` [PATCH 12/40] x86: pcihp: fix invalid AML PCNT calls to hotplugged bridges Igor Mammedov
2023-01-12 14:02 ` [PATCH 13/40] tests: boot_sector_test: avoid crashing if status is not available yet Igor Mammedov
2023-01-12 14:02 ` [PATCH 14/40] tests: acpi: extend bridge tests with hotplugged bridges Igor Mammedov
2023-01-12 14:02 ` [PATCH 15/40] tests: boot_sector_test(): make it multi-shot Igor Mammedov
2023-01-12 14:02 ` [PATCH 16/40] tests: acpi: add reboot cycle to bridge test Igor Mammedov
2023-01-12 14:02 ` [PATCH 17/40] tests: acpi: whitelist DSDT before refactoring acpi based PCI hotplug machinery Igor Mammedov
2023-01-12 14:02 ` [PATCH 18/40] pcihp: drop pcihp_bridge_en dependency when composing PCNT method Igor Mammedov
2023-01-12 14:02 ` [PATCH 19/40] tests: acpi: update expected blobs Igor Mammedov
2023-01-12 14:02 ` [PATCH 20/40] tests: acpi: whitelist DSDT before refactoring acpi based PCI hotplug machinery Igor Mammedov
2023-01-12 14:02 ` [PATCH 21/40] pcihp: compose PCNT callchain right before its user _GPE._E01 Igor Mammedov
2023-01-12 14:02 ` [PATCH 22/40] pcihp: do not put empty PCNT in DSDT Igor Mammedov
2023-01-12 14:02 ` [PATCH 23/40] tests: acpi: update expected blobs Igor Mammedov
2023-01-12 14:02 ` [PATCH 24/40] whitelist DSDT before adding endpoint devices to bridge testcases Igor Mammedov
2023-01-12 14:02 ` [PATCH 25/40] tests: acpi: add endpoint devices to bridges Igor Mammedov
2023-01-12 14:02 ` [PATCH 26/40] tests: acpi: update expected blobs Igor Mammedov
2023-01-12 14:02 ` [PATCH 27/40] x86: pcihp: acpi: prepare slot ignore rule to work with self describing bridges Igor Mammedov
2023-01-12 14:03 ` [PATCH 28/40] pci: acpi: wire up AcpiDevAmlIf interface to generic bridge Igor Mammedov
2023-01-12 14:03 ` [PATCH 29/40] pcihp: make bridge describe itself using AcpiDevAmlIfClass:build_dev_aml Igor Mammedov
2023-01-12 14:03 ` [PATCH 30/40] pci: make sure pci_bus_is_express() won't error out with "discards ‘const’ qualifier" Igor Mammedov
2023-01-12 14:03 ` [PATCH 31/40] pcihp: isolate rule whether slot should be described in DSDT Igor Mammedov
2023-01-12 14:03 ` [PATCH 32/40] tests: acpi: whitelist DSDT before decoupling PCI hotplug code from basic slots description Igor Mammedov
2023-01-12 14:03 ` [PATCH 33/40] pcihp: acpi: decouple hotplug and generic " Igor Mammedov
2023-01-12 14:03 ` [PATCH 34/40] tests: acpi: update expected blobs Igor Mammedov
2023-01-12 14:03 ` [PATCH 35/40] tests: acpi: whitelist DSDT blobs before removing dynamic _DSM on coldplugged bridges Igor Mammedov
2023-01-12 14:03 ` [PATCH 36/40] pcihp: acpi: ignore coldplugged bridges when composing hotpluggable slots Igor Mammedov
2023-01-12 14:03 ` [PATCH 37/40] tests: acpi: update expected blobs Igor Mammedov
2023-01-12 14:03 ` [PATCH 38/40] tests: acpi: whitelist DSDT before moving non-hotpluggble slots description from hotplug path Igor Mammedov
2023-01-12 14:03 ` [PATCH 39/40] pcihp: generate populated non-hotpluggble slot descriptions on non-hotplug path Igor Mammedov
2023-01-12 14:03 ` [PATCH 40/40] tests: acpi: update expected blobs Igor Mammedov
2023-01-25 17:02 ` Igor Mammedov [this message]
2023-01-25 17:34 ` [PATCH 00/40] x86: fixing and cleaning up ACPI PCI code part 3 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125180209.597c0983@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.