From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
bridge@lists.linux-foundation.org,
Eric Dumazet <edumazet@google.com>,
Roopa Prabhu <roopa@nvidia.com>, Paolo Abeni <pabeni@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next] netlink: provide an ability to set default extack message
Date: Thu, 26 Jan 2023 15:39:21 -0800 [thread overview]
Message-ID: <20230126153921.3823054c@kernel.org> (raw)
In-Reply-To: <20230126224457.lc2ly5k77gkhycwa@skbuf>
On Fri, 27 Jan 2023 00:44:57 +0200 Vladimir Oltean wrote:
> On Thu, Jan 26, 2023 at 02:37:23PM -0800, Jakub Kicinski wrote:
> > > I would somewhat prefer not doing this, and instead introducing a new
> > > NL_SET_ERR_MSG_WEAK() of sorts.
> >
> > That'd be my preference too, FWIW. It's only the offload cases which
> > need this sort of fallback.
> >
> > BTW Vladimir, I remember us discussing this. I was searching the
> > archive as you sent this, but can't find the thread. Mostly curious
> > whether I flip flipped on this or I'm not completely useless :)
>
> What we discussed was on a patch of mine fixing "if (!extack->_msg)" to
> "if (extack && !extack->_msg)". I never proposed a new macro wrapper
> (you did), but I didn't do it at the time because it was a patch for
> "net", and I forgot to put a reminder for the next net->net-next merge.
> https://lore.kernel.org/netdev/20220822182523.6821e176@kernel.org/
> And from there, out of sight, out of mind.
That explains it, I was running blame the message lines, not the if ().
Thanks for digging it up!
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Leon Romanovsky <leonro@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
bridge@lists.linux-foundation.org,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
Paolo Abeni <pabeni@redhat.com>, Roopa Prabhu <roopa@nvidia.com>
Subject: Re: [PATCH net-next] netlink: provide an ability to set default extack message
Date: Thu, 26 Jan 2023 15:39:21 -0800 [thread overview]
Message-ID: <20230126153921.3823054c@kernel.org> (raw)
In-Reply-To: <20230126224457.lc2ly5k77gkhycwa@skbuf>
On Fri, 27 Jan 2023 00:44:57 +0200 Vladimir Oltean wrote:
> On Thu, Jan 26, 2023 at 02:37:23PM -0800, Jakub Kicinski wrote:
> > > I would somewhat prefer not doing this, and instead introducing a new
> > > NL_SET_ERR_MSG_WEAK() of sorts.
> >
> > That'd be my preference too, FWIW. It's only the offload cases which
> > need this sort of fallback.
> >
> > BTW Vladimir, I remember us discussing this. I was searching the
> > archive as you sent this, but can't find the thread. Mostly curious
> > whether I flip flipped on this or I'm not completely useless :)
>
> What we discussed was on a patch of mine fixing "if (!extack->_msg)" to
> "if (extack && !extack->_msg)". I never proposed a new macro wrapper
> (you did), but I didn't do it at the time because it was a patch for
> "net", and I forgot to put a reminder for the next net->net-next merge.
> https://lore.kernel.org/netdev/20220822182523.6821e176@kernel.org/
> And from there, out of sight, out of mind.
That explains it, I was running blame the message lines, not the if ().
Thanks for digging it up!
next prev parent reply other threads:[~2023-01-26 23:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 19:15 [Bridge] [PATCH net-next] netlink: provide an ability to set default extack message Leon Romanovsky
2023-01-26 19:15 ` Leon Romanovsky
2023-01-26 22:32 ` [Bridge] " Vladimir Oltean
2023-01-26 22:32 ` Vladimir Oltean
2023-01-26 22:37 ` [Bridge] " Jakub Kicinski
2023-01-26 22:37 ` Jakub Kicinski
2023-01-26 22:44 ` [Bridge] " Vladimir Oltean
2023-01-26 22:44 ` Vladimir Oltean
2023-01-26 23:39 ` Jakub Kicinski [this message]
2023-01-26 23:39 ` Jakub Kicinski
2023-01-27 5:26 ` [Bridge] " Leon Romanovsky
2023-01-27 5:26 ` Leon Romanovsky
2023-01-27 7:26 ` [Bridge] " Jakub Kicinski
2023-01-27 7:26 ` Jakub Kicinski
2023-01-29 11:43 ` [Bridge] " Leon Romanovsky
2023-01-29 11:43 ` Leon Romanovsky
2023-01-27 5:22 ` [Bridge] " Leon Romanovsky
2023-01-27 5:22 ` Leon Romanovsky
2023-01-27 9:22 ` [Bridge] " Vladimir Oltean
2023-01-27 9:22 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126153921.3823054c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.