From: Denys Dmytriyenko <denis@denix.org>
To: p-bhagat@ti.com
Cc: meta-arago@lists.yoctoproject.org, praneeth@ti.com,
reatmon@ti.com, c-shilwant@ti.com, s-adivi@ti.com,
g-gupta@ti.com
Subject: Re: [meta-arago] [dunfell][PATCH] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile
Date: Mon, 6 Feb 2023 13:41:39 -0500 [thread overview]
Message-ID: <20230206184139.GS22689@denix.org> (raw)
In-Reply-To: <20230206094316.32352-1-p-bhagat@ti.com>
On Mon, Feb 06, 2023 at 03:13:16PM +0530, Paresh Bhagat via lists.yoctoproject.org wrote:
> Command "make linux-dtbs" at SDK top-level generates incorrect overlay
> dtbo file. Fix it by building every device tree binary.
>
> Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
> ---
> .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
> index fa409d0a..a492ac84 100644
> --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
> @@ -4,9 +4,7 @@ linux-dtbs:
> @echo Building the Linux Kernel DTBs
> @echo =====================================
> $(MAKE) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $(DEFCONFIG)
> - @for DTB in __KERNEL_DEVICETREE__; do \
> - $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $$DTB; \
> - done
> + $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) dtbs; \
This doesn't look right!
What exactly do you mean by "incorrect DTBO file generated"? This is exactly
how the release binaries (DTBs, DTBOs and images) are built by Yocto - going
through the predefined list building them one by one. Calling "make dtbs" is
a sledgehammer approach and you'll end up with hundreds of unrelated DTBs...
--
Denys
prev parent reply other threads:[~2023-02-06 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 9:43 [dunfell][PATCH] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile Paresh Bhagat
2023-02-06 18:41 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206184139.GS22689@denix.org \
--to=denis@denix.org \
--cc=c-shilwant@ti.com \
--cc=g-gupta@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=p-bhagat@ti.com \
--cc=praneeth@ti.com \
--cc=reatmon@ti.com \
--cc=s-adivi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.