* [dunfell][PATCH] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile
@ 2023-02-06 9:43 Paresh Bhagat
2023-02-06 18:41 ` [meta-arago] " Denys Dmytriyenko
0 siblings, 1 reply; 2+ messages in thread
From: Paresh Bhagat @ 2023-02-06 9:43 UTC (permalink / raw)
To: meta-arago, praneeth, reatmon; +Cc: c-shilwant, s-adivi, g-gupta
Command "make linux-dtbs" at SDK top-level generates incorrect overlay
dtbo file. Fix it by building every device tree binary.
Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
---
.../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
index fa409d0a..a492ac84 100644
--- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
+++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
@@ -4,9 +4,7 @@ linux-dtbs:
@echo Building the Linux Kernel DTBs
@echo =====================================
$(MAKE) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $(DEFCONFIG)
- @for DTB in __KERNEL_DEVICETREE__; do \
- $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $$DTB; \
- done
+ $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) dtbs; \
linux-dtbs_install:
@echo =======================================
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [meta-arago] [dunfell][PATCH] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile
2023-02-06 9:43 [dunfell][PATCH] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile Paresh Bhagat
@ 2023-02-06 18:41 ` Denys Dmytriyenko
0 siblings, 0 replies; 2+ messages in thread
From: Denys Dmytriyenko @ 2023-02-06 18:41 UTC (permalink / raw)
To: p-bhagat; +Cc: meta-arago, praneeth, reatmon, c-shilwant, s-adivi, g-gupta
On Mon, Feb 06, 2023 at 03:13:16PM +0530, Paresh Bhagat via lists.yoctoproject.org wrote:
> Command "make linux-dtbs" at SDK top-level generates incorrect overlay
> dtbo file. Fix it by building every device tree binary.
>
> Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
> ---
> .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
> index fa409d0a..a492ac84 100644
> --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs
> @@ -4,9 +4,7 @@ linux-dtbs:
> @echo Building the Linux Kernel DTBs
> @echo =====================================
> $(MAKE) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $(DEFCONFIG)
> - @for DTB in __KERNEL_DEVICETREE__; do \
> - $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $$DTB; \
> - done
> + $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) dtbs; \
This doesn't look right!
What exactly do you mean by "incorrect DTBO file generated"? This is exactly
how the release binaries (DTBs, DTBOs and images) are built by Yocto - going
through the predefined list building them one by one. Calling "make dtbs" is
a sledgehammer approach and you'll end up with hundreds of unrelated DTBs...
--
Denys
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-06 18:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 9:43 [dunfell][PATCH] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile Paresh Bhagat
2023-02-06 18:41 ` [meta-arago] " Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.