From: Christoph Hellwig <hch@lst.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gvt-dev@lists.freedesktop.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
Date: Wed, 15 Feb 2023 06:51:19 +0100 [thread overview]
Message-ID: <20230215055119.GA29717@lst.de> (raw)
In-Reply-To: <20230215044533.4847-1-rdunlap@infradead.org>
On Tue, Feb 14, 2023 at 08:45:33PM -0800, Randy Dunlap wrote:
> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> into a list of other symbols that do have a dependency (on DRM_I915)
> breaks the driver menu presentation in 'make *config'.
>
> Relocate the DRM_I915_GVT symbol so that it does not cause this
> problem.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Zhi Wang <zhi.a.wang@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
Date: Wed, 15 Feb 2023 06:51:19 +0100 [thread overview]
Message-ID: <20230215055119.GA29717@lst.de> (raw)
In-Reply-To: <20230215044533.4847-1-rdunlap@infradead.org>
On Tue, Feb 14, 2023 at 08:45:33PM -0800, Randy Dunlap wrote:
> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> into a list of other symbols that do have a dependency (on DRM_I915)
> breaks the driver menu presentation in 'make *config'.
>
> Relocate the DRM_I915_GVT symbol so that it does not cause this
> problem.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-02-15 5:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 4:45 [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation Randy Dunlap
2023-02-15 4:45 ` Randy Dunlap
2023-02-15 4:45 ` Randy Dunlap
2023-02-15 5:51 ` Christoph Hellwig [this message]
2023-02-15 5:51 ` Christoph Hellwig
2023-02-15 6:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-15 19:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-17 1:52 ` [Intel-gfx] [PATCH] " Zhenyu Wang
2023-02-17 1:52 ` Zhenyu Wang
2023-02-17 1:52 ` Zhenyu Wang
2023-02-17 6:32 ` [Intel-gfx] " Randy Dunlap
2023-02-17 6:32 ` Randy Dunlap
2023-02-17 6:32 ` Randy Dunlap
2023-02-19 12:52 ` [Intel-gfx] " Zhenyu Wang
2023-02-19 12:52 ` Zhenyu Wang
2023-02-19 12:52 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215055119.GA29717@lst.de \
--to=hch@lst.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.