All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-15  4:45 ` Randy Dunlap
  0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2023-02-15  4:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: dri-devel, intel-gfx, Randy Dunlap, Rodrigo Vivi, intel-gvt-dev,
	Christoph Hellwig

Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
into a list of other symbols that do have a dependency (on DRM_I915)
breaks the driver menu presentation in 'make *config'.

Relocate the DRM_I915_GVT symbol so that it does not cause this
problem.

Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/i915/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -118,9 +118,6 @@ config DRM_I915_USERPTR
 
 	  If in doubt, say "Y".
 
-config DRM_I915_GVT
-	bool
-
 config DRM_I915_GVT_KVMGT
 	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
 	depends on DRM_I915
@@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
 	depends on DRM_I915
 	source "drivers/gpu/drm/i915/Kconfig.unstable"
 endmenu
+
+config DRM_I915_GVT
+	bool

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-15  4:45 ` Randy Dunlap
  0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2023-02-15  4:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Tvrtko Ursulin, dri-devel, intel-gfx, Randy Dunlap, Rodrigo Vivi,
	intel-gvt-dev, Christoph Hellwig, Zhi Wang

Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
into a list of other symbols that do have a dependency (on DRM_I915)
breaks the driver menu presentation in 'make *config'.

Relocate the DRM_I915_GVT symbol so that it does not cause this
problem.

Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/i915/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -118,9 +118,6 @@ config DRM_I915_USERPTR
 
 	  If in doubt, say "Y".
 
-config DRM_I915_GVT
-	bool
-
 config DRM_I915_GVT_KVMGT
 	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
 	depends on DRM_I915
@@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
 	depends on DRM_I915
 	source "drivers/gpu/drm/i915/Kconfig.unstable"
 endmenu
+
+config DRM_I915_GVT
+	bool

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-15  4:45 ` Randy Dunlap
  0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2023-02-15  4:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Christoph Hellwig, Zhi Wang, Jani Nikula,
	Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Zhenyu Wang,
	intel-gfx, intel-gvt-dev, dri-devel

Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
into a list of other symbols that do have a dependency (on DRM_I915)
breaks the driver menu presentation in 'make *config'.

Relocate the DRM_I915_GVT symbol so that it does not cause this
problem.

Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/i915/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -118,9 +118,6 @@ config DRM_I915_USERPTR
 
 	  If in doubt, say "Y".
 
-config DRM_I915_GVT
-	bool
-
 config DRM_I915_GVT_KVMGT
 	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
 	depends on DRM_I915
@@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
 	depends on DRM_I915
 	source "drivers/gpu/drm/i915/Kconfig.unstable"
 endmenu
+
+config DRM_I915_GVT
+	bool

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
  2023-02-15  4:45 ` Randy Dunlap
@ 2023-02-15  5:51   ` Christoph Hellwig
  -1 siblings, 0 replies; 16+ messages in thread
From: Christoph Hellwig @ 2023-02-15  5:51 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: dri-devel, intel-gfx, linux-kernel, Rodrigo Vivi, intel-gvt-dev,
	Christoph Hellwig

On Tue, Feb 14, 2023 at 08:45:33PM -0800, Randy Dunlap wrote:
> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> into a list of other symbols that do have a dependency (on DRM_I915)
> breaks the driver menu presentation in 'make *config'.
> 
> Relocate the DRM_I915_GVT symbol so that it does not cause this
> problem.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-15  5:51   ` Christoph Hellwig
  0 siblings, 0 replies; 16+ messages in thread
From: Christoph Hellwig @ 2023-02-15  5:51 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Christoph Hellwig, Zhi Wang, Jani Nikula,
	Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Zhenyu Wang,
	intel-gfx, intel-gvt-dev, dri-devel

On Tue, Feb 14, 2023 at 08:45:33PM -0800, Randy Dunlap wrote:
> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> into a list of other symbols that do have a dependency (on DRM_I915)
> breaks the driver menu presentation in 'make *config'.
> 
> Relocate the DRM_I915_GVT symbol so that it does not cause this
> problem.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move a Kconfig symbol to unbreak the menu presentation
  2023-02-15  4:45 ` Randy Dunlap
                   ` (2 preceding siblings ...)
  (?)
@ 2023-02-15  6:14 ` Patchwork
  -1 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2023-02-15  6:14 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 4095 bytes --]

== Series Details ==

Series: drm/i915: move a Kconfig symbol to unbreak the menu presentation
URL   : https://patchwork.freedesktop.org/series/114037/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12741 -> Patchwork_114037v1
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/index.html

Participating hosts (38 -> 38)
------------------------------

  Additional (1): fi-pnv-d510 
  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_114037v1:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_suspend@basic-s2idle-without-i915:
    - {bat-rpls-1}:       [PASS][1] -> [ABORT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html

  
Known issues
------------

  Here are the changes found in Patchwork_114037v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live@dmabuf:
    - fi-bsw-nick:        [PASS][3] -> [DMESG-FAIL][4] ([i915#7562] / [i915#7913])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/fi-bsw-nick/igt@i915_selftest@live@dmabuf.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/fi-bsw-nick/igt@i915_selftest@live@dmabuf.html

  * igt@kms_psr@primary_page_flip:
    - fi-pnv-d510:        NOTRUN -> [SKIP][5] ([fdo#109271]) +44 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-glk-j4005:       [DMESG-FAIL][6] ([i915#5334]) -> [PASS][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@requests:
    - {bat-rpls-2}:       [ABORT][8] ([i915#7982]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/bat-rpls-2/igt@i915_selftest@live@requests.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/bat-rpls-2/igt@i915_selftest@live@requests.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#7562]: https://gitlab.freedesktop.org/drm/intel/issues/7562
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
  [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
  [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996


Build changes
-------------

  * Linux: CI_DRM_12741 -> Patchwork_114037v1

  CI-20190529: 20190529
  CI_DRM_12741: 67545af096c3c8dee1d48662a3f4830cd84b1105 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_114037v1: 67545af096c3c8dee1d48662a3f4830cd84b1105 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

cbd2c02030bb drm/i915: move a Kconfig symbol to unbreak the menu presentation

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/index.html

[-- Attachment #2: Type: text/html, Size: 4494 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: move a Kconfig symbol to unbreak the menu presentation
  2023-02-15  4:45 ` Randy Dunlap
                   ` (3 preceding siblings ...)
  (?)
@ 2023-02-15 19:20 ` Patchwork
  -1 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2023-02-15 19:20 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 20514 bytes --]

== Series Details ==

Series: drm/i915: move a Kconfig symbol to unbreak the menu presentation
URL   : https://patchwork.freedesktop.org/series/114037/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12741_full -> Patchwork_114037v1_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/index.html

Participating hosts (10 -> 11)
------------------------------

  Additional (1): shard-rkl0 

New tests
---------

  New tests have been introduced between CI_DRM_12741_full and Patchwork_114037v1_full:

### New IGT tests (1) ###

  * igt@drm_fdinfo@busy-hang@vcs1:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_114037v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [PASS][1] -> [FAIL][2] ([i915#2842])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [PASS][3] -> [FAIL][4] ([i915#2842])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_spin_batch@spin-each:
    - shard-apl:          [PASS][5] -> [FAIL][6] ([i915#2898])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-apl6/igt@gem_spin_batch@spin-each.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-apl3/igt@gem_spin_batch@spin-each.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-glk:          [PASS][7] -> [ABORT][8] ([i915#5566])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-glk3/igt@gen9_exec_parse@allowed-single.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-glk5/igt@gen9_exec_parse@allowed-single.html

  * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
    - shard-glk:          NOTRUN -> [SKIP][9] ([fdo#109271])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-glk1/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html

  * igt@kms_flip@2x-nonexisting-fb:
    - shard-snb:          NOTRUN -> [SKIP][10] ([fdo#109271]) +21 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-snb5/igt@kms_flip@2x-nonexisting-fb.html

  * igt@kms_psr2_sf@plane-move-sf-dmg-area:
    - shard-glk:          NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#658])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-glk5/igt@kms_psr2_sf@plane-move-sf-dmg-area.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@virtual-idle:
    - {shard-rkl}:        [FAIL][12] ([i915#7742]) -> [PASS][13] +1 similar issue
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-2/igt@drm_fdinfo@virtual-idle.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-5/igt@drm_fdinfo@virtual-idle.html

  * igt@feature_discovery@psr2:
    - {shard-rkl}:        [SKIP][14] ([i915#658]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-2/igt@feature_discovery@psr2.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-6/igt@feature_discovery@psr2.html

  * igt@gem_ctx_exec@basic-nohangcheck:
    - {shard-tglu}:       [FAIL][16] ([i915#6268]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-tglu-1/igt@gem_ctx_exec@basic-nohangcheck.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-tglu-2/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_ctx_persistence@hang:
    - {shard-rkl}:        [SKIP][18] ([i915#6252]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-5/igt@gem_ctx_persistence@hang.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-3/igt@gem_ctx_persistence@hang.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [FAIL][20] ([i915#2842]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
    - {shard-rkl}:        [FAIL][22] ([i915#2842]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-1/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_reloc@basic-gtt:
    - {shard-rkl}:        [SKIP][24] ([i915#3281]) -> [PASS][25] +5 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-2/igt@gem_exec_reloc@basic-gtt.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-5/igt@gem_exec_reloc@basic-gtt.html

  * igt@gem_exec_suspend@basic-s3@smem:
    - {shard-rkl}:        [ABORT][26] ([i915#5122]) -> [PASS][27]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-4/igt@gem_exec_suspend@basic-s3@smem.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-1/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@gem_pwrite_snooped:
    - {shard-rkl}:        [SKIP][28] ([i915#3282]) -> [PASS][29] +3 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-2/igt@gem_pwrite_snooped.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-5/igt@gem_pwrite_snooped.html

  * igt@gen9_exec_parse@cmd-crossing-page:
    - {shard-rkl}:        [SKIP][30] ([i915#2527]) -> [PASS][31] +1 similar issue
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-2/igt@gen9_exec_parse@cmd-crossing-page.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-5/igt@gen9_exec_parse@cmd-crossing-page.html

  * igt@i915_hangman@gt-engine-error@bcs0:
    - {shard-rkl}:        [SKIP][32] ([i915#6258]) -> [PASS][33]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-5/igt@i915_hangman@gt-engine-error@bcs0.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-6/igt@i915_hangman@gt-engine-error@bcs0.html

  * igt@i915_pm_rc6_residency@rc6-idle@rcs0:
    - {shard-dg1}:        [FAIL][34] ([i915#3591]) -> [PASS][35] +1 similar issue
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-dg1-16/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html

  * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
    - shard-apl:          [FAIL][36] ([i915#2346]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
    - shard-glk:          [FAIL][38] ([i915#2346]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
    - {shard-rkl}:        [SKIP][40] ([i915#1849] / [i915#4098]) -> [PASS][41] +11 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt.html

  * igt@kms_plane@plane-position-hole@pipe-b-planes:
    - {shard-rkl}:        [SKIP][42] ([i915#1849]) -> [PASS][43] +3 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-2/igt@kms_plane@plane-position-hole@pipe-b-planes.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-6/igt@kms_plane@plane-position-hole@pipe-b-planes.html

  * igt@kms_psr@sprite_render:
    - {shard-rkl}:        [SKIP][44] ([i915#1072]) -> [PASS][45] +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-5/igt@kms_psr@sprite_render.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-6/igt@kms_psr@sprite_render.html

  * igt@kms_vblank@pipe-b-ts-continuation-idle:
    - {shard-rkl}:        [SKIP][46] ([i915#1845] / [i915#4098]) -> [PASS][47] +14 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-rkl-5/igt@kms_vblank@pipe-b-ts-continuation-idle.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-rkl-6/igt@kms_vblank@pipe-b-ts-continuation-idle.html

  * igt@perf@stress-open-close:
    - shard-glk:          [ABORT][48] ([i915#5213]) -> [PASS][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12741/shard-glk1/igt@perf@stress-open-close.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/shard-glk5/igt@perf@stress-open-close.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
  [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#2898]: https://gitlab.freedesktop.org/drm/intel/issues/2898
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
  [i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
  [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
  [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
  [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
  [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
  [i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
  [i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
  [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
  [i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
  [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
  [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
  [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
  [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152


Build changes
-------------

  * Linux: CI_DRM_12741 -> Patchwork_114037v1

  CI-20190529: 20190529
  CI_DRM_12741: 67545af096c3c8dee1d48662a3f4830cd84b1105 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_114037v1: 67545af096c3c8dee1d48662a3f4830cd84b1105 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114037v1/index.html

[-- Attachment #2: Type: text/html, Size: 13693 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
  2023-02-15  4:45 ` Randy Dunlap
  (?)
@ 2023-02-17  1:52   ` Zhenyu Wang
  -1 siblings, 0 replies; 16+ messages in thread
From: Zhenyu Wang @ 2023-02-17  1:52 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: dri-devel, intel-gfx, linux-kernel, Rodrigo Vivi, intel-gvt-dev,
	Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> into a list of other symbols that do have a dependency (on DRM_I915)
> breaks the driver menu presentation in 'make *config'.
>

I'm not sure what's the actual failure in presentation, I'm not quite familiar
with Kconfig, could you help to elaborate?

thanks!

> Relocate the DRM_I915_GVT symbol so that it does not cause this
> problem.
> 
> Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: intel-gvt-dev@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/i915/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -118,9 +118,6 @@ config DRM_I915_USERPTR
>  
>  	  If in doubt, say "Y".
>  
> -config DRM_I915_GVT
> -	bool
> -
>  config DRM_I915_GVT_KVMGT
>  	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
>  	depends on DRM_I915
> @@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
>  	depends on DRM_I915
>  	source "drivers/gpu/drm/i915/Kconfig.unstable"
>  endmenu
> +
> +config DRM_I915_GVT
> +	bool

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-17  1:52   ` Zhenyu Wang
  0 siblings, 0 replies; 16+ messages in thread
From: Zhenyu Wang @ 2023-02-17  1:52 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Tvrtko Ursulin, dri-devel, intel-gfx, linux-kernel, Rodrigo Vivi,
	intel-gvt-dev, Christoph Hellwig, Zhi Wang

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> into a list of other symbols that do have a dependency (on DRM_I915)
> breaks the driver menu presentation in 'make *config'.
>

I'm not sure what's the actual failure in presentation, I'm not quite familiar
with Kconfig, could you help to elaborate?

thanks!

> Relocate the DRM_I915_GVT symbol so that it does not cause this
> problem.
> 
> Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: intel-gvt-dev@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/i915/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -118,9 +118,6 @@ config DRM_I915_USERPTR
>  
>  	  If in doubt, say "Y".
>  
> -config DRM_I915_GVT
> -	bool
> -
>  config DRM_I915_GVT_KVMGT
>  	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
>  	depends on DRM_I915
> @@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
>  	depends on DRM_I915
>  	source "drivers/gpu/drm/i915/Kconfig.unstable"
>  endmenu
> +
> +config DRM_I915_GVT
> +	bool

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-17  1:52   ` Zhenyu Wang
  0 siblings, 0 replies; 16+ messages in thread
From: Zhenyu Wang @ 2023-02-17  1:52 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Christoph Hellwig, Zhi Wang, Jani Nikula,
	Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Zhenyu Wang,
	intel-gfx, intel-gvt-dev, dri-devel

[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]

On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> into a list of other symbols that do have a dependency (on DRM_I915)
> breaks the driver menu presentation in 'make *config'.
>

I'm not sure what's the actual failure in presentation, I'm not quite familiar
with Kconfig, could you help to elaborate?

thanks!

> Relocate the DRM_I915_GVT symbol so that it does not cause this
> problem.
> 
> Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: intel-gvt-dev@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/i915/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -118,9 +118,6 @@ config DRM_I915_USERPTR
>  
>  	  If in doubt, say "Y".
>  
> -config DRM_I915_GVT
> -	bool
> -
>  config DRM_I915_GVT_KVMGT
>  	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
>  	depends on DRM_I915
> @@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
>  	depends on DRM_I915
>  	source "drivers/gpu/drm/i915/Kconfig.unstable"
>  endmenu
> +
> +config DRM_I915_GVT
> +	bool

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
  2023-02-17  1:52   ` Zhenyu Wang
  (?)
@ 2023-02-17  6:32     ` Randy Dunlap
  -1 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2023-02-17  6:32 UTC (permalink / raw)
  To: Zhenyu Wang
  Cc: intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi, intel-gvt-dev,
	Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]

Hi,

On 2/16/23 17:52, Zhenyu Wang wrote:
> On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
>> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
>> into a list of other symbols that do have a dependency (on DRM_I915)
>> breaks the driver menu presentation in 'make *config'.
>>
> 
> I'm not sure what's the actual failure in presentation, I'm not quite familiar
> with Kconfig, could you help to elaborate?
> 
> thanks!

For menuconfig and nconfig, it's a subtle difference. The following menu
items are indented more after the patch (i.e., they are not indented enough
before the patch):

 │ <M>   Enable KVM host support Intel GVT-g graphics virtualization          │
 │ [*]   Enable Intel PXP support                                             │
 │       drm/i915 Debugging  --->                                             │
 │       drm/i915 Profile Guided Optimisation  --->

Same menu items for gconfig: they should all be subordinate (so indented)
to the main
<M> Intel 8xx/9xx/G3x/G4x/HD Graphics
menu.

For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guided Optimisation"
are shown on the left side window, while are of the other i915 options are shown in the
right side window (before the patch).
After the patch, all subordinate options are listed in the right side window under the
main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item.

See attached photos for comparisons.

HTH.


>> Relocate the DRM_I915_GVT symbol so that it does not cause this
>> problem.
>>
>> Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Zhi Wang <zhi.a.wang@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Cc: intel-gvt-dev@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>>  drivers/gpu/drm/i915/Kconfig |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
>> --- a/drivers/gpu/drm/i915/Kconfig
>> +++ b/drivers/gpu/drm/i915/Kconfig
>> @@ -118,9 +118,6 @@ config DRM_I915_USERPTR
>>  
>>  	  If in doubt, say "Y".
>>  
>> -config DRM_I915_GVT
>> -	bool
>> -
>>  config DRM_I915_GVT_KVMGT
>>  	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
>>  	depends on DRM_I915
>> @@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
>>  	depends on DRM_I915
>>  	source "drivers/gpu/drm/i915/Kconfig.unstable"
>>  endmenu
>> +
>> +config DRM_I915_GVT
>> +	bool

-- 
~Randy

[-- Attachment #2: xconfig-aft-patch.png --]
[-- Type: image/png, Size: 176376 bytes --]

[-- Attachment #3: xconfig-b4-patch.png --]
[-- Type: image/png, Size: 170454 bytes --]

[-- Attachment #4: gconfig-aft-patch.png --]
[-- Type: image/png, Size: 94579 bytes --]

[-- Attachment #5: gconfig-b4-patch.png --]
[-- Type: image/png, Size: 89000 bytes --]

[-- Attachment #6: nconfig-aft-patch.png --]
[-- Type: image/png, Size: 93714 bytes --]

[-- Attachment #7: nconfig-b4-patch.png --]
[-- Type: image/png, Size: 93718 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-17  6:32     ` Randy Dunlap
  0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2023-02-17  6:32 UTC (permalink / raw)
  To: Zhenyu Wang
  Cc: Tvrtko Ursulin, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi,
	intel-gvt-dev, Christoph Hellwig, Zhi Wang

[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]

Hi,

On 2/16/23 17:52, Zhenyu Wang wrote:
> On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
>> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
>> into a list of other symbols that do have a dependency (on DRM_I915)
>> breaks the driver menu presentation in 'make *config'.
>>
> 
> I'm not sure what's the actual failure in presentation, I'm not quite familiar
> with Kconfig, could you help to elaborate?
> 
> thanks!

For menuconfig and nconfig, it's a subtle difference. The following menu
items are indented more after the patch (i.e., they are not indented enough
before the patch):

 │ <M>   Enable KVM host support Intel GVT-g graphics virtualization          │
 │ [*]   Enable Intel PXP support                                             │
 │       drm/i915 Debugging  --->                                             │
 │       drm/i915 Profile Guided Optimisation  --->

Same menu items for gconfig: they should all be subordinate (so indented)
to the main
<M> Intel 8xx/9xx/G3x/G4x/HD Graphics
menu.

For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guided Optimisation"
are shown on the left side window, while are of the other i915 options are shown in the
right side window (before the patch).
After the patch, all subordinate options are listed in the right side window under the
main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item.

See attached photos for comparisons.

HTH.


>> Relocate the DRM_I915_GVT symbol so that it does not cause this
>> problem.
>>
>> Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Zhi Wang <zhi.a.wang@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Cc: intel-gvt-dev@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>>  drivers/gpu/drm/i915/Kconfig |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
>> --- a/drivers/gpu/drm/i915/Kconfig
>> +++ b/drivers/gpu/drm/i915/Kconfig
>> @@ -118,9 +118,6 @@ config DRM_I915_USERPTR
>>  
>>  	  If in doubt, say "Y".
>>  
>> -config DRM_I915_GVT
>> -	bool
>> -
>>  config DRM_I915_GVT_KVMGT
>>  	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
>>  	depends on DRM_I915
>> @@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
>>  	depends on DRM_I915
>>  	source "drivers/gpu/drm/i915/Kconfig.unstable"
>>  endmenu
>> +
>> +config DRM_I915_GVT
>> +	bool

-- 
~Randy

[-- Attachment #2: xconfig-aft-patch.png --]
[-- Type: image/png, Size: 176376 bytes --]

[-- Attachment #3: xconfig-b4-patch.png --]
[-- Type: image/png, Size: 170454 bytes --]

[-- Attachment #4: gconfig-aft-patch.png --]
[-- Type: image/png, Size: 94579 bytes --]

[-- Attachment #5: gconfig-b4-patch.png --]
[-- Type: image/png, Size: 89000 bytes --]

[-- Attachment #6: nconfig-aft-patch.png --]
[-- Type: image/png, Size: 93714 bytes --]

[-- Attachment #7: nconfig-b4-patch.png --]
[-- Type: image/png, Size: 93718 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-17  6:32     ` Randy Dunlap
  0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2023-02-17  6:32 UTC (permalink / raw)
  To: Zhenyu Wang
  Cc: linux-kernel, Christoph Hellwig, Zhi Wang, Jani Nikula,
	Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, intel-gfx,
	intel-gvt-dev, dri-devel

[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]

Hi,

On 2/16/23 17:52, Zhenyu Wang wrote:
> On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
>> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
>> into a list of other symbols that do have a dependency (on DRM_I915)
>> breaks the driver menu presentation in 'make *config'.
>>
> 
> I'm not sure what's the actual failure in presentation, I'm not quite familiar
> with Kconfig, could you help to elaborate?
> 
> thanks!

For menuconfig and nconfig, it's a subtle difference. The following menu
items are indented more after the patch (i.e., they are not indented enough
before the patch):

 │ <M>   Enable KVM host support Intel GVT-g graphics virtualization          │
 │ [*]   Enable Intel PXP support                                             │
 │       drm/i915 Debugging  --->                                             │
 │       drm/i915 Profile Guided Optimisation  --->

Same menu items for gconfig: they should all be subordinate (so indented)
to the main
<M> Intel 8xx/9xx/G3x/G4x/HD Graphics
menu.

For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guided Optimisation"
are shown on the left side window, while are of the other i915 options are shown in the
right side window (before the patch).
After the patch, all subordinate options are listed in the right side window under the
main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item.

See attached photos for comparisons.

HTH.


>> Relocate the DRM_I915_GVT symbol so that it does not cause this
>> problem.
>>
>> Fixes: 8b750bf74418 ("drm/i915/gvt: move the gvt code into kvmgt.ko")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Zhi Wang <zhi.a.wang@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Cc: intel-gvt-dev@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>>  drivers/gpu/drm/i915/Kconfig |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff -- a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
>> --- a/drivers/gpu/drm/i915/Kconfig
>> +++ b/drivers/gpu/drm/i915/Kconfig
>> @@ -118,9 +118,6 @@ config DRM_I915_USERPTR
>>  
>>  	  If in doubt, say "Y".
>>  
>> -config DRM_I915_GVT
>> -	bool
>> -
>>  config DRM_I915_GVT_KVMGT
>>  	tristate "Enable KVM host support Intel GVT-g graphics virtualization"
>>  	depends on DRM_I915
>> @@ -172,3 +169,6 @@ menu "drm/i915 Unstable Evolution"
>>  	depends on DRM_I915
>>  	source "drivers/gpu/drm/i915/Kconfig.unstable"
>>  endmenu
>> +
>> +config DRM_I915_GVT
>> +	bool

-- 
~Randy

[-- Attachment #2: xconfig-aft-patch.png --]
[-- Type: image/png, Size: 176376 bytes --]

[-- Attachment #3: xconfig-b4-patch.png --]
[-- Type: image/png, Size: 170454 bytes --]

[-- Attachment #4: gconfig-aft-patch.png --]
[-- Type: image/png, Size: 94579 bytes --]

[-- Attachment #5: gconfig-b4-patch.png --]
[-- Type: image/png, Size: 89000 bytes --]

[-- Attachment #6: nconfig-aft-patch.png --]
[-- Type: image/png, Size: 93714 bytes --]

[-- Attachment #7: nconfig-b4-patch.png --]
[-- Type: image/png, Size: 93718 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
  2023-02-17  6:32     ` Randy Dunlap
  (?)
@ 2023-02-19 12:52       ` Zhenyu Wang
  -1 siblings, 0 replies; 16+ messages in thread
From: Zhenyu Wang @ 2023-02-19 12:52 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi, intel-gvt-dev,
	Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

On 2023.02.16 22:32:33 -0800, Randy Dunlap wrote:
> Hi,
> 
> On 2/16/23 17:52, Zhenyu Wang wrote:
> > On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> >> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> >> into a list of other symbols that do have a dependency (on DRM_I915)
> >> breaks the driver menu presentation in 'make *config'.
> >>
> > 
> > I'm not sure what's the actual failure in presentation, I'm not quite familiar
> > with Kconfig, could you help to elaborate?
> > 
> > thanks!
> 
> For menuconfig and nconfig, it's a subtle difference. The following menu
> items are indented more after the patch (i.e., they are not indented enough
> before the patch):
> 
>  │ <M>   Enable KVM host support Intel GVT-g graphics virtualization          │
>  │ [*]   Enable Intel PXP support                                             │
>  │       drm/i915 Debugging  --->                                             │
>  │       drm/i915 Profile Guided Optimisation  --->
> 
> Same menu items for gconfig: they should all be subordinate (so indented)
> to the main
> <M> Intel 8xx/9xx/G3x/G4x/HD Graphics
> menu.
> 
> For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guided Optimisation"
> are shown on the left side window, while are of the other i915 options are shown in the
> right side window (before the patch).
> After the patch, all subordinate options are listed in the right side window under the
> main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item.
> 
> See attached photos for comparisons.
> 

I wasn't awared of the wrong indentation. Thanks a lot, Randy!

Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-19 12:52       ` Zhenyu Wang
  0 siblings, 0 replies; 16+ messages in thread
From: Zhenyu Wang @ 2023-02-19 12:52 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Tvrtko Ursulin, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi,
	intel-gvt-dev, Christoph Hellwig, Zhi Wang

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

On 2023.02.16 22:32:33 -0800, Randy Dunlap wrote:
> Hi,
> 
> On 2/16/23 17:52, Zhenyu Wang wrote:
> > On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> >> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> >> into a list of other symbols that do have a dependency (on DRM_I915)
> >> breaks the driver menu presentation in 'make *config'.
> >>
> > 
> > I'm not sure what's the actual failure in presentation, I'm not quite familiar
> > with Kconfig, could you help to elaborate?
> > 
> > thanks!
> 
> For menuconfig and nconfig, it's a subtle difference. The following menu
> items are indented more after the patch (i.e., they are not indented enough
> before the patch):
> 
>  │ <M>   Enable KVM host support Intel GVT-g graphics virtualization          │
>  │ [*]   Enable Intel PXP support                                             │
>  │       drm/i915 Debugging  --->                                             │
>  │       drm/i915 Profile Guided Optimisation  --->
> 
> Same menu items for gconfig: they should all be subordinate (so indented)
> to the main
> <M> Intel 8xx/9xx/G3x/G4x/HD Graphics
> menu.
> 
> For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guided Optimisation"
> are shown on the left side window, while are of the other i915 options are shown in the
> right side window (before the patch).
> After the patch, all subordinate options are listed in the right side window under the
> main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item.
> 
> See attached photos for comparisons.
> 

I wasn't awared of the wrong indentation. Thanks a lot, Randy!

Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation
@ 2023-02-19 12:52       ` Zhenyu Wang
  0 siblings, 0 replies; 16+ messages in thread
From: Zhenyu Wang @ 2023-02-19 12:52 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Christoph Hellwig, Zhi Wang, Jani Nikula,
	Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, intel-gfx,
	intel-gvt-dev, dri-devel

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

On 2023.02.16 22:32:33 -0800, Randy Dunlap wrote:
> Hi,
> 
> On 2/16/23 17:52, Zhenyu Wang wrote:
> > On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote:
> >> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT)
> >> into a list of other symbols that do have a dependency (on DRM_I915)
> >> breaks the driver menu presentation in 'make *config'.
> >>
> > 
> > I'm not sure what's the actual failure in presentation, I'm not quite familiar
> > with Kconfig, could you help to elaborate?
> > 
> > thanks!
> 
> For menuconfig and nconfig, it's a subtle difference. The following menu
> items are indented more after the patch (i.e., they are not indented enough
> before the patch):
> 
>  │ <M>   Enable KVM host support Intel GVT-g graphics virtualization          │
>  │ [*]   Enable Intel PXP support                                             │
>  │       drm/i915 Debugging  --->                                             │
>  │       drm/i915 Profile Guided Optimisation  --->
> 
> Same menu items for gconfig: they should all be subordinate (so indented)
> to the main
> <M> Intel 8xx/9xx/G3x/G4x/HD Graphics
> menu.
> 
> For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guided Optimisation"
> are shown on the left side window, while are of the other i915 options are shown in the
> right side window (before the patch).
> After the patch, all subordinate options are listed in the right side window under the
> main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item.
> 
> See attached photos for comparisons.
> 

I wasn't awared of the wrong indentation. Thanks a lot, Randy!

Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2023-02-19 12:56 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15  4:45 [Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation Randy Dunlap
2023-02-15  4:45 ` Randy Dunlap
2023-02-15  4:45 ` Randy Dunlap
2023-02-15  5:51 ` [Intel-gfx] " Christoph Hellwig
2023-02-15  5:51   ` Christoph Hellwig
2023-02-15  6:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-15 19:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-17  1:52 ` [Intel-gfx] [PATCH] " Zhenyu Wang
2023-02-17  1:52   ` Zhenyu Wang
2023-02-17  1:52   ` Zhenyu Wang
2023-02-17  6:32   ` [Intel-gfx] " Randy Dunlap
2023-02-17  6:32     ` Randy Dunlap
2023-02-17  6:32     ` Randy Dunlap
2023-02-19 12:52     ` [Intel-gfx] " Zhenyu Wang
2023-02-19 12:52       ` Zhenyu Wang
2023-02-19 12:52       ` Zhenyu Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.