From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
willemb@google.com, fw@strlen.de
Subject: Re: [RFC] net: skbuff: let struct skb_ext live inside the head
Date: Wed, 15 Feb 2023 09:58:34 -0800 [thread overview]
Message-ID: <20230215095834.42f5e227@kernel.org> (raw)
In-Reply-To: <c4cea30465ff621681090fff69d5ccc97f53e85a.camel@redhat.com>
On Wed, 15 Feb 2023 09:53:54 +0100 Paolo Abeni wrote:
> Still, if you are willing to experiment more this idea, I think you
> could save the extra cacheline miss encoding the 'alloc_mode' into the
> lower bits of skb->extensions (alike what _skb_refdst is doing with the
> SKB_DST_NOREF flag).
I thought I'd start with a simpler approach where allocation type
is stored in the object itself, to limit the negative reactions :P
We could indeed save a cache miss (I think it'd be actually one fewer
miss than the current implementation, because most cases must end
up looking at the skb_ext, f.e. to read the refcount. The fact that
SHARD_NOREF implies refcnt == 1 can save us reading from skb_ext).
next prev parent reply other threads:[~2023-02-15 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 3:44 [RFC] net: skbuff: let struct skb_ext live inside the head Jakub Kicinski
2023-02-15 8:53 ` Paolo Abeni
2023-02-15 17:58 ` Jakub Kicinski [this message]
2023-02-15 9:43 ` Florian Westphal
2023-02-15 14:37 ` Willem de Bruijn
2023-02-15 18:10 ` Jakub Kicinski
2023-02-15 18:13 ` Jakub Kicinski
2023-02-16 13:28 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215095834.42f5e227@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.