[PATCH] tests: grub_cmd_cryptomount should hard error when pre-requisites are not met

[PATCH] tests: grub_cmd_cryptomount should hard error when pre-requisites are not met

[Glenn Washburn]

Tests should be SKIP'd only when they do not apply to a particular target.
Hard errors are for when the test should run but can not be setup properly.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 tests/grub_cmd_cryptomount.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/grub_cmd_cryptomount.in b/tests/grub_cmd_cryptomount.in
index b05cd3800e..4578ab7093 100644
--- a/tests/grub_cmd_cryptomount.in
+++ b/tests/grub_cmd_cryptomount.in
@@ -22,17 +22,17 @@ fi
 
 if [ "$EUID" != 0 ] ; then
    echo "not root; cannot test cryptomount."
-   exit 77
+   exit 99
 fi
 
 if ! which cryptsetup >/dev/null 2>&1; then
    echo "cryptsetup not installed; cannot test cryptomount."
-   exit 77
+   exit 99
 fi
 
 if ! which mkfs.vfat >/dev/null 2>&1; then
    echo "mkfs.vfat not installed; cannot test cryptomount."
-   exit 77
+   exit 99
 fi
 
 COMMON_OPTS='${V:+--debug=$V} --cs-opts="--pbkdf-force-iterations 1000"'
-- 
2.34.1

Re: [PATCH] tests: grub_cmd_cryptomount should hard error when pre-requisites are not met

[Daniel Kiper]

On Thu, Feb 16, 2023 at 01:08:21AM -0600, Glenn Washburn wrote:
> Tests should be SKIP'd only when they do not apply to a particular target.
> Hard errors are for when the test should run but can not be setup properly.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel