* drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here
@ 2023-02-15 21:29 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-02-15 21:29 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Lucas De Marchi <lucas.demarchi@intel.com>
CC: Wayne Boyer <wayne.boyer@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e1c04510f521e853019afeca2a5991a5ef8d6a5b
commit: 3d99597c6496b9319f7522e0d073afab314d518a drm/i915: Split i915_gem_init_stolen()
date: 5 months ago
:::::: branch date: 28 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-m001-20230213 (https://download.01.org/0day-ci/archive/20230216/202302160504.G6Rsomen-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302160504.G6Rsomen-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:455 init_reserved_stolen() warn: missing error code 'ret'
vim +173 drivers/gpu/drm/i915/gem/i915_gem_stolen.c
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 141
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 142 static int request_smem_stolen(struct drm_i915_private *i915,
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 143 struct resource *dsm)
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 144 {
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 145 struct resource *r;
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 146
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 147 /*
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 148 * With stolen lmem, we don't need to request system memory for the
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 149 * address range since it's local to the gpu.
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 150 */
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 151 if (HAS_LMEM(i915))
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 152 return 0;
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 153
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 154 /*
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 155 * Verify that nothing else uses this physical address. Stolen
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 156 * memory should be reserved by the BIOS and hidden from the
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 157 * kernel. So if the region is already marked as busy, something
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 158 * is seriously wrong.
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 159 */
bdce2bea0f5e6b drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 160 r = devm_request_mem_region(i915->drm.dev, dsm->start,
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 161 resource_size(dsm),
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 162 "Graphics Stolen Memory");
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 163 if (r == NULL) {
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 164 /*
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 165 * One more attempt but this time requesting region from
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 166 * start + 1, as we have seen that this resolves the region
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 167 * conflict with the PCI Bus.
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 168 * This is a BIOS w/a: Some BIOS wrap stolen in the root
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 169 * PCI bus, but have an off-by-one error. Hence retry the
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 170 * reservation starting from 1 instead of 0.
023f807989f4d6 drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2017-07-19 171 * There's also BIOS with off-by-one on the other end.
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 172 */
bdce2bea0f5e6b drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 @173 r = devm_request_mem_region(i915->drm.dev, dsm->start + 1,
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 174 resource_size(dsm) - 2,
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 175 "Graphics Stolen Memory");
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 176 /*
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 177 * GEN3 firmware likes to smash pci bridges into the stolen
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 178 * range. Apparently this works.
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 179 */
40e1956ec505a1 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2021-06-05 180 if (!r && GRAPHICS_VER(i915) != 3) {
baa89ba3f1feda drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 181 drm_err(&i915->drm,
baa89ba3f1feda drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 182 "conflict detected with stolen region: %pR\n",
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 183 dsm);
920bcd1820a696 drivers/gpu/drm/i915/i915_gem_stolen.c Paulo Zanoni 2017-01-26 184
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 185 return -EBUSY;
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 186 }
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 187 }
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 188
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 189 return 0;
9797fbfbcfe251 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 190 }
9797fbfbcfe251 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 191
:::::: The code at line 173 was first introduced by commit
:::::: bdce2bea0f5e6bd3e3fa85278cc2fb8632f71572 drm/i915/gem: Replace implicit dev_priv->uncore for stolen init
:::::: TO: Chris Wilson <chris@chris-wilson.co.uk>
:::::: CC: Chris Wilson <chris@chris-wilson.co.uk>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here
@ 2023-02-18 14:23 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-02-18 14:23 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Lucas De Marchi <lucas.demarchi@intel.com>
CC: Wayne Boyer <wayne.boyer@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 38f8ccde04a3fa317b51b05e63c3cb57e1641931
commit: 3d99597c6496b9319f7522e0d073afab314d518a drm/i915: Split i915_gem_init_stolen()
date: 5 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-m001-20230213 (https://download.01.org/0day-ci/archive/20230218/202302182250.KJRCvS90-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302182250.KJRCvS90-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:455 init_reserved_stolen() warn: missing error code 'ret'
vim +173 drivers/gpu/drm/i915/gem/i915_gem_stolen.c
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 141
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 142 static int request_smem_stolen(struct drm_i915_private *i915,
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 143 struct resource *dsm)
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 144 {
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 145 struct resource *r;
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 146
d57d4a1daf5e839 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 147 /*
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 148 * With stolen lmem, we don't need to request system memory for the
3d99597c6496b93 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 149 * address range since it's local to the gpu.
d57d4a1daf5e839 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 150 */
d57d4a1daf5e839 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 151 if (HAS_LMEM(i915))
d57d4a1daf5e839 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 152 return 0;
d57d4a1daf5e839 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 153
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 154 /*
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 155 * Verify that nothing else uses this physical address. Stolen
eaba1b8f3379b5d drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 156 * memory should be reserved by the BIOS and hidden from the
eaba1b8f3379b5d drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 157 * kernel. So if the region is already marked as busy, something
eaba1b8f3379b5d drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 158 * is seriously wrong.
eaba1b8f3379b5d drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 159 */
bdce2bea0f5e6bd drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 160 r = devm_request_mem_region(i915->drm.dev, dsm->start,
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 161 resource_size(dsm),
eaba1b8f3379b5d drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 162 "Graphics Stolen Memory");
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 163 if (r == NULL) {
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 164 /*
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 165 * One more attempt but this time requesting region from
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 166 * start + 1, as we have seen that this resolves the region
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 167 * conflict with the PCI Bus.
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 168 * This is a BIOS w/a: Some BIOS wrap stolen in the root
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 169 * PCI bus, but have an off-by-one error. Hence retry the
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 170 * reservation starting from 1 instead of 0.
023f807989f4d6a drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2017-07-19 171 * There's also BIOS with off-by-one on the other end.
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 172 */
bdce2bea0f5e6bd drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 @173 r = devm_request_mem_region(i915->drm.dev, dsm->start + 1,
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 174 resource_size(dsm) - 2,
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 175 "Graphics Stolen Memory");
0b6d24c01932db9 drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 176 /*
0b6d24c01932db9 drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 177 * GEN3 firmware likes to smash pci bridges into the stolen
0b6d24c01932db9 drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 178 * range. Apparently this works.
0b6d24c01932db9 drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 179 */
40e1956ec505a1a drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2021-06-05 180 if (!r && GRAPHICS_VER(i915) != 3) {
baa89ba3f1feda6 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 181 drm_err(&i915->drm,
baa89ba3f1feda6 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 182 "conflict detected with stolen region: %pR\n",
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 183 dsm);
920bcd1820a6966 drivers/gpu/drm/i915/i915_gem_stolen.c Paulo Zanoni 2017-01-26 184
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 185 return -EBUSY;
eaba1b8f3379b5d drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 186 }
3617dc9675f0184 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 187 }
eaba1b8f3379b5d drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 188
7789422665f5998 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 189 return 0;
9797fbfbcfe251b drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 190 }
9797fbfbcfe251b drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 191
:::::: The code at line 173 was first introduced by commit
:::::: bdce2bea0f5e6bd3e3fa85278cc2fb8632f71572 drm/i915/gem: Replace implicit dev_priv->uncore for stolen init
:::::: TO: Chris Wilson <chris@chris-wilson.co.uk>
:::::: CC: Chris Wilson <chris@chris-wilson.co.uk>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here
@ 2023-02-20 8:05 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-02-20 8:05 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Lucas De Marchi <lucas.demarchi@intel.com>
CC: Wayne Boyer <wayne.boyer@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
commit: 3d99597c6496b9319f7522e0d073afab314d518a drm/i915: Split i915_gem_init_stolen()
date: 5 months ago
:::::: branch date: 10 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-m001-20230213 (https://download.01.org/0day-ci/archive/20230220/202302201520.4Ia2vbeF-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202302201520.4Ia2vbeF-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here
drivers/gpu/drm/i915/gem/i915_gem_stolen.c:455 init_reserved_stolen() warn: missing error code 'ret'
vim +173 drivers/gpu/drm/i915/gem/i915_gem_stolen.c
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 141
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 142 static int request_smem_stolen(struct drm_i915_private *i915,
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 143 struct resource *dsm)
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 144 {
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 145 struct resource *r;
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 146
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 147 /*
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 148 * With stolen lmem, we don't need to request system memory for the
3d99597c6496b9 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2022-09-16 149 * address range since it's local to the gpu.
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 150 */
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 151 if (HAS_LMEM(i915))
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 152 return 0;
d57d4a1daf5e83 drivers/gpu/drm/i915/gem/i915_gem_stolen.c CQ Tang 2021-04-21 153
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 154 /*
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 155 * Verify that nothing else uses this physical address. Stolen
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 156 * memory should be reserved by the BIOS and hidden from the
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 157 * kernel. So if the region is already marked as busy, something
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 158 * is seriously wrong.
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 159 */
bdce2bea0f5e6b drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 160 r = devm_request_mem_region(i915->drm.dev, dsm->start,
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 161 resource_size(dsm),
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 162 "Graphics Stolen Memory");
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 163 if (r == NULL) {
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 164 /*
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 165 * One more attempt but this time requesting region from
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 166 * start + 1, as we have seen that this resolves the region
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 167 * conflict with the PCI Bus.
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 168 * This is a BIOS w/a: Some BIOS wrap stolen in the root
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 169 * PCI bus, but have an off-by-one error. Hence retry the
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 170 * reservation starting from 1 instead of 0.
023f807989f4d6 drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2017-07-19 171 * There's also BIOS with off-by-one on the other end.
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 172 */
bdce2bea0f5e6b drivers/gpu/drm/i915/gem/i915_gem_stolen.c Chris Wilson 2019-11-11 @173 r = devm_request_mem_region(i915->drm.dev, dsm->start + 1,
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 174 resource_size(dsm) - 2,
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 175 "Graphics Stolen Memory");
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 176 /*
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 177 * GEN3 firmware likes to smash pci bridges into the stolen
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 178 * range. Apparently this works.
0b6d24c01932db drivers/gpu/drm/i915/i915_gem_stolen.c Daniel Vetter 2014-04-11 179 */
40e1956ec505a1 drivers/gpu/drm/i915/gem/i915_gem_stolen.c Lucas De Marchi 2021-06-05 180 if (!r && GRAPHICS_VER(i915) != 3) {
baa89ba3f1feda drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 181 drm_err(&i915->drm,
baa89ba3f1feda drivers/gpu/drm/i915/gem/i915_gem_stolen.c Wambui Karuga 2020-01-22 182 "conflict detected with stolen region: %pR\n",
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 183 dsm);
920bcd1820a696 drivers/gpu/drm/i915/i915_gem_stolen.c Paulo Zanoni 2017-01-26 184
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 185 return -EBUSY;
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 186 }
3617dc9675f018 drivers/gpu/drm/i915/i915_gem_stolen.c Akash Goel 2014-01-13 187 }
eaba1b8f3379b5 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2013-07-04 188
7789422665f599 drivers/gpu/drm/i915/i915_gem_stolen.c Matthew Auld 2017-12-11 189 return 0;
9797fbfbcfe251 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 190 }
9797fbfbcfe251 drivers/gpu/drm/i915/i915_gem_stolen.c Chris Wilson 2012-04-24 191
:::::: The code at line 173 was first introduced by commit
:::::: bdce2bea0f5e6bd3e3fa85278cc2fb8632f71572 drm/i915/gem: Replace implicit dev_priv->uncore for stolen init
:::::: TO: Chris Wilson <chris@chris-wilson.co.uk>
:::::: CC: Chris Wilson <chris@chris-wilson.co.uk>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-20 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 8:05 drivers/gpu/drm/i915/gem/i915_gem_stolen.c:173 request_smem_stolen() warn: consider using resource_size() here kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-02-18 14:23 kernel test robot
2023-02-15 21:29 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.