From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Eric Dumazet <edumazet@google.com>,
linux-amlogic@lists.infradead.org, Arun.Ramadoss@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
Jose Abreu <joabreu@synopsys.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
Wei Fang <wei.fang@nxp.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
kernel@pengutronix.de, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support
Date: Mon, 27 Feb 2023 06:52:41 +0100 [thread overview]
Message-ID: <20230227055241.GC8437@pengutronix.de> (raw)
In-Reply-To: <Y/ufuLJdMcxc6f47@sirena.org.uk>
Hi Mark,
On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote:
> On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote:
> > Add replacement for phy_ethtool_get/set_eee() functions.
> >
> > Current phy_ethtool_get/set_eee() implementation is great and it is
> > possible to make it even better:
> > - this functionality is for devices implementing parts of IEEE 802.3
> > specification beyond Clause 22. The better place for this code is
> > phy-c45.c
>
> Currently mainline is failing to bring up networking on the Libre
> Computer AML-S905X-CC, with a bisect pointing at this commit,
> 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it
> seems to be in roughly the right place). I've not dug into what's going
> on more than running the bisect yet.
Can you please test following fixes:
https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/
https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wei Fang <wei.fang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com,
intel-wired-lan@lists.osuosl.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
Jose Abreu <joabreu@synopsys.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support
Date: Mon, 27 Feb 2023 06:52:41 +0100 [thread overview]
Message-ID: <20230227055241.GC8437@pengutronix.de> (raw)
In-Reply-To: <Y/ufuLJdMcxc6f47@sirena.org.uk>
Hi Mark,
On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote:
> On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote:
> > Add replacement for phy_ethtool_get/set_eee() functions.
> >
> > Current phy_ethtool_get/set_eee() implementation is great and it is
> > possible to make it even better:
> > - this functionality is for devices implementing parts of IEEE 802.3
> > specification beyond Clause 22. The better place for this code is
> > phy-c45.c
>
> Currently mainline is failing to bring up networking on the Libre
> Computer AML-S905X-CC, with a bisect pointing at this commit,
> 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it
> seems to be in roughly the right place). I've not dug into what's going
> on more than running the bisect yet.
Can you please test following fixes:
https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/
https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wei Fang <wei.fang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com,
intel-wired-lan@lists.osuosl.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
Jose Abreu <joabreu@synopsys.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support
Date: Mon, 27 Feb 2023 06:52:41 +0100 [thread overview]
Message-ID: <20230227055241.GC8437@pengutronix.de> (raw)
In-Reply-To: <Y/ufuLJdMcxc6f47@sirena.org.uk>
Hi Mark,
On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote:
> On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote:
> > Add replacement for phy_ethtool_get/set_eee() functions.
> >
> > Current phy_ethtool_get/set_eee() implementation is great and it is
> > possible to make it even better:
> > - this functionality is for devices implementing parts of IEEE 802.3
> > specification beyond Clause 22. The better place for this code is
> > phy-c45.c
>
> Currently mainline is failing to bring up networking on the Libre
> Computer AML-S905X-CC, with a bisect pointing at this commit,
> 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it
> seems to be in roughly the right place). I've not dug into what's going
> on more than running the bisect yet.
Can you please test following fixes:
https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/
https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wei Fang <wei.fang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com,
intel-wired-lan@lists.osuosl.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
Jose Abreu <joabreu@synopsys.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Subject: Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support
Date: Mon, 27 Feb 2023 06:52:41 +0100 [thread overview]
Message-ID: <20230227055241.GC8437@pengutronix.de> (raw)
In-Reply-To: <Y/ufuLJdMcxc6f47@sirena.org.uk>
Hi Mark,
On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote:
> On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote:
> > Add replacement for phy_ethtool_get/set_eee() functions.
> >
> > Current phy_ethtool_get/set_eee() implementation is great and it is
> > possible to make it even better:
> > - this functionality is for devices implementing parts of IEEE 802.3
> > specification beyond Clause 22. The better place for this code is
> > phy-c45.c
>
> Currently mainline is failing to bring up networking on the Libre
> Computer AML-S905X-CC, with a bisect pointing at this commit,
> 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it
> seems to be in roughly the right place). I've not dug into what's going
> on more than running the bisect yet.
Can you please test following fixes:
https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/
https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-02-27 5:53 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 7:41 [Intel-wired-lan] [PATCH net-next v8 0/9] net: add EEE support for KSZ9477 switch family Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 1/9] net: dsa: microchip: enable EEE support Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 2/9] net: phy: add genphy_c45_read_eee_abilities() function Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 3/9] net: phy: micrel: add ksz9477_get_features() Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 4/9] net: phy: export phy_check_valid() function Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-26 18:06 ` [Intel-wired-lan] " Mark Brown
2023-02-26 18:06 ` Mark Brown
2023-02-26 18:06 ` Mark Brown
2023-02-26 18:06 ` Mark Brown
2023-02-27 5:52 ` Oleksij Rempel [this message]
2023-02-27 5:52 ` Oleksij Rempel
2023-02-27 5:52 ` Oleksij Rempel
2023-02-27 5:52 ` Oleksij Rempel
2023-02-27 13:06 ` [Intel-wired-lan] " Mark Brown
2023-02-27 13:06 ` Mark Brown
2023-02-27 13:06 ` Mark Brown
2023-02-27 13:06 ` Mark Brown
2023-02-27 18:49 ` [Intel-wired-lan] " Jakub Kicinski
2023-02-27 18:49 ` Jakub Kicinski
2023-02-27 18:49 ` Jakub Kicinski
2023-02-27 18:49 ` Jakub Kicinski
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 6/9] net: phy: c22: migrate to genphy_c45_write_eee_adv() Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-24 3:55 ` [Intel-wired-lan] " Guenter Roeck
2023-02-24 3:55 ` Guenter Roeck
2023-02-24 4:16 ` [Intel-wired-lan] " Guenter Roeck
2023-02-24 4:16 ` Guenter Roeck
2023-02-24 4:53 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-24 4:53 ` Oleksij Rempel
2023-02-24 16:00 ` [Intel-wired-lan] " Guenter Roeck
2023-02-24 16:00 ` Guenter Roeck
2023-02-24 16:52 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-24 16:52 ` Oleksij Rempel
2023-02-24 17:41 ` [Intel-wired-lan] " Guenter Roeck
2023-02-24 17:41 ` Guenter Roeck
2023-02-24 18:36 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-24 18:36 ` Oleksij Rempel
2023-02-24 19:17 ` [Intel-wired-lan] " Guenter Roeck
2023-02-24 19:17 ` Guenter Roeck
2023-02-24 20:02 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-24 20:02 ` Oleksij Rempel
2023-02-25 0:09 ` [Intel-wired-lan] " Guenter Roeck
2023-02-25 0:09 ` Guenter Roeck
2023-02-25 6:08 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-25 6:08 ` Oleksij Rempel
2023-02-25 6:32 ` [Intel-wired-lan] " Guenter Roeck
2023-02-25 6:32 ` Guenter Roeck
2023-02-27 13:08 ` [Intel-wired-lan] " Andrew Lunn
2023-02-27 13:08 ` Andrew Lunn
2023-02-27 17:03 ` [Intel-wired-lan] " Guenter Roeck
2023-02-27 17:03 ` Guenter Roeck
2023-02-24 17:20 ` [Intel-wired-lan] " Guenter Roeck
2023-02-24 17:20 ` Guenter Roeck
2023-02-28 18:43 ` [Intel-wired-lan] " Guenter Roeck
2023-02-28 18:43 ` Guenter Roeck
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 7/9] net: phy: c45: " Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 8/9] net: phy: migrate phy_init_eee() to genphy_c45_eee_is_active() Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-11 7:41 ` [Intel-wired-lan] [PATCH net-next v8 9/9] net: phy: start using genphy_c45_ethtool_get/set_eee() Oleksij Rempel
2023-02-11 7:41 ` Oleksij Rempel
2023-02-13 11:30 ` [Intel-wired-lan] [PATCH net-next v8 0/9] net: add EEE support for KSZ9477 switch family patchwork-bot+netdevbpf
2023-02-13 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227055241.GC8437@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=vivien.didelot@gmail.com \
--cc=wei.fang@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.