From: Jakub Kicinski <kuba@kernel.org>
To: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Cc: netdev@vger.kernel.org, jesse.brandeburg@intel.com,
intel-wired-lan@lists.osuosl.org, davem@davemloft.net,
khc@pm.waw.pl
Subject: Re: [Intel-wired-lan] [PATCH v3] netdevice: use ifmap instead of plain fields
Date: Sat, 4 Mar 2023 11:06:41 -0800 [thread overview]
Message-ID: <20230304110641.6467996b@kernel.org> (raw)
In-Reply-To: <20230304115626.215026-1-vincenzopalazzodev@gmail.com>
On Sat, 4 Mar 2023 12:56:26 +0100 Vincenzo Palazzo wrote:
> clean the code by using the ifmap instead of plain fields,
> and avoid code duplication.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303041847.nRrrz1v9-lkp@intel.com/
> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Please don't, as already explained it's not worth the code churn.
Nacked-by: Jakub Kicinski <kuba@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,
khc@pm.waw.pl, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] netdevice: use ifmap instead of plain fields
Date: Sat, 4 Mar 2023 11:06:41 -0800 [thread overview]
Message-ID: <20230304110641.6467996b@kernel.org> (raw)
In-Reply-To: <20230304115626.215026-1-vincenzopalazzodev@gmail.com>
On Sat, 4 Mar 2023 12:56:26 +0100 Vincenzo Palazzo wrote:
> clean the code by using the ifmap instead of plain fields,
> and avoid code duplication.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202303041847.nRrrz1v9-lkp@intel.com/
> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Please don't, as already explained it's not worth the code churn.
Nacked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-03-04 19:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 11:56 [Intel-wired-lan] [PATCH v3] netdevice: use ifmap instead of plain fields Vincenzo Palazzo
2023-03-04 11:56 ` Vincenzo Palazzo
2023-03-04 14:33 ` [Intel-wired-lan] " kernel test robot
2023-03-04 14:33 ` kernel test robot
2023-03-04 14:44 ` [Intel-wired-lan] " kernel test robot
2023-03-04 14:44 ` kernel test robot
2023-03-04 15:05 ` [Intel-wired-lan] " kernel test robot
2023-03-04 15:05 ` kernel test robot
2023-03-04 19:06 ` Jakub Kicinski [this message]
2023-03-04 19:06 ` Jakub Kicinski
2023-03-04 19:33 ` [Intel-wired-lan] " Vincenzo Palazzo
2023-03-04 19:33 ` Vincenzo Palazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230304110641.6467996b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
--cc=vincenzopalazzodev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.