All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Baolu Lu <baolu.lu@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	Joerg Roedel <joro@8bytes.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Will Deacon <will@kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"Jiang, Dave" <dave.jiang@intel.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"Zanussi, Tom" <tom.zanussi@intel.com>,
	jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 1/4] iommu/vt-d: Implement set device pasid op for default domain
Date: Mon, 6 Mar 2023 15:45:04 -0800	[thread overview]
Message-ID: <20230306154504.04769726@jacob-builder> (raw)
In-Reply-To: <ZAY4zd4OlgSz+puZ@nvidia.com>

Hi Jason,

On Mon, 6 Mar 2023 15:02:37 -0400, Jason Gunthorpe <jgg@nvidia.com> wrote:

> On Mon, Mar 06, 2023 at 11:04:43AM -0800, Jacob Pan wrote:
> 
> > > and probably this is the right thing to do as in the end DMA type will
> > > be removed with Jason's cleanup  
> >
> > so, let me recap. set_dev_pasid() should make no assumptions of
> > ordering, i.e. it is equal to iommu_domain_ops.attach_dev().  
> 
> Absolutely yes.
> 
> You should factor out all the "prepare the domain to be used" code and
> call it in both places.
> 
I think this has been done by Baolu
https://lore.kernel.org/linux-iommu/20190325013036.18400-1-baolu.lu@linux.intel.com/T/#m8c980357a39dc75dc360ff0f71dc7ebe1e49f9a6
iommu/vt-d: Move common code out of iommu_attch_device()
    
    This part of code could be used by both normal and aux
    domain specific attach entries. Hence move them into a
    common function to avoid duplication.

set_dev_pasid() will call prepare_domain_attach_device() as well.

Thanks,

Jacob

  reply	other threads:[~2023-03-06 23:41 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02  0:59 [PATCH 0/4] Re-enable IDXD kernel workqueue under DMA API Jacob Pan
2023-03-02  0:59 ` [PATCH 1/4] iommu/vt-d: Implement set device pasid op for default domain Jacob Pan
2023-03-02  9:37   ` Tian, Kevin
2023-03-02 19:25     ` Jacob Pan
2023-03-02 14:06   ` Baolu Lu
2023-03-03  2:36     ` Tian, Kevin
2023-03-03  2:48       ` Baolu Lu
2023-03-03  3:02         ` Tian, Kevin
2023-03-03  4:38           ` Baolu Lu
2023-03-03  5:35             ` Tian, Kevin
2023-03-06 19:04               ` Jacob Pan
2023-03-06 19:02                 ` Jason Gunthorpe
2023-03-06 23:45                   ` Jacob Pan [this message]
2023-03-07  0:45                     ` Jacob Pan
2023-03-03  5:38     ` Tian, Kevin
2023-03-03 16:35       ` Jacob Pan
2023-03-05  3:05         ` Baolu Lu
2023-03-06  8:18           ` Tian, Kevin
2023-03-06 18:43             ` Jacob Pan
2023-03-06 18:29           ` Jacob Pan
2023-03-06 12:57   ` Jason Gunthorpe
2023-03-06 17:36     ` Jacob Pan
2023-03-06 17:41       ` Jason Gunthorpe
2023-03-07  2:15         ` Baolu Lu
2023-03-02  0:59 ` [PATCH 2/4] iommu/vt-d: Use non-privileged mode for all PASIDs Jacob Pan
2023-03-02 14:11   ` Baolu Lu
2023-03-03 21:40     ` Jacob Pan
2023-03-02  0:59 ` [PATCH 3/4] iommu/sva: Support reservation of global PASIDs Jacob Pan
2023-03-02  3:06   ` kernel test robot
2023-03-02  3:19   ` kernel test robot
2023-03-02  9:43   ` Tian, Kevin
2023-03-03 21:47     ` Jacob Pan
2023-03-06 13:01       ` Jason Gunthorpe
2023-03-06 17:44         ` Jacob Pan
2023-03-06 17:43           ` Jason Gunthorpe
2023-03-06 17:57             ` Jacob Pan
2023-03-06 18:19               ` Jason Gunthorpe
2023-03-06 18:48                 ` Luck, Tony
2023-03-06 19:05                   ` Jason Gunthorpe
2023-03-09 17:06                     ` Jacob Pan
2023-03-16  7:25                       ` Tian, Kevin
2023-03-20 17:22                         ` Jason Gunthorpe
2023-03-02  0:59 ` [PATCH 4/4] dmaengine/idxd: Re-enable kernel workqueue under DMA API Jacob Pan
2023-03-02  1:03   ` Dave Jiang
2023-03-02  9:47   ` Tian, Kevin
2023-03-02 12:57     ` Jason Gunthorpe
2023-03-03 21:49       ` Jacob Pan
2023-03-03 22:12     ` Jacob Pan
2023-03-03  1:19   ` Baolu Lu
2023-03-03 21:52     ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230306154504.04769726@jacob-builder \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=fenghua.yu@intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tom.zanussi@intel.com \
    --cc=tony.luck@intel.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.