From: Herve Codina <herve.codina@bootlin.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Li Yang <leoyang.li@nxp.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Mark Brown <broonie@kernel.org>, Qiang Zhao <qiang.zhao@nxp.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC
Date: Tue, 14 Mar 2023 08:57:41 +0100 [thread overview]
Message-ID: <20230314085741.6f968e68@bootlin.com> (raw)
In-Reply-To: <CAKXUXMwwQuwssyzBrOXHOz__YRpa1Rjgqmwn5rRFjDVLBbabPA@mail.gmail.com>
Hi Lukas,
On Tue, 14 Mar 2023 08:21:50 +0100
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Dear Herve,
>
> In your patch below, you added the config CPM_QMC which depends on the
> non-existing config SOC_FSL:
>
> https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@bootlin.com
>
> Up to my knowledge, the config SOC_FSL never existed in the mainline
> tree. Is this dependency really required or can the expression simply
> be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL?
>
> Note: This patch has now shown up in linux-next with commit
> 3178d58e0b97. Currently, it would not be possible to compile test this
> driver, as the dependency on SOC_FSL is never met.
>
>
> Best regards,
>
> Lukas
My bad :(
The dependency must be FSL_SOC instead of SOC_FSL.
I mean:
diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
index f90cfdf0c763..7268c2fbcbc1 100644
--- a/drivers/soc/fsl/qe/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig
@@ -47,7 +47,7 @@ config CPM_TSA
config CPM_QMC
tristate "CPM QMC support"
depends on OF && HAS_IOMEM
- depends on CPM1 || (SOC_FSL && COMPILE_TEST)
+ depends on CPM1 || (FSL_SOC && COMPILE_TEST)
depends on CPM_TSA
help
Freescale CPM QUICC Multichannel Controller
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: kernel-janitors <kernel-janitors@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Li Yang <leoyang.li@nxp.com>, Mark Brown <broonie@kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Qiang Zhao <qiang.zhao@nxp.com>
Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC
Date: Tue, 14 Mar 2023 08:57:41 +0100 [thread overview]
Message-ID: <20230314085741.6f968e68@bootlin.com> (raw)
In-Reply-To: <CAKXUXMwwQuwssyzBrOXHOz__YRpa1Rjgqmwn5rRFjDVLBbabPA@mail.gmail.com>
Hi Lukas,
On Tue, 14 Mar 2023 08:21:50 +0100
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Dear Herve,
>
> In your patch below, you added the config CPM_QMC which depends on the
> non-existing config SOC_FSL:
>
> https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@bootlin.com
>
> Up to my knowledge, the config SOC_FSL never existed in the mainline
> tree. Is this dependency really required or can the expression simply
> be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL?
>
> Note: This patch has now shown up in linux-next with commit
> 3178d58e0b97. Currently, it would not be possible to compile test this
> driver, as the dependency on SOC_FSL is never met.
>
>
> Best regards,
>
> Lukas
My bad :(
The dependency must be FSL_SOC instead of SOC_FSL.
I mean:
diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
index f90cfdf0c763..7268c2fbcbc1 100644
--- a/drivers/soc/fsl/qe/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig
@@ -47,7 +47,7 @@ config CPM_TSA
config CPM_QMC
tristate "CPM QMC support"
depends on OF && HAS_IOMEM
- depends on CPM1 || (SOC_FSL && COMPILE_TEST)
+ depends on CPM1 || (FSL_SOC && COMPILE_TEST)
depends on CPM_TSA
help
Freescale CPM QUICC Multichannel Controller
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Herve Codina <herve.codina@bootlin.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Li Yang <leoyang.li@nxp.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Mark Brown <broonie@kernel.org>, Qiang Zhao <qiang.zhao@nxp.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: Question about the dependency on the config SOC_FSL in CPM_QMC
Date: Tue, 14 Mar 2023 08:57:41 +0100 [thread overview]
Message-ID: <20230314085741.6f968e68@bootlin.com> (raw)
In-Reply-To: <CAKXUXMwwQuwssyzBrOXHOz__YRpa1Rjgqmwn5rRFjDVLBbabPA@mail.gmail.com>
Hi Lukas,
On Tue, 14 Mar 2023 08:21:50 +0100
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Dear Herve,
>
> In your patch below, you added the config CPM_QMC which depends on the
> non-existing config SOC_FSL:
>
> https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@bootlin.com
>
> Up to my knowledge, the config SOC_FSL never existed in the mainline
> tree. Is this dependency really required or can the expression simply
> be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL?
>
> Note: This patch has now shown up in linux-next with commit
> 3178d58e0b97. Currently, it would not be possible to compile test this
> driver, as the dependency on SOC_FSL is never met.
>
>
> Best regards,
>
> Lukas
My bad :(
The dependency must be FSL_SOC instead of SOC_FSL.
I mean:
diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
index f90cfdf0c763..7268c2fbcbc1 100644
--- a/drivers/soc/fsl/qe/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig
@@ -47,7 +47,7 @@ config CPM_TSA
config CPM_QMC
tristate "CPM QMC support"
depends on OF && HAS_IOMEM
- depends on CPM1 || (SOC_FSL && COMPILE_TEST)
+ depends on CPM1 || (FSL_SOC && COMPILE_TEST)
depends on CPM_TSA
help
Freescale CPM QUICC Multichannel Controller
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-14 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 7:21 Question about the dependency on the config SOC_FSL in CPM_QMC Lukas Bulwahn
2023-03-14 7:21 ` Lukas Bulwahn
2023-03-14 7:21 ` Lukas Bulwahn
2023-03-14 7:57 ` Herve Codina [this message]
2023-03-14 7:57 ` Herve Codina
2023-03-14 7:57 ` Herve Codina
2023-03-14 8:17 ` Lukas Bulwahn
2023-03-14 8:17 ` Lukas Bulwahn
2023-03-14 8:17 ` Lukas Bulwahn
2023-03-14 8:31 ` Herve Codina
2023-03-14 8:31 ` Herve Codina
2023-03-14 7:57 ` Christophe Leroy
2023-03-14 7:57 ` Christophe Leroy
2023-03-14 7:57 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314085741.6f968e68@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=kernel-janitors@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas.bulwahn@gmail.com \
--cc=qiang.zhao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.