From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Heng Qi <hengqi@linux.alibaba.com>,
virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org,
Jason Wang <jasowang@redhat.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Cornelia Huck <cohuck@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash
Date: Wed, 15 Mar 2023 08:10:11 -0400 [thread overview]
Message-ID: <20230315075954-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <c81de233-227c-73c8-a4bd-d43aa374dd86@nvidia.com>
On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote:
> If not, for now it may be better to skip vxlan and nvegre as they inherently
> have unique outer header UDP src port based on the inner header.
So what's left, GRE? GRE is actually different, in that it's not IP at
all.
So if we are talking about GRE, hash is indeed not calculated at all at
the moment, right? And I would say a natural first step for GRE is
actually adding a hash type that will support this protocol.
How about doing that? It seems like this should be a small step
and completely uncontroversial.
--
MST
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Heng Qi <hengqi@linux.alibaba.com>,
virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org,
Jason Wang <jasowang@redhat.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Cornelia Huck <cohuck@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-dev] Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash
Date: Wed, 15 Mar 2023 08:10:11 -0400 [thread overview]
Message-ID: <20230315075954-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <c81de233-227c-73c8-a4bd-d43aa374dd86@nvidia.com>
On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote:
> If not, for now it may be better to skip vxlan and nvegre as they inherently
> have unique outer header UDP src port based on the inner header.
So what's left, GRE? GRE is actually different, in that it's not IP at
all.
So if we are talking about GRE, hash is indeed not calculated at all at
the moment, right? And I would say a natural first step for GRE is
actually adding a hash type that will support this protocol.
How about doing that? It seems like this should be a small step
and completely uncontroversial.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-15 12:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 15:48 [virtio-comment] [PATCH v10] virtio-net: support inner header hash Heng Qi
2023-03-06 15:48 ` [virtio-dev] " Heng Qi
2023-03-08 14:27 ` [virtio-comment] " Heng Qi
2023-03-08 14:27 ` Heng Qi
2023-03-08 14:31 ` [virtio-comment] " Michael S. Tsirkin
2023-03-08 14:31 ` Michael S. Tsirkin
2023-03-14 13:59 ` [virtio-comment] " Heng Qi
2023-03-14 13:59 ` [virtio-dev] " Heng Qi
2023-03-15 3:23 ` [virtio-comment] " Parav Pandit
2023-03-15 3:23 ` [virtio-dev] " Parav Pandit
2023-03-15 12:10 ` Michael S. Tsirkin [this message]
2023-03-15 12:10 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-03-15 13:27 ` Heng Qi
2023-03-15 13:27 ` [virtio-dev] " Heng Qi
2023-03-15 23:24 ` Parav Pandit
2023-03-15 23:24 ` [virtio-dev] " Parav Pandit
2023-03-16 7:36 ` Michael S. Tsirkin
2023-03-16 7:36 ` [virtio-dev] " Michael S. Tsirkin
2023-03-16 18:45 ` Parav Pandit
2023-03-16 18:45 ` [virtio-dev] " Parav Pandit
2023-03-16 13:45 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-03-16 13:45 ` Heng Qi
2023-03-15 13:19 ` Heng Qi
2023-03-15 13:19 ` [virtio-dev] " Heng Qi
2023-03-15 15:09 ` [virtio-comment] " Michael S. Tsirkin
2023-03-15 15:09 ` [virtio-dev] " Michael S. Tsirkin
2023-03-16 13:26 ` [virtio-comment] " Heng Qi
2023-03-16 13:26 ` [virtio-dev] " Heng Qi
2023-03-15 23:06 ` [virtio-comment] " Parav Pandit
2023-03-15 23:06 ` [virtio-dev] " Parav Pandit
2023-03-16 13:38 ` [virtio-comment] " Heng Qi
2023-03-16 13:38 ` [virtio-dev] " Heng Qi
2023-03-16 19:55 ` Parav Pandit
2023-03-16 19:55 ` [virtio-dev] " Parav Pandit
2023-03-17 8:38 ` [virtio-comment] " Heng Qi
2023-03-17 8:38 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315075954-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.