From: Jakub Kicinski <kuba@kernel.org>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Looi Hong Aun <hong.aun.looi@intel.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Lai Peter Jun Ann <peter.jun.ann.lai@intel.com>
Subject: Re: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup code
Date: Thu, 16 Mar 2023 17:01:27 -0700 [thread overview]
Message-ID: <20230316170127.5bbd559d@kernel.org> (raw)
In-Reply-To: <20230314070208.3703963-3-michael.wei.hong.sit@intel.com>
On Tue, 14 Mar 2023 15:02:08 +0800 Michael Sit Wei Hong wrote:
> xpcs_an_inband value is updated in the speed_mode_2500 function
> which turns on the xpcs_an_inband mode.
>
> Moving the fixed-link fixup code to right before phylink setup to
> ensure no more fixup will affect the fixed-link mode configurations.
>
> Fixes: 72edaf39fc65 ("stmmac: intel: add phy-mode and fixed-link ACPI _DSD setting support")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Ong Boon, since you added the code which gets moved - could we get
an ack/review tag from you? Helps increase the confidence in the change.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Looi Hong Aun <hong.aun.looi@intel.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Lai Peter Jun Ann <peter.jun.ann.lai@intel.com>
Subject: Re: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup code
Date: Thu, 16 Mar 2023 17:01:27 -0700 [thread overview]
Message-ID: <20230316170127.5bbd559d@kernel.org> (raw)
In-Reply-To: <20230314070208.3703963-3-michael.wei.hong.sit@intel.com>
On Tue, 14 Mar 2023 15:02:08 +0800 Michael Sit Wei Hong wrote:
> xpcs_an_inband value is updated in the speed_mode_2500 function
> which turns on the xpcs_an_inband mode.
>
> Moving the fixed-link fixup code to right before phylink setup to
> ensure no more fixup will affect the fixed-link mode configurations.
>
> Fixes: 72edaf39fc65 ("stmmac: intel: add phy-mode and fixed-link ACPI _DSD setting support")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Ong Boon, since you added the code which gets moved - could we get
an ack/review tag from you? Helps increase the confidence in the change.
next prev parent reply other threads:[~2023-03-17 0:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 7:02 [PATCH net v2 0/2] Fix PHY handle no longer parsing Michael Sit Wei Hong
2023-03-14 7:02 ` Michael Sit Wei Hong
2023-03-14 7:02 ` [PATCH net v2 1/2] net: stmmac: fix PHY handle parsing Michael Sit Wei Hong
2023-03-14 7:02 ` Michael Sit Wei Hong
2023-03-14 9:56 ` Fabian Bläse
2023-03-17 0:00 ` Jakub Kicinski
2023-03-17 0:00 ` Jakub Kicinski
2023-03-17 2:10 ` Sit, Michael Wei Hong
2023-03-17 2:10 ` Sit, Michael Wei Hong
2023-03-17 19:56 ` Andrew Lunn
2023-03-17 19:56 ` Andrew Lunn
2023-03-17 20:57 ` Russell King (Oracle)
2023-03-17 20:57 ` Russell King (Oracle)
2023-03-21 8:34 ` Sit, Michael Wei Hong
2023-03-21 8:34 ` Sit, Michael Wei Hong
2023-03-21 10:24 ` Russell King (Oracle)
2023-03-21 10:24 ` Russell King (Oracle)
2023-03-14 7:02 ` [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup code Michael Sit Wei Hong
2023-03-14 7:02 ` Michael Sit Wei Hong
2023-03-14 9:56 ` Fabian Bläse
2023-03-17 0:01 ` Jakub Kicinski [this message]
2023-03-17 0:01 ` Jakub Kicinski
2023-03-17 20:02 ` Andrew Lunn
2023-03-17 20:02 ` Andrew Lunn
2023-03-21 10:17 ` Sit, Michael Wei Hong
2023-03-21 10:17 ` Sit, Michael Wei Hong
2023-03-17 20:54 ` [PATCH net v2 0/2] Fix PHY handle no longer parsing Russell King (Oracle)
2023-03-17 20:54 ` Russell King (Oracle)
2023-03-21 8:37 ` Sit, Michael Wei Hong
2023-03-21 8:37 ` Sit, Michael Wei Hong
2023-03-21 10:22 ` Russell King (Oracle)
2023-03-21 10:22 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316170127.5bbd559d@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hong.aun.looi@intel.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=peter.jun.ann.lai@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.