From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Ong Boon Leong <boon.leong.ong@intel.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Looi Hong Aun <hong.aun.looi@intel.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Lai Peter Jun Ann <peter.jun.ann.lai@intel.com>
Subject: Re: [PATCH net v2 1/2] net: stmmac: fix PHY handle parsing
Date: Fri, 17 Mar 2023 20:57:48 +0000 [thread overview]
Message-ID: <ZBTUTD6RL22pdlmq@shell.armlinux.org.uk> (raw)
In-Reply-To: <10aff941-e18a-4d77-974b-1760529988a6@lunn.ch>
On Fri, Mar 17, 2023 at 08:56:19PM +0100, Andrew Lunn wrote:
> On Tue, Mar 14, 2023 at 03:02:07PM +0800, Michael Sit Wei Hong wrote:
> > phylink_fwnode_phy_connect returns 0 when set to MLO_AN_INBAND.
> > This causes the PHY handle parsing to skip and the PHY will not be attached
> > to the MAC.
>
> Please could you expand the commit message because i'm having trouble
> following this.
>
> phylink_fwnode_phy_connect() says:
>
> /* Fixed links and 802.3z are handled without needing a PHY */
> if (pl->cfg_link_an_mode == MLO_AN_FIXED ||
> (pl->cfg_link_an_mode == MLO_AN_INBAND &&
> phy_interface_mode_is_8023z(pl->link_interface)))
> return 0;
>
> So your first statement is not true. It should be MLO_AN_INBAND
> and phy_interface_mode_is_8023z.
>
> > Add additional check for PHY handle parsing when set to MLO_AN_INBAND.
>
> Looking at the patch, there is no reference to MLO_AN_INBAND, or
> managed = "in-band-status";
That's the pesky "xpcs_an_inband" which ends up as phylink's
"ovr_an_inband"... I'm sure these are random renames of stuff to make
sure that people struggle to follow the code.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Ong Boon Leong <boon.leong.ong@intel.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Looi Hong Aun <hong.aun.looi@intel.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Lai Peter Jun Ann <peter.jun.ann.lai@intel.com>
Subject: Re: [PATCH net v2 1/2] net: stmmac: fix PHY handle parsing
Date: Fri, 17 Mar 2023 20:57:48 +0000 [thread overview]
Message-ID: <ZBTUTD6RL22pdlmq@shell.armlinux.org.uk> (raw)
In-Reply-To: <10aff941-e18a-4d77-974b-1760529988a6@lunn.ch>
On Fri, Mar 17, 2023 at 08:56:19PM +0100, Andrew Lunn wrote:
> On Tue, Mar 14, 2023 at 03:02:07PM +0800, Michael Sit Wei Hong wrote:
> > phylink_fwnode_phy_connect returns 0 when set to MLO_AN_INBAND.
> > This causes the PHY handle parsing to skip and the PHY will not be attached
> > to the MAC.
>
> Please could you expand the commit message because i'm having trouble
> following this.
>
> phylink_fwnode_phy_connect() says:
>
> /* Fixed links and 802.3z are handled without needing a PHY */
> if (pl->cfg_link_an_mode == MLO_AN_FIXED ||
> (pl->cfg_link_an_mode == MLO_AN_INBAND &&
> phy_interface_mode_is_8023z(pl->link_interface)))
> return 0;
>
> So your first statement is not true. It should be MLO_AN_INBAND
> and phy_interface_mode_is_8023z.
>
> > Add additional check for PHY handle parsing when set to MLO_AN_INBAND.
>
> Looking at the patch, there is no reference to MLO_AN_INBAND, or
> managed = "in-band-status";
That's the pesky "xpcs_an_inband" which ends up as phylink's
"ovr_an_inband"... I'm sure these are random renames of stuff to make
sure that people struggle to follow the code.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-03-17 20:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 7:02 [PATCH net v2 0/2] Fix PHY handle no longer parsing Michael Sit Wei Hong
2023-03-14 7:02 ` Michael Sit Wei Hong
2023-03-14 7:02 ` [PATCH net v2 1/2] net: stmmac: fix PHY handle parsing Michael Sit Wei Hong
2023-03-14 7:02 ` Michael Sit Wei Hong
2023-03-14 9:56 ` Fabian Bläse
2023-03-17 0:00 ` Jakub Kicinski
2023-03-17 0:00 ` Jakub Kicinski
2023-03-17 2:10 ` Sit, Michael Wei Hong
2023-03-17 2:10 ` Sit, Michael Wei Hong
2023-03-17 19:56 ` Andrew Lunn
2023-03-17 19:56 ` Andrew Lunn
2023-03-17 20:57 ` Russell King (Oracle) [this message]
2023-03-17 20:57 ` Russell King (Oracle)
2023-03-21 8:34 ` Sit, Michael Wei Hong
2023-03-21 8:34 ` Sit, Michael Wei Hong
2023-03-21 10:24 ` Russell King (Oracle)
2023-03-21 10:24 ` Russell King (Oracle)
2023-03-14 7:02 ` [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup code Michael Sit Wei Hong
2023-03-14 7:02 ` Michael Sit Wei Hong
2023-03-14 9:56 ` Fabian Bläse
2023-03-17 0:01 ` Jakub Kicinski
2023-03-17 0:01 ` Jakub Kicinski
2023-03-17 20:02 ` Andrew Lunn
2023-03-17 20:02 ` Andrew Lunn
2023-03-21 10:17 ` Sit, Michael Wei Hong
2023-03-21 10:17 ` Sit, Michael Wei Hong
2023-03-17 20:54 ` [PATCH net v2 0/2] Fix PHY handle no longer parsing Russell King (Oracle)
2023-03-17 20:54 ` Russell King (Oracle)
2023-03-21 8:37 ` Sit, Michael Wei Hong
2023-03-21 8:37 ` Sit, Michael Wei Hong
2023-03-21 10:22 ` Russell King (Oracle)
2023-03-21 10:22 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBTUTD6RL22pdlmq@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hong.aun.looi@intel.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=peter.jun.ann.lai@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.