All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Eli Cohen <elic@nvidia.com>, Shay Drory <shayd@nvidia.com>
Subject: [net-next 11/14] net/mlx5: Move devlink registration before mlx5_load
Date: Mon, 20 Mar 2023 10:51:41 -0700	[thread overview]
Message-ID: <20230320175144.153187-12-saeed@kernel.org> (raw)
In-Reply-To: <20230320175144.153187-1-saeed@kernel.org>

From: Eli Cohen <elic@nvidia.com>

In order to allow reference to devlink parameters during driver load,
move the devlink registration before mlx5_load. Subsequent patch will
use it to control the number of completion vectors required based on
whether eth is enabled or not.

Signed-off-by: Eli Cohen <elic@nvidia.com>
Reviewed-by: Shay Drory <shayd@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/main.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index bbc9b4188212..fb9ac7da6e4c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -1399,16 +1399,16 @@ int mlx5_init_one(struct mlx5_core_dev *dev)
 		goto function_teardown;
 	}
 
+	err = mlx5_devlink_params_register(priv_to_devlink(dev));
+	if (err)
+		goto err_devlink_params_reg;
+
 	err = mlx5_load(dev);
 	if (err)
 		goto err_load;
 
 	set_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
 
-	err = mlx5_devlink_params_register(priv_to_devlink(dev));
-	if (err)
-		goto err_devlink_params_reg;
-
 	err = mlx5_register_device(dev);
 	if (err)
 		goto err_register;
@@ -1418,11 +1418,11 @@ int mlx5_init_one(struct mlx5_core_dev *dev)
 	return 0;
 
 err_register:
-	mlx5_devlink_params_unregister(priv_to_devlink(dev));
-err_devlink_params_reg:
 	clear_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
 	mlx5_unload(dev);
 err_load:
+	mlx5_devlink_params_unregister(priv_to_devlink(dev));
+err_devlink_params_reg:
 	mlx5_cleanup_once(dev);
 function_teardown:
 	mlx5_function_teardown(dev, true);
@@ -1441,7 +1441,6 @@ void mlx5_uninit_one(struct mlx5_core_dev *dev)
 	mutex_lock(&dev->intf_state_mutex);
 
 	mlx5_unregister_device(dev);
-	mlx5_devlink_params_unregister(priv_to_devlink(dev));
 
 	if (!test_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state)) {
 		mlx5_core_warn(dev, "%s: interface is down, NOP\n",
@@ -1452,6 +1451,7 @@ void mlx5_uninit_one(struct mlx5_core_dev *dev)
 
 	clear_bit(MLX5_INTERFACE_STATE_UP, &dev->intf_state);
 	mlx5_unload(dev);
+	mlx5_devlink_params_unregister(priv_to_devlink(dev));
 	mlx5_cleanup_once(dev);
 	mlx5_function_teardown(dev, true);
 out:
-- 
2.39.2


  parent reply	other threads:[~2023-03-20 18:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 17:51 [pull request][net-next 00/14] mlx5 updates 2023-03-20 Saeed Mahameed
2023-03-20 17:51 ` [net-next 01/14] lib: cpu_rmap: Avoid use after free on rmap->obj array entries Saeed Mahameed
2023-03-22  3:38   ` Jakub Kicinski
2023-03-22  9:43     ` Eli Cohen
2023-03-20 17:51 ` [net-next 02/14] lib: cpu_rmap: Use allocator for rmap entries Saeed Mahameed
2023-03-22  3:40   ` Jakub Kicinski
2023-03-22  3:50     ` Jakub Kicinski
2023-03-22 10:01       ` Eli Cohen
2023-03-22 10:01     ` Eli Cohen
2023-03-20 17:51 ` [net-next 03/14] lib: cpu_rmap: Add irq_cpu_rmap_remove to complement irq_cpu_rmap_add Saeed Mahameed
2023-03-22  3:46   ` Jakub Kicinski
2023-03-22 11:24     ` Eli Cohen
2023-03-22 18:45       ` Jakub Kicinski
2023-03-20 17:51 ` [net-next 04/14] net/mlx5e: Coding style fix, add empty line Saeed Mahameed
2023-03-20 17:51 ` [net-next 05/14] net/mlx5: Fix wrong comment Saeed Mahameed
2023-03-20 17:51 ` [net-next 06/14] net/mlx5: Modify struct mlx5_irq to use struct msi_map Saeed Mahameed
2023-03-20 17:51 ` [net-next 07/14] net/mlx5: Use newer affinity descriptor Saeed Mahameed
2023-03-20 17:51 ` [net-next 08/14] net/mlx5: Improve naming of pci function vectors Saeed Mahameed
2023-03-20 17:51 ` [net-next 09/14] net/mlx5: Refactor completion irq request/release code Saeed Mahameed
2023-03-20 17:51 ` [net-next 10/14] net/mlx5: Use dynamic msix vectors allocation Saeed Mahameed
2023-03-20 17:51 ` Saeed Mahameed [this message]
2023-03-20 17:51 ` [net-next 12/14] net/mlx5: Refactor calculation of required completion vectors Saeed Mahameed
2023-03-20 17:51 ` [net-next 13/14] net/mlx5: Use one completion vector if eth is disabled Saeed Mahameed
2023-03-20 17:51 ` [net-next 14/14] net/mlx5: Provide external API for allocating vectors Saeed Mahameed
2023-03-22  3:49 ` [pull request][net-next 00/14] mlx5 updates 2023-03-20 Jakub Kicinski
2023-03-22 20:24 ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230320175144.153187-12-saeed@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elic@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=shayd@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.