From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH v2 5/7] transport-ccw: Refer to the vq by its number
Date: Tue, 21 Mar 2023 06:10:34 +0200 [thread overview]
Message-ID: <20230321041036.201439-6-parav@nvidia.com> (raw)
In-Reply-To: <20230321041036.201439-1-parav@nvidia.com>
Currently specification uses virtqueue index and
number interchangeably to refer to the virtqueue.
Instead refer to it by its number.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v0->v1:
- new patch
---
transport-ccw.tex | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/transport-ccw.tex b/transport-ccw.tex
index c2e60b6..b8ba0b7 100644
--- a/transport-ccw.tex
+++ b/transport-ccw.tex
@@ -236,12 +236,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\begin{lstlisting}
struct vq_config_block {
- be16 index;
+ be16 queue_select;
be16 max_queue_size;
};
\end{lstlisting}
-The requested number of buffers for queue \field{index} is returned in
+The requested number of buffers for queue \field{queue_select} is returned in
\field{max_queue_size}.
\begin{note}
@@ -256,7 +256,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
struct vq_info_block {
be64 desc;
be32 res0;
- be16 index;
+ be16 queue_select;
be16 size;
be64 driver;
be64 device;
@@ -265,7 +265,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\field{desc}, \field{driver} and \field{device} contain the guest
addresses for the descriptor area,
-available area and used area for queue \field{index}, respectively. The actual
+available area and used area for queue number \field{queue_select}, respectively. The actual
virtqueue size (number of allocated buffers) is transmitted in
\field{size}.
@@ -286,12 +286,13 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
struct vq_info_block_legacy {
be64 queue;
be32 align;
- be16 index;
+ be16 queue_select;
be16 size;
};
\end{lstlisting}
-\field{queue} contains the guest address for queue \field{index},
+\field{queue} contains the guest address for queue number
+\field{queue_select},
\field{size} the number of buffers
and \field{align} the alignment. The queue layout follows \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}.
@@ -583,7 +584,7 @@ \subsubsection{Guest->Host Notification}\label{sec:Virtio Transport Options / Vi
For example:
\begin{lstlisting}
info->cookie = do_notify(schid,
- virtqueue_get_queue_index(vq),
+ virtqueue_get_queue_number(vq),
info->cookie);
\end{lstlisting}
\end{note}
--
2.26.2
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
<pasic@linux.ibm.com>, <cohuck@redhat.com>
Cc: <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH v2 5/7] transport-ccw: Refer to the vq by its number
Date: Tue, 21 Mar 2023 06:10:34 +0200 [thread overview]
Message-ID: <20230321041036.201439-6-parav@nvidia.com> (raw)
In-Reply-To: <20230321041036.201439-1-parav@nvidia.com>
Currently specification uses virtqueue index and
number interchangeably to refer to the virtqueue.
Instead refer to it by its number.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v0->v1:
- new patch
---
transport-ccw.tex | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/transport-ccw.tex b/transport-ccw.tex
index c2e60b6..b8ba0b7 100644
--- a/transport-ccw.tex
+++ b/transport-ccw.tex
@@ -236,12 +236,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\begin{lstlisting}
struct vq_config_block {
- be16 index;
+ be16 queue_select;
be16 max_queue_size;
};
\end{lstlisting}
-The requested number of buffers for queue \field{index} is returned in
+The requested number of buffers for queue \field{queue_select} is returned in
\field{max_queue_size}.
\begin{note}
@@ -256,7 +256,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
struct vq_info_block {
be64 desc;
be32 res0;
- be16 index;
+ be16 queue_select;
be16 size;
be64 driver;
be64 device;
@@ -265,7 +265,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
\field{desc}, \field{driver} and \field{device} contain the guest
addresses for the descriptor area,
-available area and used area for queue \field{index}, respectively. The actual
+available area and used area for queue number \field{queue_select}, respectively. The actual
virtqueue size (number of allocated buffers) is transmitted in
\field{size}.
@@ -286,12 +286,13 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir
struct vq_info_block_legacy {
be64 queue;
be32 align;
- be16 index;
+ be16 queue_select;
be16 size;
};
\end{lstlisting}
-\field{queue} contains the guest address for queue \field{index},
+\field{queue} contains the guest address for queue number
+\field{queue_select},
\field{size} the number of buffers
and \field{align} the alignment. The queue layout follows \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}.
@@ -583,7 +584,7 @@ \subsubsection{Guest->Host Notification}\label{sec:Virtio Transport Options / Vi
For example:
\begin{lstlisting}
info->cookie = do_notify(schid,
- virtqueue_get_queue_index(vq),
+ virtqueue_get_queue_number(vq),
info->cookie);
\end{lstlisting}
\end{note}
--
2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-21 4:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 4:10 [virtio-comment] [PATCH v2 0/7] Rename queue index to queue number Parav Pandit
2023-03-21 4:10 ` [virtio-dev] " Parav Pandit
2023-03-21 4:10 ` [virtio-comment] [PATCH v2 1/7] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-21 4:10 ` [virtio-dev] " Parav Pandit
2023-03-21 9:01 ` [virtio-comment] " Michael S. Tsirkin
2023-03-21 9:01 ` [virtio-dev] " Michael S. Tsirkin
2023-03-21 20:43 ` Parav Pandit
2023-03-21 20:43 ` [virtio-dev] " Parav Pandit
2023-03-21 4:10 ` [virtio-comment] [PATCH v2 2/7] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-21 4:10 ` [virtio-dev] " Parav Pandit
2023-03-21 4:10 ` [virtio-comment] [PATCH v2 3/7] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-21 4:10 ` [virtio-dev] " Parav Pandit
2023-03-21 4:10 ` [virtio-comment] [PATCH v2 4/7] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-21 4:10 ` [virtio-dev] " Parav Pandit
2023-03-21 4:10 ` Parav Pandit [this message]
2023-03-21 4:10 ` [virtio-dev] [PATCH v2 5/7] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-21 8:46 ` [virtio-comment] " Michael S. Tsirkin
2023-03-21 8:46 ` [virtio-dev] " Michael S. Tsirkin
2023-03-21 4:10 ` [virtio-comment] [PATCH v2 6/7] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-21 4:10 ` [virtio-dev] " Parav Pandit
2023-03-21 4:10 ` [virtio-comment] [PATCH v2 7/7] virtio-net: Describe RSS using receive queue handle Parav Pandit
2023-03-21 4:10 ` [virtio-dev] " Parav Pandit
2023-03-21 8:55 ` [virtio-comment] " Michael S. Tsirkin
2023-03-21 8:55 ` [virtio-dev] " Michael S. Tsirkin
2023-03-21 20:54 ` [virtio-comment] " Parav Pandit
2023-03-21 20:54 ` [virtio-dev] " Parav Pandit
2023-03-21 21:15 ` [virtio-comment] " Parav Pandit
2023-03-21 21:15 ` [virtio-dev] " Parav Pandit
2023-03-21 9:05 ` [virtio-comment] Re: [PATCH v2 0/7] Rename queue index to queue number Michael S. Tsirkin
2023-03-21 9:05 ` [virtio-dev] " Michael S. Tsirkin
2023-03-21 20:57 ` [virtio-comment] " Parav Pandit
2023-03-21 20:57 ` [virtio-dev] " Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321041036.201439-6-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.