From: Maxime Ripard <maxime@cerno.tech>
To: Roman Beranek <romanberanek@icloud.com>
Cc: Chen-Yu Tsai <wens@csie.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG
Date: Tue, 21 Mar 2023 15:56:46 +0100 [thread overview]
Message-ID: <20230321145646.w6kr7ddurfxpg5rt@houat> (raw)
In-Reply-To: <20230320161636.24411-1-romanberanek@icloud.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
Hi,
On Mon, Mar 20, 2023 at 05:16:36PM +0100, Roman Beranek wrote:
> In the case of DSI output, the value of SUN4I_TCON0_DCLK_DIV (4) does
> not represent the actual dotclock divider, PLL_MIPI instead runs at
> (bpp / lanes )-multiple [1] of the dotclock. [2] Setting 4 as dotclock
> divder thus leads to reduced frame rate, specifically by 1/3 on 4-lane
> panels, and by 2/3 on 2-lane panels respectively.
>
> As sun4i_dotclock driver stores its calculated divider directly in
> the register, conditional handling of the DSI output scenario is needed.
> Instead of reading the divider from SUN4I_TCON0_DCLK_REG, retrieve
> the value from tcon->dclk_min_div.
>
> [1] bits per pixel / number of DSI lanes
> [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp-4.4/blob/66bef0f2f30b367eb93b1cbad21ce85e0361f7ae/linux-sunxi/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_sun50iw1/disp_al.c#L322
>
> Signed-off-by: Roman Beranek <romanberanek@icloud.com>
This is similar to
https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/
What's the story there? Also, how was it tested/confirmed?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Roman Beranek <romanberanek@icloud.com>
Cc: Chen-Yu Tsai <wens@csie.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG
Date: Tue, 21 Mar 2023 15:56:46 +0100 [thread overview]
Message-ID: <20230321145646.w6kr7ddurfxpg5rt@houat> (raw)
In-Reply-To: <20230320161636.24411-1-romanberanek@icloud.com>
[-- Attachment #1.1: Type: text/plain, Size: 1135 bytes --]
Hi,
On Mon, Mar 20, 2023 at 05:16:36PM +0100, Roman Beranek wrote:
> In the case of DSI output, the value of SUN4I_TCON0_DCLK_DIV (4) does
> not represent the actual dotclock divider, PLL_MIPI instead runs at
> (bpp / lanes )-multiple [1] of the dotclock. [2] Setting 4 as dotclock
> divder thus leads to reduced frame rate, specifically by 1/3 on 4-lane
> panels, and by 2/3 on 2-lane panels respectively.
>
> As sun4i_dotclock driver stores its calculated divider directly in
> the register, conditional handling of the DSI output scenario is needed.
> Instead of reading the divider from SUN4I_TCON0_DCLK_REG, retrieve
> the value from tcon->dclk_min_div.
>
> [1] bits per pixel / number of DSI lanes
> [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp-4.4/blob/66bef0f2f30b367eb93b1cbad21ce85e0361f7ae/linux-sunxi/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_sun50iw1/disp_al.c#L322
>
> Signed-off-by: Roman Beranek <romanberanek@icloud.com>
This is similar to
https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/
What's the story there? Also, how was it tested/confirmed?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Roman Beranek <romanberanek@icloud.com>
Cc: Samuel Holland <samuel@sholland.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-sunxi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG
Date: Tue, 21 Mar 2023 15:56:46 +0100 [thread overview]
Message-ID: <20230321145646.w6kr7ddurfxpg5rt@houat> (raw)
In-Reply-To: <20230320161636.24411-1-romanberanek@icloud.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
Hi,
On Mon, Mar 20, 2023 at 05:16:36PM +0100, Roman Beranek wrote:
> In the case of DSI output, the value of SUN4I_TCON0_DCLK_DIV (4) does
> not represent the actual dotclock divider, PLL_MIPI instead runs at
> (bpp / lanes )-multiple [1] of the dotclock. [2] Setting 4 as dotclock
> divder thus leads to reduced frame rate, specifically by 1/3 on 4-lane
> panels, and by 2/3 on 2-lane panels respectively.
>
> As sun4i_dotclock driver stores its calculated divider directly in
> the register, conditional handling of the DSI output scenario is needed.
> Instead of reading the divider from SUN4I_TCON0_DCLK_REG, retrieve
> the value from tcon->dclk_min_div.
>
> [1] bits per pixel / number of DSI lanes
> [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp-4.4/blob/66bef0f2f30b367eb93b1cbad21ce85e0361f7ae/linux-sunxi/drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_sun50iw1/disp_al.c#L322
>
> Signed-off-by: Roman Beranek <romanberanek@icloud.com>
This is similar to
https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/
What's the story there? Also, how was it tested/confirmed?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-03-21 14:56 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:16 [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG Roman Beranek
2023-03-20 16:16 ` Roman Beranek
2023-03-20 16:16 ` Roman Beranek
2023-03-21 14:56 ` Maxime Ripard [this message]
2023-03-21 14:56 ` Maxime Ripard
2023-03-21 14:56 ` Maxime Ripard
2023-03-21 16:50 ` Roman Beranek
2023-03-21 16:50 ` Roman Beranek
2023-03-21 16:50 ` Roman Beranek
2023-03-21 20:53 ` Roman Beranek
2023-03-21 20:53 ` Roman Beranek
2023-03-21 20:53 ` Roman Beranek
2023-03-27 20:21 ` Maxime Ripard
2023-03-27 20:21 ` Maxime Ripard
2023-03-27 20:21 ` Maxime Ripard
2023-03-25 11:40 ` Frank Oltmanns
2023-03-25 11:40 ` Frank Oltmanns
2023-03-25 11:40 ` Frank Oltmanns
2023-03-27 20:20 ` Maxime Ripard
2023-03-27 20:20 ` Maxime Ripard
2023-03-27 20:20 ` Maxime Ripard
2023-03-27 23:48 ` Roman Beranek
2023-03-27 23:48 ` Roman Beranek
2023-03-27 23:48 ` Roman Beranek
2023-03-29 19:58 ` Maxime Ripard
2023-03-29 19:58 ` Maxime Ripard
2023-03-29 19:58 ` Maxime Ripard
2023-03-30 4:45 ` Frank Oltmanns
2023-03-30 4:45 ` Frank Oltmanns
2023-03-30 4:45 ` Frank Oltmanns
2023-03-31 5:36 ` Roman Beranek
2023-03-31 5:36 ` Roman Beranek
2023-03-31 5:36 ` Roman Beranek
2023-04-05 12:34 ` Roman Beranek
2023-04-05 12:34 ` Roman Beranek
2023-04-05 12:34 ` Roman Beranek
2023-04-05 15:03 ` Maxime Ripard
2023-04-05 15:03 ` Maxime Ripard
2023-04-05 15:03 ` Maxime Ripard
2023-04-12 7:14 ` Roman Beranek
2023-04-12 7:14 ` Roman Beranek
2023-04-12 7:14 ` Roman Beranek
2023-04-12 14:09 ` Maxime Ripard
2023-04-12 14:09 ` Maxime Ripard
2023-04-12 14:09 ` Maxime Ripard
2023-04-08 7:07 ` Jernej Škrabec
2023-04-08 7:07 ` Jernej Škrabec
2023-04-08 7:07 ` Jernej Škrabec
2023-04-12 1:22 ` Roman Beranek
2023-04-12 1:22 ` Roman Beranek
2023-04-12 1:22 ` Roman Beranek
2023-03-28 19:28 ` Frank Oltmanns
2023-03-28 19:28 ` Frank Oltmanns
2023-03-28 19:28 ` Frank Oltmanns
2023-03-29 19:56 ` Maxime Ripard
2023-03-29 19:56 ` Maxime Ripard
2023-03-29 19:56 ` Maxime Ripard
2023-03-30 4:41 ` Frank Oltmanns
2023-03-30 4:41 ` Frank Oltmanns
2023-03-30 4:41 ` Frank Oltmanns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321145646.w6kr7ddurfxpg5rt@houat \
--to=maxime@cerno.tech \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=romanberanek@icloud.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.