From: "Øystein Walle" <oystwa@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, phillip.wood123@gmail.com, peff@peff.net,
oystwa@gmail.com
Subject: [PATCH v2 1/2] ref-filter: remove unused ref_format member
Date: Thu, 6 Apr 2023 19:08:36 +0200 [thread overview]
Message-ID: <20230406170837.10060-2-oystwa@gmail.com> (raw)
In-Reply-To: <20230406170837.10060-1-oystwa@gmail.com>
use_rest was added in b9dee075eb (ref-filter: add %(rest) atom,
2021-07-26) but was never used. A follow-up patch series[1] that used
this member was submitted, but ultimately the development was abandonded
due to performance problems.
[1]: https://lore.kernel.org/git/9c5fddf6885875ccd3ce3f047bb938c77d9bbca2.1628842990.git.gitgitgadget@gmail.com/
Signed-off-by: Øystein Walle <oystwa@gmail.com>
---
ref-filter.h | 1 -
ref-filter.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/ref-filter.h b/ref-filter.h
index daa6d02017..e3eea5e3ad 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -75,7 +75,6 @@ struct ref_format {
const char *format;
const char *rest;
int quote_style;
- int use_rest;
int use_color;
/* Internal state to ref-filter */
diff --git a/ref-filter.c b/ref-filter.c
index ed802778da..20e0a72f24 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -596,7 +596,6 @@ static int rest_atom_parser(struct ref_format *format,
{
if (arg)
return err_no_arg(err, "rest");
- format->use_rest = 1;
return 0;
}
--
2.20.1
next prev parent reply other threads:[~2023-04-06 17:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:21 [PATCH 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-03-30 11:21 ` [PATCH 1/2] ref-filter: remove unused ref_format member Øystein Walle
2023-03-30 15:21 ` Junio C Hamano
2023-03-30 15:25 ` Junio C Hamano
2023-03-31 10:37 ` Øystein Walle
2023-03-31 10:57 ` ZheNing Hu
2023-03-31 16:19 ` Junio C Hamano
2023-04-06 17:08 ` [PATCH v2 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-04-06 17:08 ` Øystein Walle [this message]
2023-04-06 17:08 ` [PATCH v2 2/2] " Øystein Walle
2023-04-06 18:24 ` [PATCH v2 0/2] " Junio C Hamano
2023-04-07 17:53 ` [PATCH v3] branch, for-each-ref, tag: " Øystein Walle
2023-04-07 18:48 ` Junio C Hamano
2023-04-12 23:44 ` Andrei Rybak
2023-04-13 7:17 ` Øystein Walle
2023-04-13 15:13 ` Junio C Hamano
2023-03-30 11:21 ` [PATCH 2/2] branch, for-each-ref: " Øystein Walle
2023-03-30 15:54 ` Junio C Hamano
2023-03-30 18:25 ` Jeff King
2023-03-30 18:54 ` Junio C Hamano
2023-03-31 8:32 ` Øystein Walle
2023-03-31 15:57 ` Junio C Hamano
2023-03-30 17:21 ` Junio C Hamano
2023-03-31 16:33 ` Phillip Wood
2023-03-31 17:17 ` Junio C Hamano
2023-04-06 16:55 ` Øystein Walle
2023-04-06 17:12 ` Jeff King
2023-04-06 18:20 ` Junio C Hamano
2023-04-10 19:56 ` Jeff King
2023-04-06 18:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406170837.10060-2-oystwa@gmail.com \
--to=oystwa@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.