From: Junio C Hamano <gitster@pobox.com>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] branch, for-each-ref: add option to omit empty lines
Date: Thu, 30 Mar 2023 10:21:19 -0700 [thread overview]
Message-ID: <xmqq355m17g0.fsf@gitster.g> (raw)
In-Reply-To: 20230330112133.4437-3-oystwa@gmail.com
Øystein Walle <oystwa@gmail.com> writes:
> The logic is more or less duplicated in branch.c and for-each-ref.c
> which I don't like. However I couldn't really find a "central" place to
> put it. Imo. it's definitely not a property of the format or the filter,
> so struct ref_format and struct ref_filter are no good.
I think the division of labor is very much in line with how the
ref-filter API is currently laid out. Enumerating is done calling
filter_refs(), and result is returned in an array, which the caller
adds whatever frills around its elements to show them in the output.
The "adding frills" is aided by calling format_ref_array_item(), but
the API does not care how the formatting result is used.
next prev parent reply other threads:[~2023-03-30 17:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:21 [PATCH 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-03-30 11:21 ` [PATCH 1/2] ref-filter: remove unused ref_format member Øystein Walle
2023-03-30 15:21 ` Junio C Hamano
2023-03-30 15:25 ` Junio C Hamano
2023-03-31 10:37 ` Øystein Walle
2023-03-31 10:57 ` ZheNing Hu
2023-03-31 16:19 ` Junio C Hamano
2023-04-06 17:08 ` [PATCH v2 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-04-06 17:08 ` [PATCH v2 1/2] ref-filter: remove unused ref_format member Øystein Walle
2023-04-06 17:08 ` [PATCH v2 2/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-04-06 18:24 ` [PATCH v2 0/2] " Junio C Hamano
2023-04-07 17:53 ` [PATCH v3] branch, for-each-ref, tag: " Øystein Walle
2023-04-07 18:48 ` Junio C Hamano
2023-04-12 23:44 ` Andrei Rybak
2023-04-13 7:17 ` Øystein Walle
2023-04-13 15:13 ` Junio C Hamano
2023-03-30 11:21 ` [PATCH 2/2] branch, for-each-ref: " Øystein Walle
2023-03-30 15:54 ` Junio C Hamano
2023-03-30 18:25 ` Jeff King
2023-03-30 18:54 ` Junio C Hamano
2023-03-31 8:32 ` Øystein Walle
2023-03-31 15:57 ` Junio C Hamano
2023-03-30 17:21 ` Junio C Hamano [this message]
2023-03-31 16:33 ` Phillip Wood
2023-03-31 17:17 ` Junio C Hamano
2023-04-06 16:55 ` Øystein Walle
2023-04-06 17:12 ` Jeff King
2023-04-06 18:20 ` Junio C Hamano
2023-04-10 19:56 ` Jeff King
2023-04-06 18:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq355m17g0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.