From: Junio C Hamano <gitster@pobox.com>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] branch, for-each-ref: add option to omit empty lines
Date: Thu, 06 Apr 2023 11:07:12 -0700 [thread overview]
Message-ID: <xmqqv8i8q3zj.fsf@gitster.g> (raw)
In-Reply-To: <CAFaJEqtxNa+fuuKzkKPLkF3qdYwZUj+tMKXB3u2ok6H008vjHA@mail.gmail.com> ("Øystein Walle"'s message of "Thu, 6 Apr 2023 18:55:52 +0200")
Øystein Walle <oystwa@gmail.com> writes:
>> It however theoretically can break an existing use case where the
>> user correlates the output with a list of refs they externally
>> prepared (e.g. "for-each-ref --format... a b c" shows "A", "", and
>> "C", and the user knows "b" produced ""). I do not know how likely
>> such users complain, though, and if there is nobody who relies on
>> the current behaviour, surely "unconditionally omit" is a very
>> tempting approach to take.
>>
>> Thanks.
>
> I actually instinctively expected for-each-ref to suppress empty lines, at
> least by default. I don't see a good reason for them, except for something
> along the lines of what you said.
That makes two of us ;-)
> We can of course make it a config option along with the flag, then after some
> time flip the default, and perhaps ultimately remove the config option again.
Yeah, but this v2 is not starting with purely a new feature without
breaking anybody, so we can stop here for now, and once there is
enough interest to go through the deprecation dance, we can do that
as a separate series later.
Thanks.
prev parent reply other threads:[~2023-04-06 18:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:21 [PATCH 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-03-30 11:21 ` [PATCH 1/2] ref-filter: remove unused ref_format member Øystein Walle
2023-03-30 15:21 ` Junio C Hamano
2023-03-30 15:25 ` Junio C Hamano
2023-03-31 10:37 ` Øystein Walle
2023-03-31 10:57 ` ZheNing Hu
2023-03-31 16:19 ` Junio C Hamano
2023-04-06 17:08 ` [PATCH v2 0/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-04-06 17:08 ` [PATCH v2 1/2] ref-filter: remove unused ref_format member Øystein Walle
2023-04-06 17:08 ` [PATCH v2 2/2] branch, for-each-ref: add option to omit empty lines Øystein Walle
2023-04-06 18:24 ` [PATCH v2 0/2] " Junio C Hamano
2023-04-07 17:53 ` [PATCH v3] branch, for-each-ref, tag: " Øystein Walle
2023-04-07 18:48 ` Junio C Hamano
2023-04-12 23:44 ` Andrei Rybak
2023-04-13 7:17 ` Øystein Walle
2023-04-13 15:13 ` Junio C Hamano
2023-03-30 11:21 ` [PATCH 2/2] branch, for-each-ref: " Øystein Walle
2023-03-30 15:54 ` Junio C Hamano
2023-03-30 18:25 ` Jeff King
2023-03-30 18:54 ` Junio C Hamano
2023-03-31 8:32 ` Øystein Walle
2023-03-31 15:57 ` Junio C Hamano
2023-03-30 17:21 ` Junio C Hamano
2023-03-31 16:33 ` Phillip Wood
2023-03-31 17:17 ` Junio C Hamano
2023-04-06 16:55 ` Øystein Walle
2023-04-06 17:12 ` Jeff King
2023-04-06 18:20 ` Junio C Hamano
2023-04-10 19:56 ` Jeff King
2023-04-06 18:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8i8q3zj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.