From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, Kurt Kanzenbach <kurt@linutronix.de>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>,
intel-wired-lan@lists.osuosl.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next] igc: Avoid transmit queue timeout for XDP
Date: Thu, 13 Apr 2023 09:03:44 -0700 [thread overview]
Message-ID: <20230413090344.20796001@kernel.org> (raw)
In-Reply-To: <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com>
On Wed, 12 Apr 2023 15:30:38 -0700 Jacob Keller wrote:
> Is most driver's XDP implementation broken? There's also
> netif_trans_update but this is called out as a legacy only function. Far
> more drivers call this but I don't see either call or a direct update to
> trans_start in many XDP implementations...
>
> Am I missing something or are a bunch of other XDP implementations also
> wrong?
Only drivers which use the same Tx queues for the stack and XDP need
this.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Kurt Kanzenbach <kurt@linutronix.de>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
"Ong Boon Leong" <boon.leong.ong@intel.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] igc: Avoid transmit queue timeout for XDP
Date: Thu, 13 Apr 2023 09:03:44 -0700 [thread overview]
Message-ID: <20230413090344.20796001@kernel.org> (raw)
In-Reply-To: <1809a34d-dcf4-4b54-089a-a7be3f4c23e1@intel.com>
On Wed, 12 Apr 2023 15:30:38 -0700 Jacob Keller wrote:
> Is most driver's XDP implementation broken? There's also
> netif_trans_update but this is called out as a legacy only function. Far
> more drivers call this but I don't see either call or a direct update to
> trans_start in many XDP implementations...
>
> Am I missing something or are a bunch of other XDP implementations also
> wrong?
Only drivers which use the same Tx queues for the stack and XDP need
this.
next prev parent reply other threads:[~2023-04-13 16:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 7:36 [Intel-wired-lan] [PATCH net-next] igc: Avoid transmit queue timeout for XDP Kurt Kanzenbach
2023-04-12 7:36 ` Kurt Kanzenbach
2023-04-12 22:30 ` [Intel-wired-lan] " Jacob Keller
2023-04-12 22:30 ` Jacob Keller
2023-04-13 7:20 ` [Intel-wired-lan] " Kurt Kanzenbach
2023-04-13 7:20 ` Kurt Kanzenbach
2023-04-13 16:03 ` Jakub Kicinski [this message]
2023-04-13 16:03 ` Jakub Kicinski
2023-04-13 16:39 ` [Intel-wired-lan] " Jacob Keller
2023-04-13 16:39 ` Jacob Keller
2023-04-13 21:19 ` [Intel-wired-lan] " David Laight
2023-04-13 21:19 ` David Laight
2023-05-01 10:01 ` [Intel-wired-lan] " naamax.meir
2023-05-01 10:01 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413090344.20796001@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.