From: Conor Dooley <conor@kernel.org>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH -next v18 07/20] riscv: Introduce riscv_v_vsize to record size of Vector context
Date: Fri, 14 Apr 2023 16:47:13 -0000 [thread overview]
Message-ID: <20230414-kerosene-jackknife-2bf17e228b1d@spud> (raw)
In-Reply-To: <20230414155843.12963-8-andy.chiu@sifive.com>
On Fri, Apr 14, 2023 at 03:58:30PM +0000, Andy Chiu wrote:
> + if (riscv_v_vsize != this_vsize) {
> + WARN(1, "RISCV_ISA_V only supports one vlenb on SMP system");
nit: systems
Clearly I don't expect a resubmission to change that!
You can re-add:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/kvm-riscv/attachments/20230414/356c7c6a/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Andy Chiu <andy.chiu@sifive.com>
Cc: guoren@linux.alibaba.com, kvm@vger.kernel.org,
atishp@atishpatra.org, Conor Dooley <conor.dooley@microchip.com>,
Guo Ren <guoren@kernel.org>, Jisheng Zhang <jszhang@kernel.org>,
linux-riscv@lists.infradead.org,
Xianting Tian <xianting.tian@linux.alibaba.com>,
anup@brainfault.org, Masahiro Yamada <masahiroy@kernel.org>,
greentime.hu@sifive.com, Li Zhengyu <lizhengyu3@huawei.com>,
Andrew Jones <ajones@ventanamicro.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>,
Liao Chang <liaochang1@huawei.com>,
vineetg@rivosinc.com, Philipp Tomsich <philipp.tomsich@vrull.eu>,
Paul Walmsley <paul.walmsley@sifive.com>,
Heiko Stuebner <heiko.stuebner@vrull.eu>,
Vincent Chen <vincent.chen@sifive.com>,
palmer@dabbelt.com, kvm-riscv@lists.infradead.org
Subject: Re: [PATCH -next v18 07/20] riscv: Introduce riscv_v_vsize to record size of Vector context
Date: Fri, 14 Apr 2023 17:47:03 +0100 [thread overview]
Message-ID: <20230414-kerosene-jackknife-2bf17e228b1d@spud> (raw)
In-Reply-To: <20230414155843.12963-8-andy.chiu@sifive.com>
[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]
On Fri, Apr 14, 2023 at 03:58:30PM +0000, Andy Chiu wrote:
> + if (riscv_v_vsize != this_vsize) {
> + WARN(1, "RISCV_ISA_V only supports one vlenb on SMP system");
nit: systems
Clearly I don't expect a resubmission to change that!
You can re-add:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Andy Chiu <andy.chiu@sifive.com>
Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com,
anup@brainfault.org, atishp@atishpatra.org,
kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
vineetg@rivosinc.com, greentime.hu@sifive.com,
guoren@linux.alibaba.com, Vincent Chen <vincent.chen@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
Heiko Stuebner <heiko.stuebner@vrull.eu>,
Li Zhengyu <lizhengyu3@huawei.com>,
Liao Chang <liaochang1@huawei.com>,
Xianting Tian <xianting.tian@linux.alibaba.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Jisheng Zhang <jszhang@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
Andrew Jones <ajones@ventanamicro.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Sunil V L <sunilvl@ventanamicro.com>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>
Subject: Re: [PATCH -next v18 07/20] riscv: Introduce riscv_v_vsize to record size of Vector context
Date: Fri, 14 Apr 2023 17:47:03 +0100 [thread overview]
Message-ID: <20230414-kerosene-jackknife-2bf17e228b1d@spud> (raw)
In-Reply-To: <20230414155843.12963-8-andy.chiu@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
On Fri, Apr 14, 2023 at 03:58:30PM +0000, Andy Chiu wrote:
> + if (riscv_v_vsize != this_vsize) {
> + WARN(1, "RISCV_ISA_V only supports one vlenb on SMP system");
nit: systems
Clearly I don't expect a resubmission to change that!
You can re-add:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-04-14 16:47 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 15:58 [PATCH -next v18 00/20] riscv: Add vector ISA support Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 01/20] riscv: Rename __switch_to_aux() -> fpu Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 02/20] riscv: Extending cpufeature.c to detect V-extension Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 03/20] riscv: Add new csr defines related to vector extension Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 04/20] riscv: Clear vector regfile on bootup Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 05/20] riscv: Disable Vector Instructions for kernel itself Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-17 15:52 ` Heiko Stübner
2023-04-17 15:52 ` Heiko Stübner
2023-04-17 15:52 ` Heiko Stübner
2023-04-14 15:58 ` [PATCH -next v18 06/20] riscv: Introduce Vector enable/disable helpers Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-17 15:55 ` Heiko Stübner
2023-04-17 15:55 ` Heiko Stübner
2023-04-17 15:55 ` Heiko Stübner
2023-04-14 15:58 ` [PATCH -next v18 07/20] riscv: Introduce riscv_v_vsize to record size of Vector context Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 16:47 ` Conor Dooley [this message]
2023-04-14 16:47 ` Conor Dooley
2023-04-14 16:47 ` Conor Dooley
2023-04-17 15:55 ` Heiko Stübner
2023-04-17 15:55 ` Heiko Stübner
2023-04-17 15:55 ` Heiko Stübner
2023-04-14 15:58 ` [PATCH -next v18 08/20] riscv: Introduce struct/helpers to save/restore per-task Vector state Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 09/20] riscv: Add task switch support for vector Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 10/20] riscv: Allocate user's vector context in the first-use trap Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 16:40 ` Conor Dooley
2023-04-14 16:40 ` Conor Dooley
2023-04-14 16:40 ` Conor Dooley
2023-04-14 15:58 ` [PATCH -next v18 11/20] riscv: Add ptrace vector support Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 12/20] riscv: signal: check fp-reserved words unconditionally Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 13/20] riscv: signal: Add sigcontext save/restore for vector Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 14/20] riscv: signal: Report signal frame size to userspace via auxv Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 15/20] riscv: signal: validate altstack to reflect Vector Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 16/20] riscv: prevent stack corruption by reserving task_pt_regs(p) early Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 17/20] riscv: kvm: Add V extension to KVM ISA Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 18/20] riscv: KVM: Add vector lazy save/restore support Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 19/20] riscv: detect assembler support for .option arch Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` [PATCH -next v18 20/20] riscv: Enable Vector code to be built Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-14 15:58 ` Andy Chiu
2023-04-17 15:56 ` [PATCH -next v18 00/20] riscv: Add vector ISA support Ben Dooks
2023-04-17 15:56 ` Ben Dooks
2023-04-17 15:56 ` Ben Dooks
2023-04-17 16:26 ` Andy Chiu
2023-04-17 16:26 ` Andy Chiu
2023-04-17 16:26 ` Andy Chiu
2023-04-19 7:43 ` Björn Töpel
2023-04-19 7:43 ` Björn Töpel
2023-04-19 7:43 ` Björn Töpel
2023-04-19 14:54 ` Björn Töpel
2023-04-19 14:54 ` Björn Töpel
2023-04-19 14:54 ` Björn Töpel
2023-04-19 15:18 ` Palmer Dabbelt
2023-04-19 15:18 ` Palmer Dabbelt
2023-04-19 15:18 ` Palmer Dabbelt
2023-04-20 16:36 ` Andy Chiu
2023-04-20 16:36 ` Andy Chiu
2023-04-20 16:36 ` Andy Chiu
2023-04-26 14:27 ` Palmer Dabbelt
2023-04-26 14:27 ` Palmer Dabbelt
2023-04-26 14:27 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414-kerosene-jackknife-2bf17e228b1d@spud \
--to=conor@kernel.org \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.