From: Mike Kravetz <mike.kravetz@oracle.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-ia64@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] ia64: fix an addr to taddr in huge_pte_offset()
Date: Tue, 18 Apr 2023 20:29:36 +0000 [thread overview]
Message-ID: <20230418202936.GB4907@monkey> (raw)
In-Reply-To: <732eae88-3beb-246-2c72-281de786740@google.com>
On 04/16/23 22:17, Hugh Dickins wrote:
> I know nothing of ia64 htlbpage_to_page(), but guess that the p4d
> line should be using taddr rather than addr, like everywhere else.
>
> Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables")
> Signed-off-by: Hugh Dickins <hughd@google.com
> ---
> Just something noticed when visiting recently in the source:
> thought we might fix it before ia64 is consigned to history;
> I'm unable to say anything about the user-visible effects!
Good eye!
I know as little about ia64 as you. However, that single use of addr
within the routine certainly looks wrong.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> arch/ia64/mm/hugetlbpage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 6.3-rc7/arch/ia64/mm/hugetlbpage.c
> +++ linux/arch/ia64/mm/hugetlbpage.c
> @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz)
>
> pgd = pgd_offset(mm, taddr);
> if (pgd_present(*pgd)) {
> - p4d = p4d_offset(pgd, addr);
> + p4d = p4d_offset(pgd, taddr);
> if (p4d_present(*p4d)) {
> pud = pud_offset(p4d, taddr);
> if (pud_present(*pud)) {
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-ia64@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] ia64: fix an addr to taddr in huge_pte_offset()
Date: Tue, 18 Apr 2023 13:29:36 -0700 [thread overview]
Message-ID: <20230418202936.GB4907@monkey> (raw)
In-Reply-To: <732eae88-3beb-246-2c72-281de786740@google.com>
On 04/16/23 22:17, Hugh Dickins wrote:
> I know nothing of ia64 htlbpage_to_page(), but guess that the p4d
> line should be using taddr rather than addr, like everywhere else.
>
> Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables")
> Signed-off-by: Hugh Dickins <hughd@google.com
> ---
> Just something noticed when visiting recently in the source:
> thought we might fix it before ia64 is consigned to history;
> I'm unable to say anything about the user-visible effects!
Good eye!
I know as little about ia64 as you. However, that single use of addr
within the routine certainly looks wrong.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> arch/ia64/mm/hugetlbpage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 6.3-rc7/arch/ia64/mm/hugetlbpage.c
> +++ linux/arch/ia64/mm/hugetlbpage.c
> @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz)
>
> pgd = pgd_offset(mm, taddr);
> if (pgd_present(*pgd)) {
> - p4d = p4d_offset(pgd, addr);
> + p4d = p4d_offset(pgd, taddr);
> if (p4d_present(*p4d)) {
> pud = pud_offset(p4d, taddr);
> if (pud_present(*pud)) {
next prev parent reply other threads:[~2023-04-18 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 5:17 [PATCH] ia64: fix an addr to taddr in huge_pte_offset() Hugh Dickins
2023-04-17 5:17 ` Hugh Dickins
2023-04-18 20:29 ` Mike Kravetz [this message]
2023-04-18 20:29 ` Mike Kravetz
2023-04-19 9:29 ` Mike Rapoport
2023-04-19 9:29 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418202936.GB4907@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=hughd@google.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.