From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: bhelgaas@google.com, koba.ko@canonical.com,
sathyanarayanan.kuppuswamy@linux.intel.com,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] PCI/AER: Disable AER interrupt on suspend
Date: Thu, 20 Apr 2023 13:50:13 +0300 [thread overview]
Message-ID: <20230420105013.GN66750@black.fi.intel.com> (raw)
In-Reply-To: <20230420015830.309845-3-kai.heng.feng@canonical.com>
On Thu, Apr 20, 2023 at 09:58:29AM +0800, Kai-Heng Feng wrote:
> PCIe service that shares IRQ with PME may cause spurious wakeup on
> system suspend.
>
> PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states
> that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready
> (D3hot), L2 (D3cold with aux power) and L3 (D3cold), so we don't lose
> much here to disable AER during system suspend.
>
> This is very similar to previous attempts to suspend AER and DPC [1],
> but with a different reason.
>
> [1] https://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.feng@canonical.com/
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: sathyanarayanan.kuppuswamy@linux.intel.com,
linux-pci@vger.kernel.org,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
linux-kernel@vger.kernel.org, koba.ko@canonical.com,
Oliver O'Halloran <oohall@gmail.com>,
bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 3/4] PCI/AER: Disable AER interrupt on suspend
Date: Thu, 20 Apr 2023 13:50:13 +0300 [thread overview]
Message-ID: <20230420105013.GN66750@black.fi.intel.com> (raw)
In-Reply-To: <20230420015830.309845-3-kai.heng.feng@canonical.com>
On Thu, Apr 20, 2023 at 09:58:29AM +0800, Kai-Heng Feng wrote:
> PCIe service that shares IRQ with PME may cause spurious wakeup on
> system suspend.
>
> PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states
> that TLP and DLLP transmission is disabled for a Link in L2/L3 Ready
> (D3hot), L2 (D3cold with aux power) and L3 (D3cold), so we don't lose
> much here to disable AER during system suspend.
>
> This is very similar to previous attempts to suspend AER and DPC [1],
> but with a different reason.
>
> [1] https://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.feng@canonical.com/
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2023-04-20 10:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 1:58 [PATCH v2 1/4] PCI: Keep AER status in pci_restore_state() Kai-Heng Feng
2023-04-20 1:58 ` [PATCH v2 2/4] PCI/AER: Factor out interrput toggling into helpers Kai-Heng Feng
2023-04-20 1:58 ` Kai-Heng Feng
2023-04-20 10:47 ` Mika Westerberg
2023-04-20 10:47 ` Mika Westerberg
2023-04-20 1:58 ` [PATCH v2 3/4] PCI/AER: Disable AER interrupt on suspend Kai-Heng Feng
2023-04-20 1:58 ` Kai-Heng Feng
2023-04-20 10:50 ` Mika Westerberg [this message]
2023-04-20 10:50 ` Mika Westerberg
2023-04-20 1:58 ` [PATCH v2 4/4] PCI/DPC: Disable DPC interrupt during suspend Kai-Heng Feng
2023-04-20 1:58 ` Kai-Heng Feng
2023-04-20 10:51 ` Mika Westerberg
2023-04-20 10:51 ` Mika Westerberg
2023-04-20 10:49 ` [PATCH v2 1/4] PCI: Keep AER status in pci_restore_state() Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420105013.GN66750@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.