* [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
@ 2023-05-22 9:21 ` Gao Xiang
0 siblings, 0 replies; 11+ messages in thread
From: Gao Xiang @ 2023-05-22 9:21 UTC (permalink / raw)
To: linux-erofs; +Cc: Gao Xiang, LKML, Sandeep Dhavale
As Sandeep shown [1], high priority RT per-cpu kthreads are
typically helpful for Android scenarios to minimize the scheduling
latencies.
Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
EROFS_FS_PCPU_KTHREAD.
Also clean up unneeded sched_set_normal().
[1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
Cc: Sandeep Dhavale <dhavale@google.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
fs/erofs/Kconfig | 1 +
fs/erofs/zdata.c | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
index 704fb59577e0..f259d92c9720 100644
--- a/fs/erofs/Kconfig
+++ b/fs/erofs/Kconfig
@@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
config EROFS_FS_PCPU_KTHREAD_HIPRI
bool "EROFS high priority per-CPU kthread workers"
depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
+ default y
help
This permits EROFS to configure per-CPU kthread workers to run
at higher priority.
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 92f3a01262cf..3ba505434f03 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu)
return worker;
if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI))
sched_set_fifo_low(worker->task);
- else
- sched_set_normal(worker->task, 0);
return worker;
}
--
2.24.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
@ 2023-05-22 9:21 ` Gao Xiang
0 siblings, 0 replies; 11+ messages in thread
From: Gao Xiang @ 2023-05-22 9:21 UTC (permalink / raw)
To: linux-erofs; +Cc: LKML, Gao Xiang, Sandeep Dhavale
As Sandeep shown [1], high priority RT per-cpu kthreads are
typically helpful for Android scenarios to minimize the scheduling
latencies.
Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
EROFS_FS_PCPU_KTHREAD.
Also clean up unneeded sched_set_normal().
[1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
Cc: Sandeep Dhavale <dhavale@google.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
fs/erofs/Kconfig | 1 +
fs/erofs/zdata.c | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
index 704fb59577e0..f259d92c9720 100644
--- a/fs/erofs/Kconfig
+++ b/fs/erofs/Kconfig
@@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
config EROFS_FS_PCPU_KTHREAD_HIPRI
bool "EROFS high priority per-CPU kthread workers"
depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
+ default y
help
This permits EROFS to configure per-CPU kthread workers to run
at higher priority.
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 92f3a01262cf..3ba505434f03 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu)
return worker;
if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI))
sched_set_fifo_low(worker->task);
- else
- sched_set_normal(worker->task, 0);
return worker;
}
--
2.24.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
2023-05-22 9:21 ` Gao Xiang
@ 2023-05-23 0:52 ` Yue Hu
-1 siblings, 0 replies; 11+ messages in thread
From: Yue Hu @ 2023-05-23 0:52 UTC (permalink / raw)
To: Gao Xiang; +Cc: zhangwen, huyue2, linux-erofs, LKML, Sandeep Dhavale
On Mon, 22 May 2023 17:21:41 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> As Sandeep shown [1], high priority RT per-cpu kthreads are
> typically helpful for Android scenarios to minimize the scheduling
> latencies.
>
> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
> EROFS_FS_PCPU_KTHREAD.
>
> Also clean up unneeded sched_set_normal().
>
> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
> Cc: Sandeep Dhavale <dhavale@google.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> fs/erofs/Kconfig | 1 +
> fs/erofs/zdata.c | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
> index 704fb59577e0..f259d92c9720 100644
> --- a/fs/erofs/Kconfig
> +++ b/fs/erofs/Kconfig
> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
> config EROFS_FS_PCPU_KTHREAD_HIPRI
> bool "EROFS high priority per-CPU kthread workers"
> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
> + default y
How about removing this config option?
> help
> This permits EROFS to configure per-CPU kthread workers to run
> at higher priority.
> diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
> index 92f3a01262cf..3ba505434f03 100644
> --- a/fs/erofs/zdata.c
> +++ b/fs/erofs/zdata.c
> @@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu)
> return worker;
> if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI))
> sched_set_fifo_low(worker->task);
> - else
> - sched_set_normal(worker->task, 0);
> return worker;
> }
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
@ 2023-05-23 0:52 ` Yue Hu
0 siblings, 0 replies; 11+ messages in thread
From: Yue Hu @ 2023-05-23 0:52 UTC (permalink / raw)
To: Gao Xiang; +Cc: linux-erofs, LKML, Sandeep Dhavale, huyue2, zhangwen
On Mon, 22 May 2023 17:21:41 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> As Sandeep shown [1], high priority RT per-cpu kthreads are
> typically helpful for Android scenarios to minimize the scheduling
> latencies.
>
> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
> EROFS_FS_PCPU_KTHREAD.
>
> Also clean up unneeded sched_set_normal().
>
> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
> Cc: Sandeep Dhavale <dhavale@google.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> fs/erofs/Kconfig | 1 +
> fs/erofs/zdata.c | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
> index 704fb59577e0..f259d92c9720 100644
> --- a/fs/erofs/Kconfig
> +++ b/fs/erofs/Kconfig
> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
> config EROFS_FS_PCPU_KTHREAD_HIPRI
> bool "EROFS high priority per-CPU kthread workers"
> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
> + default y
How about removing this config option?
> help
> This permits EROFS to configure per-CPU kthread workers to run
> at higher priority.
> diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
> index 92f3a01262cf..3ba505434f03 100644
> --- a/fs/erofs/zdata.c
> +++ b/fs/erofs/zdata.c
> @@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu)
> return worker;
> if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI))
> sched_set_fifo_low(worker->task);
> - else
> - sched_set_normal(worker->task, 0);
> return worker;
> }
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
2023-05-23 0:52 ` Yue Hu
@ 2023-05-23 1:53 ` Gao Xiang
-1 siblings, 0 replies; 11+ messages in thread
From: Gao Xiang @ 2023-05-23 1:53 UTC (permalink / raw)
To: Yue Hu; +Cc: zhangwen, huyue2, linux-erofs, LKML, Sandeep Dhavale
On 2023/5/23 17:52, Yue Hu wrote:
> On Mon, 22 May 2023 17:21:41 +0800
> Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>
>> As Sandeep shown [1], high priority RT per-cpu kthreads are
>> typically helpful for Android scenarios to minimize the scheduling
>> latencies.
>>
>> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
>> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
>> EROFS_FS_PCPU_KTHREAD.
>>
>> Also clean up unneeded sched_set_normal().
>>
>> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
>> Cc: Sandeep Dhavale <dhavale@google.com>
>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>> ---
>> fs/erofs/Kconfig | 1 +
>> fs/erofs/zdata.c | 2 --
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
>> index 704fb59577e0..f259d92c9720 100644
>> --- a/fs/erofs/Kconfig
>> +++ b/fs/erofs/Kconfig
>> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
>> config EROFS_FS_PCPU_KTHREAD_HIPRI
>> bool "EROFS high priority per-CPU kthread workers"
>> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
>> + default y
>
> How about removing this config option?
I tend to leave it as is.
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
@ 2023-05-23 1:53 ` Gao Xiang
0 siblings, 0 replies; 11+ messages in thread
From: Gao Xiang @ 2023-05-23 1:53 UTC (permalink / raw)
To: Yue Hu; +Cc: linux-erofs, LKML, Sandeep Dhavale, huyue2, zhangwen
On 2023/5/23 17:52, Yue Hu wrote:
> On Mon, 22 May 2023 17:21:41 +0800
> Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>
>> As Sandeep shown [1], high priority RT per-cpu kthreads are
>> typically helpful for Android scenarios to minimize the scheduling
>> latencies.
>>
>> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
>> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
>> EROFS_FS_PCPU_KTHREAD.
>>
>> Also clean up unneeded sched_set_normal().
>>
>> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
>> Cc: Sandeep Dhavale <dhavale@google.com>
>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>> ---
>> fs/erofs/Kconfig | 1 +
>> fs/erofs/zdata.c | 2 --
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
>> index 704fb59577e0..f259d92c9720 100644
>> --- a/fs/erofs/Kconfig
>> +++ b/fs/erofs/Kconfig
>> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
>> config EROFS_FS_PCPU_KTHREAD_HIPRI
>> bool "EROFS high priority per-CPU kthread workers"
>> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
>> + default y
>
> How about removing this config option?
I tend to leave it as is.
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
2023-05-23 1:53 ` Gao Xiang
@ 2023-05-23 2:05 ` Yue Hu
-1 siblings, 0 replies; 11+ messages in thread
From: Yue Hu @ 2023-05-23 2:05 UTC (permalink / raw)
To: Gao Xiang; +Cc: zhangwen, huyue2, linux-erofs, LKML, Sandeep Dhavale
On Tue, 23 May 2023 09:53:06 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> On 2023/5/23 17:52, Yue Hu wrote:
> > On Mon, 22 May 2023 17:21:41 +0800
> > Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> >
> >> As Sandeep shown [1], high priority RT per-cpu kthreads are
> >> typically helpful for Android scenarios to minimize the scheduling
> >> latencies.
> >>
> >> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
> >> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
> >> EROFS_FS_PCPU_KTHREAD.
> >>
> >> Also clean up unneeded sched_set_normal().
> >>
> >> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
> >> Cc: Sandeep Dhavale <dhavale@google.com>
> >> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> >> ---
> >> fs/erofs/Kconfig | 1 +
> >> fs/erofs/zdata.c | 2 --
> >> 2 files changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
> >> index 704fb59577e0..f259d92c9720 100644
> >> --- a/fs/erofs/Kconfig
> >> +++ b/fs/erofs/Kconfig
> >> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
> >> config EROFS_FS_PCPU_KTHREAD_HIPRI
> >> bool "EROFS high priority per-CPU kthread workers"
> >> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
> >> + default y
> >
> > How about removing this config option?
>
> I tend to leave it as is.
Okay.
Reviewed-by: Yue Hu <huyue2@coolpad.com>
>
> Thanks,
> Gao Xiang
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
@ 2023-05-23 2:05 ` Yue Hu
0 siblings, 0 replies; 11+ messages in thread
From: Yue Hu @ 2023-05-23 2:05 UTC (permalink / raw)
To: Gao Xiang; +Cc: linux-erofs, LKML, Sandeep Dhavale, huyue2, zhangwen
On Tue, 23 May 2023 09:53:06 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> On 2023/5/23 17:52, Yue Hu wrote:
> > On Mon, 22 May 2023 17:21:41 +0800
> > Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> >
> >> As Sandeep shown [1], high priority RT per-cpu kthreads are
> >> typically helpful for Android scenarios to minimize the scheduling
> >> latencies.
> >>
> >> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
> >> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
> >> EROFS_FS_PCPU_KTHREAD.
> >>
> >> Also clean up unneeded sched_set_normal().
> >>
> >> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
> >> Cc: Sandeep Dhavale <dhavale@google.com>
> >> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> >> ---
> >> fs/erofs/Kconfig | 1 +
> >> fs/erofs/zdata.c | 2 --
> >> 2 files changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
> >> index 704fb59577e0..f259d92c9720 100644
> >> --- a/fs/erofs/Kconfig
> >> +++ b/fs/erofs/Kconfig
> >> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
> >> config EROFS_FS_PCPU_KTHREAD_HIPRI
> >> bool "EROFS high priority per-CPU kthread workers"
> >> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
> >> + default y
> >
> > How about removing this config option?
>
> I tend to leave it as is.
Okay.
Reviewed-by: Yue Hu <huyue2@coolpad.com>
>
> Thanks,
> Gao Xiang
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
2023-05-22 9:21 ` Gao Xiang
@ 2023-05-23 2:32 ` Sandeep Dhavale
-1 siblings, 0 replies; 11+ messages in thread
From: Sandeep Dhavale via Linux-erofs @ 2023-05-23 2:32 UTC (permalink / raw)
To: Gao Xiang; +Cc: linux-erofs, LKML
On Mon, May 22, 2023 at 2:21 AM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>
> As Sandeep shown [1], high priority RT per-cpu kthreads are
> typically helpful for Android scenarios to minimize the scheduling
> latencies.
>
> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
> EROFS_FS_PCPU_KTHREAD.
>
> Also clean up unneeded sched_set_normal().
>
> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
> Cc: Sandeep Dhavale <dhavale@google.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> fs/erofs/Kconfig | 1 +
> fs/erofs/zdata.c | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
> index 704fb59577e0..f259d92c9720 100644
> --- a/fs/erofs/Kconfig
> +++ b/fs/erofs/Kconfig
> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
> config EROFS_FS_PCPU_KTHREAD_HIPRI
> bool "EROFS high priority per-CPU kthread workers"
> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
> + default y
> help
> This permits EROFS to configure per-CPU kthread workers to run
> at higher priority.
> diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
> index 92f3a01262cf..3ba505434f03 100644
> --- a/fs/erofs/zdata.c
> +++ b/fs/erofs/zdata.c
> @@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu)
> return worker;
> if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI))
> sched_set_fifo_low(worker->task);
> - else
> - sched_set_normal(worker->task, 0);
> return worker;
> }
>
> --
> 2.24.4
>
Looks good!
Reviewed-by: Sandeep Dhavale <dhavale@google.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
@ 2023-05-23 2:32 ` Sandeep Dhavale
0 siblings, 0 replies; 11+ messages in thread
From: Sandeep Dhavale @ 2023-05-23 2:32 UTC (permalink / raw)
To: Gao Xiang; +Cc: linux-erofs, LKML
On Mon, May 22, 2023 at 2:21 AM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
>
> As Sandeep shown [1], high priority RT per-cpu kthreads are
> typically helpful for Android scenarios to minimize the scheduling
> latencies.
>
> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
> EROFS_FS_PCPU_KTHREAD.
>
> Also clean up unneeded sched_set_normal().
>
> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
> Cc: Sandeep Dhavale <dhavale@google.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> fs/erofs/Kconfig | 1 +
> fs/erofs/zdata.c | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
> index 704fb59577e0..f259d92c9720 100644
> --- a/fs/erofs/Kconfig
> +++ b/fs/erofs/Kconfig
> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
> config EROFS_FS_PCPU_KTHREAD_HIPRI
> bool "EROFS high priority per-CPU kthread workers"
> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
> + default y
> help
> This permits EROFS to configure per-CPU kthread workers to run
> at higher priority.
> diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
> index 92f3a01262cf..3ba505434f03 100644
> --- a/fs/erofs/zdata.c
> +++ b/fs/erofs/zdata.c
> @@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu)
> return worker;
> if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI))
> sched_set_fifo_low(worker->task);
> - else
> - sched_set_normal(worker->task, 0);
> return worker;
> }
>
> --
> 2.24.4
>
Looks good!
Reviewed-by: Sandeep Dhavale <dhavale@google.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
2023-05-22 9:21 ` Gao Xiang
` (2 preceding siblings ...)
(?)
@ 2023-05-23 3:26 ` Chao Yu
-1 siblings, 0 replies; 11+ messages in thread
From: Chao Yu @ 2023-05-23 3:26 UTC (permalink / raw)
To: Gao Xiang, linux-erofs; +Cc: LKML, Sandeep Dhavale
On 2023/5/22 17:21, Gao Xiang wrote:
> As Sandeep shown [1], high priority RT per-cpu kthreads are
> typically helpful for Android scenarios to minimize the scheduling
> latencies.
>
> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
> EROFS_FS_PCPU_KTHREAD.
>
> Also clean up unneeded sched_set_normal().
>
> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
> Cc: Sandeep Dhavale <dhavale@google.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-05-23 3:26 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-22 9:21 [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled Gao Xiang
2023-05-22 9:21 ` Gao Xiang
2023-05-23 0:52 ` Yue Hu
2023-05-23 0:52 ` Yue Hu
2023-05-23 1:53 ` Gao Xiang
2023-05-23 1:53 ` Gao Xiang
2023-05-23 2:05 ` Yue Hu
2023-05-23 2:05 ` Yue Hu
2023-05-23 2:32 ` Sandeep Dhavale via Linux-erofs
2023-05-23 2:32 ` Sandeep Dhavale
2023-05-23 3:26 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.