From: Lee Jones <lee@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andreas Kemnade <andreas@kemnade.info>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver
Date: Thu, 25 May 2023 11:50:03 +0100 [thread overview]
Message-ID: <20230525105003.GF9691@google.com> (raw)
In-Reply-To: <20230430-omap2-pdata-quirks-v1-1-e015f3a3ea46@linaro.org>
On Mon, 01 May 2023, Linus Walleij wrote:
> The TWL4030 GPIO driver has a custom platform data .set_up()
> callback to call back into the platform and do misc stuff such
> as hog and export a GPIO for WLAN PWR on a specific OMAP3 board.
>
> Avoid all the kludgery in the platform data and the boardfile
> and just put the quirks right into the driver. Make it
> conditional on OMAP3.
>
> I think the exported GPIO is used by some kind of userspace
> so ordinary DTS hogs will probably not work.
>
> Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/mach-omap2/omap_device.c | 1 -
> arch/arm/mach-omap2/pdata-quirks.c | 41 +-----------------------------
> drivers/gpio/gpio-twl4030.c | 52 ++++++++++++++++++++++++++------------
> include/linux/mfd/twl.h | 3 ---
Acked-by: Lee Jones <lee@kernel.org>
> 4 files changed, 37 insertions(+), 60 deletions(-)
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andreas Kemnade <andreas@kemnade.info>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver
Date: Thu, 25 May 2023 11:50:03 +0100 [thread overview]
Message-ID: <20230525105003.GF9691@google.com> (raw)
In-Reply-To: <20230430-omap2-pdata-quirks-v1-1-e015f3a3ea46@linaro.org>
On Mon, 01 May 2023, Linus Walleij wrote:
> The TWL4030 GPIO driver has a custom platform data .set_up()
> callback to call back into the platform and do misc stuff such
> as hog and export a GPIO for WLAN PWR on a specific OMAP3 board.
>
> Avoid all the kludgery in the platform data and the boardfile
> and just put the quirks right into the driver. Make it
> conditional on OMAP3.
>
> I think the exported GPIO is used by some kind of userspace
> so ordinary DTS hogs will probably not work.
>
> Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/mach-omap2/omap_device.c | 1 -
> arch/arm/mach-omap2/pdata-quirks.c | 41 +-----------------------------
> drivers/gpio/gpio-twl4030.c | 52 ++++++++++++++++++++++++++------------
> include/linux/mfd/twl.h | 3 ---
Acked-by: Lee Jones <lee@kernel.org>
> 4 files changed, 37 insertions(+), 60 deletions(-)
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-25 10:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 9:05 [PATCH 0/3] Get rid of OMAP2 GPIO pdata quirks Linus Walleij
2023-05-01 9:05 ` Linus Walleij
2023-05-01 9:05 ` [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver Linus Walleij
2023-05-01 9:05 ` Linus Walleij
2023-05-03 13:01 ` Bartosz Golaszewski
2023-05-03 13:01 ` Bartosz Golaszewski
2023-05-04 12:19 ` Linus Walleij
2023-05-04 12:19 ` Linus Walleij
2023-05-17 9:57 ` Bartosz Golaszewski
2023-05-17 9:57 ` Bartosz Golaszewski
2023-05-25 10:50 ` Lee Jones [this message]
2023-05-25 10:50 ` Lee Jones
2023-05-01 9:05 ` [PATCH 2/3] ARM: omap2: Get USB hub reset GPIO from descriptor Linus Walleij
2023-05-01 9:05 ` Linus Walleij
2023-05-01 9:05 ` [PATCH 3/3] ARM: omap2: Rewrite WLAN quirk to use GPIO descriptors Linus Walleij
2023-05-01 9:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525105003.GF9691@google.com \
--to=lee@kernel.org \
--cc=andreas@kemnade.info \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.