From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
opendmb@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, richardcochran@gmail.com,
sumit.semwal@linaro.org, christian.koenig@amd.com,
simon.horman@corigine.com
Subject: Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller
Date: Fri, 2 Jun 2023 23:58:59 -0700 [thread overview]
Message-ID: <20230602235859.79042ff0@kernel.org> (raw)
In-Reply-To: <1685657551-38291-4-git-send-email-justin.chen@broadcom.com>
On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote:
> + /* general stats */
> + STAT_NETDEV(rx_packets),
> + STAT_NETDEV(tx_packets),
> + STAT_NETDEV(rx_bytes),
> + STAT_NETDEV(tx_bytes),
> + STAT_NETDEV(rx_errors),
> + STAT_NETDEV(tx_errors),
> + STAT_NETDEV(rx_dropped),
> + STAT_NETDEV(tx_dropped),
> + STAT_NETDEV(multicast),
please don't report standard interface stats in ethtool -S
> + /* UniMAC RSV counters */
> + STAT_BCMASP_MIB_RX("rx_64_octets", mib.rx.pkt_cnt.cnt_64),
> + STAT_BCMASP_MIB_RX("rx_65_127_oct", mib.rx.pkt_cnt.cnt_127),
> + STAT_BCMASP_MIB_RX("rx_128_255_oct", mib.rx.pkt_cnt.cnt_255),
> + STAT_BCMASP_MIB_RX("rx_256_511_oct", mib.rx.pkt_cnt.cnt_511),
> + STAT_BCMASP_MIB_RX("rx_512_1023_oct", mib.rx.pkt_cnt.cnt_1023),
> + STAT_BCMASP_MIB_RX("rx_1024_1518_oct", mib.rx.pkt_cnt.cnt_1518),
> + STAT_BCMASP_MIB_RX("rx_vlan_1519_1522_oct", mib.rx.pkt_cnt.cnt_mgv),
> + STAT_BCMASP_MIB_RX("rx_1522_2047_oct", mib.rx.pkt_cnt.cnt_2047),
> + STAT_BCMASP_MIB_RX("rx_2048_4095_oct", mib.rx.pkt_cnt.cnt_4095),
> + STAT_BCMASP_MIB_RX("rx_4096_9216_oct", mib.rx.pkt_cnt.cnt_9216),
these should also be removed, and you should implement @get_rmon_stats.
> + STAT_BCMASP_MIB_RX("rx_pkts", mib.rx.pkt),
> + STAT_BCMASP_MIB_RX("rx_bytes", mib.rx.bytes),
> + STAT_BCMASP_MIB_RX("rx_multicast", mib.rx.mca),
> + STAT_BCMASP_MIB_RX("rx_broadcast", mib.rx.bca),
> + STAT_BCMASP_MIB_RX("rx_fcs", mib.rx.fcs),
there's a FCS error statistic in the standard stats, no need to
duplicate
> + STAT_BCMASP_MIB_RX("rx_control", mib.rx.cf),
> + STAT_BCMASP_MIB_RX("rx_pause", mib.rx.pf),
@get_pause_stats
> + STAT_BCMASP_MIB_RX("rx_unknown", mib.rx.uo),
> + STAT_BCMASP_MIB_RX("rx_align", mib.rx.aln),
> + STAT_BCMASP_MIB_RX("rx_outrange", mib.rx.flr),
> + STAT_BCMASP_MIB_RX("rx_code", mib.rx.cde),
> + STAT_BCMASP_MIB_RX("rx_carrier", mib.rx.fcr),
> + STAT_BCMASP_MIB_RX("rx_oversize", mib.rx.ovr),
> + STAT_BCMASP_MIB_RX("rx_jabber", mib.rx.jbr),
these look like candidates from standard stats, too.
Please read thru:
https://docs.kernel.org/next/networking/statistics.html
> + STAT_BCMASP_MIB_RX("rx_mtu_err", mib.rx.mtue),
> + STAT_BCMASP_MIB_RX("rx_good_pkts", mib.rx.pok),
> + STAT_BCMASP_MIB_RX("rx_unicast", mib.rx.uc),
> + STAT_BCMASP_MIB_RX("rx_ppp", mib.rx.ppp),
> + STAT_BCMASP_MIB_RX("rx_crc", mib.rx.rcrc),
hm, what's the difference between rx_crc and rx_fcs ?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
opendmb@gmail.com, florian.fainelli@broadcom.com, andrew@lunn.ch,
netdev@vger.kernel.org, richardcochran@gmail.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux@armlinux.org.uk, edumazet@google.com, robh+dt@kernel.org,
bcm-kernel-feedback-list@broadcom.com,
krzysztof.kozlowski+dt@linaro.org, simon.horman@corigine.com,
christian.koenig@amd.com, pabeni@redhat.com,
sumit.semwal@linaro.org, davem@davemloft.net,
hkallweit1@gmail.com
Subject: Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller
Date: Fri, 2 Jun 2023 23:58:59 -0700 [thread overview]
Message-ID: <20230602235859.79042ff0@kernel.org> (raw)
In-Reply-To: <1685657551-38291-4-git-send-email-justin.chen@broadcom.com>
On Thu, 1 Jun 2023 15:12:28 -0700 Justin Chen wrote:
> + /* general stats */
> + STAT_NETDEV(rx_packets),
> + STAT_NETDEV(tx_packets),
> + STAT_NETDEV(rx_bytes),
> + STAT_NETDEV(tx_bytes),
> + STAT_NETDEV(rx_errors),
> + STAT_NETDEV(tx_errors),
> + STAT_NETDEV(rx_dropped),
> + STAT_NETDEV(tx_dropped),
> + STAT_NETDEV(multicast),
please don't report standard interface stats in ethtool -S
> + /* UniMAC RSV counters */
> + STAT_BCMASP_MIB_RX("rx_64_octets", mib.rx.pkt_cnt.cnt_64),
> + STAT_BCMASP_MIB_RX("rx_65_127_oct", mib.rx.pkt_cnt.cnt_127),
> + STAT_BCMASP_MIB_RX("rx_128_255_oct", mib.rx.pkt_cnt.cnt_255),
> + STAT_BCMASP_MIB_RX("rx_256_511_oct", mib.rx.pkt_cnt.cnt_511),
> + STAT_BCMASP_MIB_RX("rx_512_1023_oct", mib.rx.pkt_cnt.cnt_1023),
> + STAT_BCMASP_MIB_RX("rx_1024_1518_oct", mib.rx.pkt_cnt.cnt_1518),
> + STAT_BCMASP_MIB_RX("rx_vlan_1519_1522_oct", mib.rx.pkt_cnt.cnt_mgv),
> + STAT_BCMASP_MIB_RX("rx_1522_2047_oct", mib.rx.pkt_cnt.cnt_2047),
> + STAT_BCMASP_MIB_RX("rx_2048_4095_oct", mib.rx.pkt_cnt.cnt_4095),
> + STAT_BCMASP_MIB_RX("rx_4096_9216_oct", mib.rx.pkt_cnt.cnt_9216),
these should also be removed, and you should implement @get_rmon_stats.
> + STAT_BCMASP_MIB_RX("rx_pkts", mib.rx.pkt),
> + STAT_BCMASP_MIB_RX("rx_bytes", mib.rx.bytes),
> + STAT_BCMASP_MIB_RX("rx_multicast", mib.rx.mca),
> + STAT_BCMASP_MIB_RX("rx_broadcast", mib.rx.bca),
> + STAT_BCMASP_MIB_RX("rx_fcs", mib.rx.fcs),
there's a FCS error statistic in the standard stats, no need to
duplicate
> + STAT_BCMASP_MIB_RX("rx_control", mib.rx.cf),
> + STAT_BCMASP_MIB_RX("rx_pause", mib.rx.pf),
@get_pause_stats
> + STAT_BCMASP_MIB_RX("rx_unknown", mib.rx.uo),
> + STAT_BCMASP_MIB_RX("rx_align", mib.rx.aln),
> + STAT_BCMASP_MIB_RX("rx_outrange", mib.rx.flr),
> + STAT_BCMASP_MIB_RX("rx_code", mib.rx.cde),
> + STAT_BCMASP_MIB_RX("rx_carrier", mib.rx.fcr),
> + STAT_BCMASP_MIB_RX("rx_oversize", mib.rx.ovr),
> + STAT_BCMASP_MIB_RX("rx_jabber", mib.rx.jbr),
these look like candidates from standard stats, too.
Please read thru:
https://docs.kernel.org/next/networking/statistics.html
> + STAT_BCMASP_MIB_RX("rx_mtu_err", mib.rx.mtue),
> + STAT_BCMASP_MIB_RX("rx_good_pkts", mib.rx.pok),
> + STAT_BCMASP_MIB_RX("rx_unicast", mib.rx.uc),
> + STAT_BCMASP_MIB_RX("rx_ppp", mib.rx.ppp),
> + STAT_BCMASP_MIB_RX("rx_crc", mib.rx.rcrc),
hm, what's the difference between rx_crc and rx_fcs ?
next prev parent reply other threads:[~2023-06-03 6:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 22:12 [PATCH net-next v6 0/6] Brcm ASP 2.0 Ethernet Controller Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0 Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 1/6] dt-bindings: net: brcm, unimac-mdio: " Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-07 22:24 ` Rob Herring
2023-06-07 22:24 ` Rob Herring
2023-06-01 22:12 ` [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 " Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-03 6:52 ` Jakub Kicinski
2023-06-03 6:52 ` Jakub Kicinski
2023-06-03 6:58 ` Jakub Kicinski [this message]
2023-06-03 6:58 ` Jakub Kicinski
2023-06-05 22:04 ` Florian Fainelli
2023-06-05 22:04 ` Florian Fainelli
2023-06-06 22:58 ` Justin Chen
2023-06-06 22:58 ` Justin Chen
2023-06-07 0:16 ` Jakub Kicinski
2023-06-07 0:16 ` Jakub Kicinski
2023-06-07 1:35 ` Justin Chen
2023-06-07 1:35 ` Justin Chen
2023-06-07 1:54 ` Jakub Kicinski
2023-06-07 1:54 ` Jakub Kicinski
2023-06-07 2:33 ` Justin Chen
2023-06-07 2:33 ` Justin Chen
2023-06-07 3:45 ` Jakub Kicinski
2023-06-07 3:45 ` Jakub Kicinski
2023-06-07 4:22 ` Justin Chen
2023-06-07 4:22 ` Justin Chen
2023-06-07 4:35 ` Jakub Kicinski
2023-06-07 4:35 ` Jakub Kicinski
2023-06-01 22:12 ` [PATCH net-next v6 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165 Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers Justin Chen
2023-06-01 22:12 ` Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602235859.79042ff0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=simon.horman@corigine.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.