From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
opendmb@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, richardcochran@gmail.com,
sumit.semwal@linaro.org, christian.koenig@amd.com,
simon.horman@corigine.com
Subject: Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller
Date: Tue, 6 Jun 2023 21:35:42 -0700 [thread overview]
Message-ID: <20230606213542.3913d3b8@kernel.org> (raw)
In-Reply-To: <fd0f87b9-a822-c83a-4880-9ed1ac34794e@broadcom.com>
On Tue, 6 Jun 2023 21:22:45 -0700 Justin Chen wrote:
> >> Through filters that can be programmed by the Host cpu or co-processor.
> >
> > How are the filter programmed by the host (in terms of user API)?
>
> You are stumbling upon my next objective here. This patch set does not
> support this because it wasn't clear how to do it. The plan was to get
> the base driver merged first then introduce a way to specify an offload
> channel.
Alright.
> If you must know, I introduced a rxnfc flow_spec ring cookie to specify
> an offload filter. Not sure if this is the right way to do it or not,
> but figured this would be a future discussion.
We clean leave it for later indeed, but in case you're wondering -
that's unlikely to fly. My preference will be to expose the accelerator
port as a switch port, with a netdev and forward using TC flower etc.
With the netdev in place you'll have a place to report stats and all the
necessary diagnostics, which otherwise get crammed into random places.
I believe Florian asked about this in the past, I hope I'm being
consistent with my answer here :P
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
opendmb@gmail.com, florian.fainelli@broadcom.com, andrew@lunn.ch,
netdev@vger.kernel.org, richardcochran@gmail.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux@armlinux.org.uk, edumazet@google.com, robh+dt@kernel.org,
bcm-kernel-feedback-list@broadcom.com,
krzysztof.kozlowski+dt@linaro.org, simon.horman@corigine.com,
christian.koenig@amd.com, pabeni@redhat.com,
sumit.semwal@linaro.org, davem@davemloft.net,
hkallweit1@gmail.com
Subject: Re: [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller
Date: Tue, 6 Jun 2023 21:35:42 -0700 [thread overview]
Message-ID: <20230606213542.3913d3b8@kernel.org> (raw)
In-Reply-To: <fd0f87b9-a822-c83a-4880-9ed1ac34794e@broadcom.com>
On Tue, 6 Jun 2023 21:22:45 -0700 Justin Chen wrote:
> >> Through filters that can be programmed by the Host cpu or co-processor.
> >
> > How are the filter programmed by the host (in terms of user API)?
>
> You are stumbling upon my next objective here. This patch set does not
> support this because it wasn't clear how to do it. The plan was to get
> the base driver merged first then introduce a way to specify an offload
> channel.
Alright.
> If you must know, I introduced a rxnfc flow_spec ring cookie to specify
> an offload filter. Not sure if this is the right way to do it or not,
> but figured this would be a future discussion.
We clean leave it for later indeed, but in case you're wondering -
that's unlikely to fly. My preference will be to expose the accelerator
port as a switch port, with a netdev and forward using TC flower etc.
With the netdev in place you'll have a place to report stats and all the
necessary diagnostics, which otherwise get crammed into random places.
I believe Florian asked about this in the past, I hope I'm being
consistent with my answer here :P
next prev parent reply other threads:[~2023-06-07 4:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 22:12 [PATCH net-next v6 0/6] Brcm ASP 2.0 Ethernet Controller Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0 Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 1/6] dt-bindings: net: brcm, unimac-mdio: " Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-07 22:24 ` Rob Herring
2023-06-07 22:24 ` Rob Herring
2023-06-01 22:12 ` [PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 " Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-03 6:52 ` Jakub Kicinski
2023-06-03 6:52 ` Jakub Kicinski
2023-06-03 6:58 ` Jakub Kicinski
2023-06-03 6:58 ` Jakub Kicinski
2023-06-05 22:04 ` Florian Fainelli
2023-06-05 22:04 ` Florian Fainelli
2023-06-06 22:58 ` Justin Chen
2023-06-06 22:58 ` Justin Chen
2023-06-07 0:16 ` Jakub Kicinski
2023-06-07 0:16 ` Jakub Kicinski
2023-06-07 1:35 ` Justin Chen
2023-06-07 1:35 ` Justin Chen
2023-06-07 1:54 ` Jakub Kicinski
2023-06-07 1:54 ` Jakub Kicinski
2023-06-07 2:33 ` Justin Chen
2023-06-07 2:33 ` Justin Chen
2023-06-07 3:45 ` Jakub Kicinski
2023-06-07 3:45 ` Jakub Kicinski
2023-06-07 4:22 ` Justin Chen
2023-06-07 4:22 ` Justin Chen
2023-06-07 4:35 ` Jakub Kicinski [this message]
2023-06-07 4:35 ` Jakub Kicinski
2023-06-01 22:12 ` [PATCH net-next v6 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165 Justin Chen
2023-06-01 22:12 ` Justin Chen
2023-06-01 22:12 ` [PATCH net-next v6 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers Justin Chen
2023-06-01 22:12 ` Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606213542.3913d3b8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=simon.horman@corigine.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.