From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v5 1/6] mtd: rawnand: meson: fix ready/busy command
Date: Mon, 5 Jun 2023 09:08:15 +0200 [thread overview]
Message-ID: <20230605090815.48bc2074@xps-13> (raw)
In-Reply-To: <1ede0f53-8513-e346-b5a8-fc8a804cfa8d@sberdevices.ru>
Hi Arseniy,
avkrasnov@sberdevices.ru wrote on Fri, 2 Jun 2023 01:44:01 +0300:
> Hello Miquel!
>
> May be I can exclude this patch from this patchset and send it as a single patch
> as it is fix and not related with other patches?
Yes absolutely.
>
> Thanks, Arseniy
>
> On 01.06.2023 10:51, Miquel Raynal wrote:
> > Hi Arseniy,
> >
> > AVKrasnov@sberdevices.ru wrote on Thu, 1 Jun 2023 09:18:44 +0300:
> >
> >> This fixes ready/busy command value.
> >
> > nit: "Fix the ready/busy command value."
> >>
> >> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> >> ---
> >> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> >> index 074e14225c06..9dd4a676497b 100644
> >> --- a/drivers/mtd/nand/raw/meson_nand.c
> >> +++ b/drivers/mtd/nand/raw/meson_nand.c
> >> @@ -37,7 +37,7 @@
> >> #define NFC_CMD_SCRAMBLER_ENABLE BIT(19)
> >> #define NFC_CMD_SCRAMBLER_DISABLE 0
> >> #define NFC_CMD_SHORTMODE_DISABLE 0
> >> -#define NFC_CMD_RB_INT BIT(14)
> >> +#define NFC_CMD_RB_INT ((0xb << 10) | BIT(18) | BIT(16))
> >>
> >> #define NFC_CMD_GET_SIZE(x) (((x) >> 22) & GENMASK(4, 0))
> >>
> >
> >
> > Thanks,
> > Miquèl
Thanks,
Miquèl
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v5 1/6] mtd: rawnand: meson: fix ready/busy command
Date: Mon, 5 Jun 2023 09:08:15 +0200 [thread overview]
Message-ID: <20230605090815.48bc2074@xps-13> (raw)
In-Reply-To: <1ede0f53-8513-e346-b5a8-fc8a804cfa8d@sberdevices.ru>
Hi Arseniy,
avkrasnov@sberdevices.ru wrote on Fri, 2 Jun 2023 01:44:01 +0300:
> Hello Miquel!
>
> May be I can exclude this patch from this patchset and send it as a single patch
> as it is fix and not related with other patches?
Yes absolutely.
>
> Thanks, Arseniy
>
> On 01.06.2023 10:51, Miquel Raynal wrote:
> > Hi Arseniy,
> >
> > AVKrasnov@sberdevices.ru wrote on Thu, 1 Jun 2023 09:18:44 +0300:
> >
> >> This fixes ready/busy command value.
> >
> > nit: "Fix the ready/busy command value."
> >>
> >> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> >> ---
> >> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> >> index 074e14225c06..9dd4a676497b 100644
> >> --- a/drivers/mtd/nand/raw/meson_nand.c
> >> +++ b/drivers/mtd/nand/raw/meson_nand.c
> >> @@ -37,7 +37,7 @@
> >> #define NFC_CMD_SCRAMBLER_ENABLE BIT(19)
> >> #define NFC_CMD_SCRAMBLER_DISABLE 0
> >> #define NFC_CMD_SHORTMODE_DISABLE 0
> >> -#define NFC_CMD_RB_INT BIT(14)
> >> +#define NFC_CMD_RB_INT ((0xb << 10) | BIT(18) | BIT(16))
> >>
> >> #define NFC_CMD_GET_SIZE(x) (((x) >> 22) & GENMASK(4, 0))
> >>
> >
> >
> > Thanks,
> > Miquèl
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v5 1/6] mtd: rawnand: meson: fix ready/busy command
Date: Mon, 5 Jun 2023 09:08:15 +0200 [thread overview]
Message-ID: <20230605090815.48bc2074@xps-13> (raw)
In-Reply-To: <1ede0f53-8513-e346-b5a8-fc8a804cfa8d@sberdevices.ru>
Hi Arseniy,
avkrasnov@sberdevices.ru wrote on Fri, 2 Jun 2023 01:44:01 +0300:
> Hello Miquel!
>
> May be I can exclude this patch from this patchset and send it as a single patch
> as it is fix and not related with other patches?
Yes absolutely.
>
> Thanks, Arseniy
>
> On 01.06.2023 10:51, Miquel Raynal wrote:
> > Hi Arseniy,
> >
> > AVKrasnov@sberdevices.ru wrote on Thu, 1 Jun 2023 09:18:44 +0300:
> >
> >> This fixes ready/busy command value.
> >
> > nit: "Fix the ready/busy command value."
> >>
> >> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> >> ---
> >> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> >> index 074e14225c06..9dd4a676497b 100644
> >> --- a/drivers/mtd/nand/raw/meson_nand.c
> >> +++ b/drivers/mtd/nand/raw/meson_nand.c
> >> @@ -37,7 +37,7 @@
> >> #define NFC_CMD_SCRAMBLER_ENABLE BIT(19)
> >> #define NFC_CMD_SCRAMBLER_DISABLE 0
> >> #define NFC_CMD_SHORTMODE_DISABLE 0
> >> -#define NFC_CMD_RB_INT BIT(14)
> >> +#define NFC_CMD_RB_INT ((0xb << 10) | BIT(18) | BIT(16))
> >>
> >> #define NFC_CMD_GET_SIZE(x) (((x) >> 22) & GENMASK(4, 0))
> >>
> >
> >
> > Thanks,
> > Miquèl
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v5 1/6] mtd: rawnand: meson: fix ready/busy command
Date: Mon, 5 Jun 2023 09:08:15 +0200 [thread overview]
Message-ID: <20230605090815.48bc2074@xps-13> (raw)
In-Reply-To: <1ede0f53-8513-e346-b5a8-fc8a804cfa8d@sberdevices.ru>
Hi Arseniy,
avkrasnov@sberdevices.ru wrote on Fri, 2 Jun 2023 01:44:01 +0300:
> Hello Miquel!
>
> May be I can exclude this patch from this patchset and send it as a single patch
> as it is fix and not related with other patches?
Yes absolutely.
>
> Thanks, Arseniy
>
> On 01.06.2023 10:51, Miquel Raynal wrote:
> > Hi Arseniy,
> >
> > AVKrasnov@sberdevices.ru wrote on Thu, 1 Jun 2023 09:18:44 +0300:
> >
> >> This fixes ready/busy command value.
> >
> > nit: "Fix the ready/busy command value."
> >>
> >> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> >> ---
> >> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> >> index 074e14225c06..9dd4a676497b 100644
> >> --- a/drivers/mtd/nand/raw/meson_nand.c
> >> +++ b/drivers/mtd/nand/raw/meson_nand.c
> >> @@ -37,7 +37,7 @@
> >> #define NFC_CMD_SCRAMBLER_ENABLE BIT(19)
> >> #define NFC_CMD_SCRAMBLER_DISABLE 0
> >> #define NFC_CMD_SHORTMODE_DISABLE 0
> >> -#define NFC_CMD_RB_INT BIT(14)
> >> +#define NFC_CMD_RB_INT ((0xb << 10) | BIT(18) | BIT(16))
> >>
> >> #define NFC_CMD_GET_SIZE(x) (((x) >> 22) & GENMASK(4, 0))
> >>
> >
> >
> > Thanks,
> > Miquèl
Thanks,
Miquèl
next prev parent reply other threads:[~2023-06-05 7:08 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 6:18 [RFC PATCH v5 0/6] refactoring, fixes and updates for Meson NAND Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` [RFC PATCH v5 1/6] mtd: rawnand: meson: fix ready/busy command Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 7:51 ` Miquel Raynal
2023-06-01 7:51 ` Miquel Raynal
2023-06-01 7:51 ` Miquel Raynal
2023-06-01 7:51 ` Miquel Raynal
2023-06-01 22:44 ` Arseniy Krasnov
2023-06-01 22:44 ` Arseniy Krasnov
2023-06-01 22:44 ` Arseniy Krasnov
2023-06-01 22:44 ` Arseniy Krasnov
2023-06-05 7:08 ` Miquel Raynal [this message]
2023-06-05 7:08 ` Miquel Raynal
2023-06-05 7:08 ` Miquel Raynal
2023-06-05 7:08 ` Miquel Raynal
2023-06-01 6:18 ` [RFC PATCH v5 2/6] mtd: rawnand: meson: wait for command in polling mode Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 7:57 ` Arseniy Krasnov
2023-06-01 7:57 ` Arseniy Krasnov
2023-06-01 7:57 ` Arseniy Krasnov
2023-06-01 7:57 ` Arseniy Krasnov
2023-06-01 8:07 ` Miquel Raynal
2023-06-01 8:07 ` Miquel Raynal
2023-06-01 8:07 ` Miquel Raynal
2023-06-01 8:07 ` Miquel Raynal
2023-06-01 23:09 ` Arseniy Krasnov
2023-06-01 23:09 ` Arseniy Krasnov
2023-06-01 23:09 ` Arseniy Krasnov
2023-06-01 23:09 ` Arseniy Krasnov
2023-06-05 9:05 ` Miquel Raynal
2023-06-05 9:05 ` Miquel Raynal
2023-06-05 9:05 ` Miquel Raynal
2023-06-05 9:05 ` Miquel Raynal
2023-06-05 13:19 ` Liang Yang
2023-06-05 13:19 ` Liang Yang
2023-06-05 13:19 ` Liang Yang
2023-06-05 13:19 ` Liang Yang
2023-06-05 13:30 ` Liang Yang
2023-06-05 13:30 ` Liang Yang
2023-06-05 13:30 ` Liang Yang
2023-06-05 13:30 ` Liang Yang
2023-06-05 16:58 ` Arseniy Krasnov
2023-06-05 16:58 ` Arseniy Krasnov
2023-06-05 16:58 ` Arseniy Krasnov
2023-06-05 16:58 ` Arseniy Krasnov
2023-06-06 7:03 ` Miquel Raynal
2023-06-06 7:03 ` Miquel Raynal
2023-06-06 7:03 ` Miquel Raynal
2023-06-06 7:03 ` Miquel Raynal
2023-06-06 7:40 ` Arseniy Krasnov
2023-06-06 7:40 ` Arseniy Krasnov
2023-06-06 7:40 ` Arseniy Krasnov
2023-06-06 7:40 ` Arseniy Krasnov
2023-06-06 7:55 ` Miquel Raynal
2023-06-06 7:55 ` Miquel Raynal
2023-06-06 7:55 ` Miquel Raynal
2023-06-06 7:55 ` Miquel Raynal
2023-06-06 11:49 ` Arseniy Krasnov
2023-06-06 11:49 ` Arseniy Krasnov
2023-06-06 11:49 ` Arseniy Krasnov
2023-06-06 11:49 ` Arseniy Krasnov
2023-06-06 12:11 ` Miquel Raynal
2023-06-06 12:11 ` Miquel Raynal
2023-06-06 12:11 ` Miquel Raynal
2023-06-06 12:11 ` Miquel Raynal
2023-06-06 12:10 ` Arseniy Krasnov
2023-06-06 12:10 ` Arseniy Krasnov
2023-06-06 12:10 ` Arseniy Krasnov
2023-06-06 12:10 ` Arseniy Krasnov
2023-06-01 6:18 ` [RFC PATCH v5 3/6] mtd: rawnand: meson: only expose unprotected user OOB bytes Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 8:31 ` Miquel Raynal
2023-06-01 8:31 ` Miquel Raynal
2023-06-01 8:31 ` Miquel Raynal
2023-06-01 8:31 ` Miquel Raynal
2023-06-02 8:53 ` Arseniy Krasnov
2023-06-02 8:53 ` Arseniy Krasnov
2023-06-02 8:53 ` Arseniy Krasnov
2023-06-02 8:53 ` Arseniy Krasnov
2023-06-05 9:48 ` Miquel Raynal
2023-06-05 9:48 ` Miquel Raynal
2023-06-05 9:48 ` Miquel Raynal
2023-06-05 9:48 ` Miquel Raynal
2023-06-06 4:42 ` Arseniy Krasnov
2023-06-06 4:42 ` Arseniy Krasnov
2023-06-06 4:42 ` Arseniy Krasnov
2023-06-06 4:42 ` Arseniy Krasnov
2023-06-06 7:11 ` Miquel Raynal
2023-06-06 7:11 ` Miquel Raynal
2023-06-06 7:11 ` Miquel Raynal
2023-06-06 7:11 ` Miquel Raynal
2023-06-06 7:41 ` Arseniy Krasnov
2023-06-06 7:41 ` Arseniy Krasnov
2023-06-06 7:41 ` Arseniy Krasnov
2023-06-06 7:41 ` Arseniy Krasnov
2023-06-01 6:18 ` [RFC PATCH v5 4/6] mtd: rawnand: meson: use macro for OOB area Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 8:34 ` Miquel Raynal
2023-06-01 8:34 ` Miquel Raynal
2023-06-01 8:34 ` Miquel Raynal
2023-06-01 8:34 ` Miquel Raynal
2023-06-01 6:18 ` [RFC PATCH v5 5/6] mtd: rawnand: meson: check buffer length Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` [RFC PATCH v5 6/6] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 6:18 ` Arseniy Krasnov
2023-06-01 7:50 ` [RFC PATCH v5 0/6] refactoring, fixes and updates for Meson NAND Miquel Raynal
2023-06-01 7:50 ` Miquel Raynal
2023-06-01 7:50 ` Miquel Raynal
2023-06-01 7:50 ` Miquel Raynal
2023-06-01 7:51 ` Arseniy Krasnov
2023-06-01 7:51 ` Arseniy Krasnov
2023-06-01 7:51 ` Arseniy Krasnov
2023-06-01 7:51 ` Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605090815.48bc2074@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=avkrasnov@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.