From: Jakub Kicinski <kuba@kernel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: geert+renesas@glider.be, mst@redhat.com, razor@blackwall.org,
phil@nwl.cc, javierm@redhat.com, edumazet@google.com,
benjamin.tissoires@redhat.com, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, linux-clk@vger.kernel.org,
lucien.xin@gmail.com, leon@kernel.org, corbet@lwn.net,
linux-rdma@vger.kernel.org, masahiroy@kernel.org,
linux-doc@vger.kernel.org, jesse.brandeburg@intel.com,
vadfed@meta.com, intel-wired-lan@lists.osuosl.org,
airlied@redhat.com, vadfed@fb.com, pabeni@redhat.com,
ricardo.canuelo@collabora.com, jiri@resnulli.us, arnd@arndb.de,
idosch@nvidia.com, richardcochran@gmail.com,
claudiajkang@gmail.com, kuniyu@amazon.com,
jacek.lawrynowicz@linux.intel.com, liuhangbin@gmail.com,
nicolas.dichtel@6wind.com, linux-arm-kernel@lists.infradead.org,
axboe@kernel.dk, sj@kernel.org, vadim.fedorenko@linux.dev,
linux@zary.sk, gregkh@linuxfoundation.org, ogabbay@kernel.org,
nipun.gupta@amd.com, linux-kernel@vger.kernel.org,
andy.ren@getcruise.com, tzimmermann@suse.de,
jonathan.lemon@gmail.com, saeedm@nvidia.com, davem@davemloft.net,
milena.olech@intel.com, hkallweit1@gmail.com
Subject: Re: [Intel-wired-lan] [RFC PATCH v8 00/10] Create common DPLL configuration API
Date: Fri, 9 Jun 2023 16:27:39 -0700 [thread overview]
Message-ID: <20230609162739.0d94a704@kernel.org> (raw)
In-Reply-To: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com>
On Fri, 9 Jun 2023 14:18:43 +0200 Arkadiusz Kubalewski wrote:
> Implement common API for clock/DPLL configuration and status reporting.
> The API utilises netlink interface as transport for commands and event
> notifications. This API aim to extend current pin configuration and
> make it flexible and easy to cover special configurations.
>
> Netlink interface is based on ynl spec, it allows use of in-kernel
> tools/net/ynl/cli.py application to control the interface with properly
> formated command and json attribute strings. Here are few command
> examples of how it works with `ice` driver on supported NIC:
Now I see why you sent the ynl-gen patch you sent :) It's the
combination of nest and multi-attr which doesn't populate the right
policy. Also the enums are not policed right by ynl-gen.
I pushed two fixes to my local tree:
https://github.com/kuba-moo/linux/commits/ynl-c
in case you need them. I'll submit them on Monday.
I also tried to run the user space C code gen (for generating C
API/lib as described in [1]). It seems to work just fine, FWIW, so
just LMK if C bindings would be useful, I can give more instructions.
[1] https://docs.kernel.org/next/userspace-api/netlink/intro-specs.html#ynl-lib
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: jiri@resnulli.us, vadfed@meta.com, jonathan.lemon@gmail.com,
pabeni@redhat.com, corbet@lwn.net, davem@davemloft.net,
edumazet@google.com, vadfed@fb.com, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, saeedm@nvidia.com, leon@kernel.org,
richardcochran@gmail.com, sj@kernel.org, javierm@redhat.com,
ricardo.canuelo@collabora.com, mst@redhat.com,
tzimmermann@suse.de, michal.michalik@intel.com,
gregkh@linuxfoundation.org, jacek.lawrynowicz@linux.intel.com,
airlied@redhat.com, ogabbay@kernel.org, arnd@arndb.de,
nipun.gupta@amd.com, axboe@kernel.dk, linux@zary.sk,
masahiroy@kernel.org, benjamin.tissoires@redhat.com,
geert+renesas@glider.be, milena.olech@intel.com,
kuniyu@amazon.com, liuhangbin@gmail.com, hkallweit1@gmail.com,
andy.ren@getcruise.com, razor@blackwall.org, idosch@nvidia.com,
lucien.xin@gmail.com, nicolas.dichtel@6wind.com, phil@nwl.cc,
claudiajkang@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, poros@redhat.com,
mschmidt@redhat.com, linux-clk@vger.kernel.org,
vadim.fedorenko@linux.dev
Subject: Re: [RFC PATCH v8 00/10] Create common DPLL configuration API
Date: Fri, 9 Jun 2023 16:27:39 -0700 [thread overview]
Message-ID: <20230609162739.0d94a704@kernel.org> (raw)
In-Reply-To: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com>
On Fri, 9 Jun 2023 14:18:43 +0200 Arkadiusz Kubalewski wrote:
> Implement common API for clock/DPLL configuration and status reporting.
> The API utilises netlink interface as transport for commands and event
> notifications. This API aim to extend current pin configuration and
> make it flexible and easy to cover special configurations.
>
> Netlink interface is based on ynl spec, it allows use of in-kernel
> tools/net/ynl/cli.py application to control the interface with properly
> formated command and json attribute strings. Here are few command
> examples of how it works with `ice` driver on supported NIC:
Now I see why you sent the ynl-gen patch you sent :) It's the
combination of nest and multi-attr which doesn't populate the right
policy. Also the enums are not policed right by ynl-gen.
I pushed two fixes to my local tree:
https://github.com/kuba-moo/linux/commits/ynl-c
in case you need them. I'll submit them on Monday.
I also tried to run the user space C code gen (for generating C
API/lib as described in [1]). It seems to work just fine, FWIW, so
just LMK if C bindings would be useful, I can give more instructions.
[1] https://docs.kernel.org/next/userspace-api/netlink/intro-specs.html#ynl-lib
next prev parent reply other threads:[~2023-06-09 23:27 UTC|newest]
Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 12:18 [Intel-wired-lan] [RFC PATCH v8 00/10] Create common DPLL configuration API Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 01/10] dpll: documentation on DPLL subsystem interface Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-10 3:22 ` [Intel-wired-lan] " Bagas Sanjaya
2023-06-10 3:22 ` Bagas Sanjaya
2023-06-12 14:24 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-12 14:24 ` Kubalewski, Arkadiusz
2023-06-10 16:28 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 16:28 ` Jiri Pirko
2023-06-12 15:24 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-12 15:24 ` Kubalewski, Arkadiusz
2023-06-12 22:30 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-12 22:30 ` Jakub Kicinski
2023-06-12 15:30 ` [Intel-wired-lan] " Bart Van Assche
2023-06-12 15:30 ` Bart Van Assche
2023-06-12 16:01 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-12 16:01 ` Kubalewski, Arkadiusz
2023-06-12 22:43 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-12 22:43 ` Jakub Kicinski
2023-06-13 9:55 ` [Intel-wired-lan] " Jiri Pirko
2023-06-13 9:55 ` Jiri Pirko
2023-06-13 16:38 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-13 16:38 ` Jakub Kicinski
2023-06-14 9:27 ` [Intel-wired-lan] " Jiri Pirko
2023-06-14 9:27 ` Jiri Pirko
2023-06-14 12:21 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-14 12:21 ` Kubalewski, Arkadiusz
2023-06-14 19:15 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-14 19:15 ` Jakub Kicinski
2023-06-14 19:23 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-14 19:23 ` Jakub Kicinski
2023-06-15 10:18 ` [Intel-wired-lan] " Jiri Pirko
2023-06-15 10:18 ` Jiri Pirko
2023-06-15 13:44 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-15 13:44 ` Kubalewski, Arkadiusz
2023-06-15 16:31 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-15 16:31 ` Jakub Kicinski
2023-06-17 10:36 ` [Intel-wired-lan] " Jiri Pirko
2023-06-17 10:36 ` Jiri Pirko
2023-06-12 23:49 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-12 23:49 ` Jakub Kicinski
2023-06-14 12:23 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-14 12:23 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 02/10] dpll: spec: Add Netlink spec in YAML Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-10 16:22 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 16:22 ` Jiri Pirko
2023-06-15 13:42 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-15 13:42 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 03/10] dpll: core: Add DPLL framework base functions Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-10 17:38 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 17:38 ` Jiri Pirko
2023-06-21 16:28 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-21 16:28 ` Kubalewski, Arkadiusz
2023-06-21 18:55 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-21 18:55 ` Kubalewski, Arkadiusz
2023-06-22 7:05 ` [Intel-wired-lan] " Jiri Pirko
2023-06-22 7:05 ` Jiri Pirko
2023-07-17 19:03 ` Vadim Fedorenko
2023-07-17 19:03 ` Vadim Fedorenko
2023-06-11 9:36 ` [Intel-wired-lan] " Jiri Pirko
2023-06-11 9:36 ` Jiri Pirko
2023-06-12 7:25 ` [Intel-wired-lan] " Paolo Abeni
2023-06-12 7:25 ` Paolo Abeni
2023-06-21 20:38 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-21 20:38 ` Kubalewski, Arkadiusz
2023-06-11 10:01 ` [Intel-wired-lan] " Jiri Pirko
2023-06-11 10:01 ` Jiri Pirko
2023-06-12 23:45 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-12 23:45 ` Jakub Kicinski
2023-06-21 21:17 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-21 21:17 ` Kubalewski, Arkadiusz
2023-06-22 7:09 ` [Intel-wired-lan] " Jiri Pirko
2023-06-22 7:09 ` Jiri Pirko
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 04/10] dpll: netlink: " Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-11 11:42 ` [Intel-wired-lan] " Jiri Pirko
2023-06-11 11:42 ` Jiri Pirko
2023-06-23 1:01 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-23 1:01 ` Kubalewski, Arkadiusz
2023-06-21 11:18 ` [Intel-wired-lan] " Petr Oros
2023-06-21 11:18 ` Petr Oros
2023-06-21 11:53 ` [Intel-wired-lan] " Jiri Pirko
2023-06-21 11:53 ` Jiri Pirko
2023-06-21 13:07 ` [Intel-wired-lan] " Jiri Pirko
2023-06-21 13:07 ` Jiri Pirko
2023-06-23 0:56 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-23 0:56 ` Kubalewski, Arkadiusz
2023-06-23 7:48 ` [Intel-wired-lan] " Jiri Pirko
2023-06-23 7:48 ` Jiri Pirko
2023-06-23 0:56 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-23 0:56 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 05/10] dpll: api header: " Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-10 7:25 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 7:25 ` Jiri Pirko
2023-06-10 7:29 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 7:29 ` Jiri Pirko
2023-06-12 15:00 ` [Intel-wired-lan] " Vadim Fedorenko
2023-06-12 15:00 ` Vadim Fedorenko
2023-06-10 7:32 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 7:32 ` Jiri Pirko
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 06/10] netdev: expose DPLL pin handle for netdevice Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-09 17:30 ` [Intel-wired-lan] " kernel test robot
2023-06-09 17:30 ` kernel test robot
2023-06-09 17:41 ` kernel test robot
2023-06-12 9:17 ` Petr Oros
2023-06-12 9:17 ` Petr Oros
2023-06-13 13:51 ` [Intel-wired-lan] " Jiri Pirko
2023-06-13 13:51 ` Jiri Pirko
2023-06-14 12:25 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-14 12:25 ` Kubalewski, Arkadiusz
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 07/10] ice: add admin commands to access cgu configuration Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-10 8:46 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 8:46 ` Jiri Pirko
2023-06-15 21:35 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-15 21:35 ` Kubalewski, Arkadiusz
2023-06-10 15:36 ` [Intel-wired-lan] " kernel test robot
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 08/10] ice: implement dpll interface to control cgu Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-10 9:57 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 9:57 ` Jiri Pirko
2023-06-19 18:08 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-19 18:08 ` Kubalewski, Arkadiusz
2023-06-21 12:28 ` [Intel-wired-lan] " Jiri Pirko
2023-06-21 12:28 ` Jiri Pirko
2023-06-10 16:36 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 16:36 ` Jiri Pirko
2023-06-19 20:34 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-06-19 20:34 ` Kubalewski, Arkadiusz
2023-06-21 12:29 ` [Intel-wired-lan] " Jiri Pirko
2023-06-21 12:29 ` Jiri Pirko
2023-06-29 6:14 ` [Intel-wired-lan] " Jiri Pirko
2023-06-29 6:14 ` Jiri Pirko
2023-07-03 12:37 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2023-07-03 12:37 ` Kubalewski, Arkadiusz
2023-07-10 8:23 ` [Intel-wired-lan] " Jiri Pirko
2023-07-10 8:23 ` Jiri Pirko
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 09/10] ptp_ocp: implement DPLL ops Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-10 8:06 ` [Intel-wired-lan] " Jiri Pirko
2023-06-10 8:06 ` Jiri Pirko
2023-06-09 12:18 ` [Intel-wired-lan] [RFC PATCH v8 10/10] mlx5: Implement SyncE support using DPLL infrastructure Arkadiusz Kubalewski
2023-06-09 12:18 ` Arkadiusz Kubalewski
2023-06-09 23:27 ` Jakub Kicinski [this message]
2023-06-09 23:27 ` [RFC PATCH v8 00/10] Create common DPLL configuration API Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2023-06-22 7:44 [Intel-wired-lan] " Vitaly Grinberg
2023-06-29 8:22 ` Jiri Pirko
2023-06-29 8:26 ` Vitaly Grinberg
2023-06-29 10:03 ` Jiri Pirko
2023-06-22 7:54 Vitaly Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609162739.0d94a704@kernel.org \
--to=kuba@kernel.org \
--cc=airlied@redhat.com \
--cc=andy.ren@getcruise.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=benjamin.tissoires@redhat.com \
--cc=claudiajkang@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=jonathan.lemon@gmail.com \
--cc=kuniyu@amazon.com \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@zary.sk \
--cc=liuhangbin@gmail.com \
--cc=lucien.xin@gmail.com \
--cc=masahiroy@kernel.org \
--cc=milena.olech@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nipun.gupta@amd.com \
--cc=ogabbay@kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=razor@blackwall.org \
--cc=ricardo.canuelo@collabora.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sj@kernel.org \
--cc=tzimmermann@suse.de \
--cc=vadfed@fb.com \
--cc=vadfed@meta.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.