From: Jakub Kicinski <kuba@kernel.org>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: pmenzel@molgen.mpg.de, simon.horman@corigine.com,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
anthony.l.nguyen@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC
Date: Tue, 13 Jun 2023 11:24:35 -0700 [thread overview]
Message-ID: <20230613112435.18dc8130@kernel.org> (raw)
In-Reply-To: <9ea8a985-923d-62ec-5a34-ef7eeb056f05@intel.com>
On Tue, 13 Jun 2023 17:32:50 +0200 Piotr Gardocki wrote:
> > there is ether_addr_equal() call in iavf_set_mac(), even if not
> > exactly before eth_hw_addr_set(), it still should be removed ;)
> >
> > Anyway, I would fix all 3 drivers with one patch.
>
> I guess you're looking at old version of dev-queue branch on Tony's
> tree :) Regarding ice and i40e I made two patches to have different
> prefixes in titles. I don't mind merging them, but I'll wait for
> someone else speaking up about this.
I think the series is good enough, FWIW. We're already at -rc6, seems
more important to give syzbot and testers time to exercise the core
change than fishing out more drivers.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
<netdev@vger.kernel.org>, <pmenzel@molgen.mpg.de>,
<simon.horman@corigine.com>, <anthony.l.nguyen@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC
Date: Tue, 13 Jun 2023 11:24:35 -0700 [thread overview]
Message-ID: <20230613112435.18dc8130@kernel.org> (raw)
In-Reply-To: <9ea8a985-923d-62ec-5a34-ef7eeb056f05@intel.com>
On Tue, 13 Jun 2023 17:32:50 +0200 Piotr Gardocki wrote:
> > there is ether_addr_equal() call in iavf_set_mac(), even if not
> > exactly before eth_hw_addr_set(), it still should be removed ;)
> >
> > Anyway, I would fix all 3 drivers with one patch.
>
> I guess you're looking at old version of dev-queue branch on Tony's
> tree :) Regarding ice and i40e I made two patches to have different
> prefixes in titles. I don't mind merging them, but I'll wait for
> someone else speaking up about this.
I think the series is good enough, FWIW. We're already at -rc6, seems
more important to give syzbot and testers time to exercise the core
change than fishing out more drivers.
next prev parent reply other threads:[~2023-06-13 18:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 12:24 [Intel-wired-lan] [PATCH net-next v2 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-13 12:24 ` Piotr Gardocki
2023-06-13 12:24 ` [Intel-wired-lan] [PATCH net-next v2 1/3] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-13 12:24 ` Piotr Gardocki
2023-06-13 13:10 ` [Intel-wired-lan] " Maciej Fijalkowski
2023-06-13 13:10 ` Maciej Fijalkowski
2023-06-13 13:23 ` [Intel-wired-lan] " Paul Menzel
2023-06-13 13:23 ` Paul Menzel
2023-06-13 13:25 ` [Intel-wired-lan] " Fijalkowski, Maciej
2023-06-13 13:25 ` Fijalkowski, Maciej
2023-06-20 7:16 ` [Intel-wired-lan] " Gal Pressman
2023-06-20 7:16 ` Gal Pressman
2023-06-20 10:29 ` [Intel-wired-lan] " Piotr Gardocki
2023-06-20 10:29 ` Piotr Gardocki
2023-06-20 10:42 ` [Intel-wired-lan] " Gal Pressman
2023-06-20 10:42 ` Gal Pressman
2023-06-20 15:59 ` [Intel-wired-lan] " Jakub Kicinski
2023-06-20 15:59 ` Jakub Kicinski
2023-06-20 16:23 ` [Intel-wired-lan] " Piotr Gardocki
2023-06-20 16:23 ` Piotr Gardocki
2023-06-20 16:25 ` [Intel-wired-lan] " Gal Pressman
2023-06-20 16:25 ` Gal Pressman
2023-06-13 12:24 ` [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: remove unnecessary check for old MAC == new MAC Piotr Gardocki
2023-06-13 12:24 ` Piotr Gardocki
2023-06-13 13:11 ` [Intel-wired-lan] " Maciej Fijalkowski
2023-06-13 13:11 ` Maciej Fijalkowski
2023-06-13 12:24 ` [Intel-wired-lan] [PATCH net-next v2 3/3] ice: " Piotr Gardocki
2023-06-13 12:24 ` Piotr Gardocki
2023-06-13 13:13 ` [Intel-wired-lan] " Maciej Fijalkowski
2023-06-13 13:13 ` Maciej Fijalkowski
2023-06-13 14:02 ` [Intel-wired-lan] " Przemek Kitszel
2023-06-13 14:02 ` Przemek Kitszel
2023-06-13 15:10 ` [Intel-wired-lan] " Przemek Kitszel
2023-06-13 15:10 ` Przemek Kitszel
2023-06-13 15:16 ` Piotr Gardocki
2023-06-13 15:16 ` Piotr Gardocki
2023-06-13 15:24 ` Przemek Kitszel
2023-06-13 15:24 ` Przemek Kitszel
2023-06-13 15:32 ` Piotr Gardocki
2023-06-13 15:32 ` Piotr Gardocki
2023-06-13 18:24 ` Jakub Kicinski [this message]
2023-06-13 18:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613112435.18dc8130@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=piotrx.gardocki@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.