All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: pmenzel@molgen.mpg.de, netdev@vger.kernel.org,
	anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
	kuba@kernel.org, simon.horman@corigine.com,
	przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC
Date: Tue, 13 Jun 2023 15:13:09 +0200	[thread overview]
Message-ID: <ZIhrZc0DT78eheL7@boxer> (raw)
In-Reply-To: <20230613122420.855486-4-piotrx.gardocki@intel.com>

On Tue, Jun 13, 2023 at 02:24:20PM +0200, Piotr Gardocki wrote:
> The check has been moved to core. The ndo_set_mac_address callback
> is not being called with new MAC address equal to the old one anymore.
> 
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index caafb12d9cc7..f0ba896a3f46 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5624,11 +5624,6 @@ static int ice_set_mac_address(struct net_device *netdev, void *pi)
>  	if (!is_valid_ether_addr(mac))
>  		return -EADDRNOTAVAIL;
>  
> -	if (ether_addr_equal(netdev->dev_addr, mac)) {
> -		netdev_dbg(netdev, "already using mac %pM\n", mac);
> -		return 0;
> -	}
> -
>  	if (test_bit(ICE_DOWN, pf->state) ||
>  	    ice_is_reset_in_progress(pf->state)) {
>  		netdev_err(netdev, "can't set mac %pM. device not ready\n",
> -- 
> 2.34.1
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
	<przemyslaw.kitszel@intel.com>,
	<michal.swiatkowski@linux.intel.com>, <pmenzel@molgen.mpg.de>,
	<kuba@kernel.org>, <anthony.l.nguyen@intel.com>,
	<simon.horman@corigine.com>, <aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC
Date: Tue, 13 Jun 2023 15:13:09 +0200	[thread overview]
Message-ID: <ZIhrZc0DT78eheL7@boxer> (raw)
In-Reply-To: <20230613122420.855486-4-piotrx.gardocki@intel.com>

On Tue, Jun 13, 2023 at 02:24:20PM +0200, Piotr Gardocki wrote:
> The check has been moved to core. The ndo_set_mac_address callback
> is not being called with new MAC address equal to the old one anymore.
> 
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index caafb12d9cc7..f0ba896a3f46 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5624,11 +5624,6 @@ static int ice_set_mac_address(struct net_device *netdev, void *pi)
>  	if (!is_valid_ether_addr(mac))
>  		return -EADDRNOTAVAIL;
>  
> -	if (ether_addr_equal(netdev->dev_addr, mac)) {
> -		netdev_dbg(netdev, "already using mac %pM\n", mac);
> -		return 0;
> -	}
> -
>  	if (test_bit(ICE_DOWN, pf->state) ||
>  	    ice_is_reset_in_progress(pf->state)) {
>  		netdev_err(netdev, "can't set mac %pM. device not ready\n",
> -- 
> 2.34.1
> 

  reply	other threads:[~2023-06-13 13:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13 12:24 [Intel-wired-lan] [PATCH net-next v2 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-13 12:24 ` Piotr Gardocki
2023-06-13 12:24 ` [Intel-wired-lan] [PATCH net-next v2 1/3] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-13 12:24   ` Piotr Gardocki
2023-06-13 13:10   ` [Intel-wired-lan] " Maciej Fijalkowski
2023-06-13 13:10     ` Maciej Fijalkowski
2023-06-13 13:23     ` [Intel-wired-lan] " Paul Menzel
2023-06-13 13:23       ` Paul Menzel
2023-06-13 13:25       ` [Intel-wired-lan] " Fijalkowski, Maciej
2023-06-13 13:25         ` Fijalkowski, Maciej
2023-06-20  7:16   ` [Intel-wired-lan] " Gal Pressman
2023-06-20  7:16     ` Gal Pressman
2023-06-20 10:29     ` [Intel-wired-lan] " Piotr Gardocki
2023-06-20 10:29       ` Piotr Gardocki
2023-06-20 10:42       ` [Intel-wired-lan] " Gal Pressman
2023-06-20 10:42         ` Gal Pressman
2023-06-20 15:59         ` [Intel-wired-lan] " Jakub Kicinski
2023-06-20 15:59           ` Jakub Kicinski
2023-06-20 16:23           ` [Intel-wired-lan] " Piotr Gardocki
2023-06-20 16:23             ` Piotr Gardocki
2023-06-20 16:25           ` [Intel-wired-lan] " Gal Pressman
2023-06-20 16:25             ` Gal Pressman
2023-06-13 12:24 ` [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: remove unnecessary check for old MAC == new MAC Piotr Gardocki
2023-06-13 12:24   ` Piotr Gardocki
2023-06-13 13:11   ` [Intel-wired-lan] " Maciej Fijalkowski
2023-06-13 13:11     ` Maciej Fijalkowski
2023-06-13 12:24 ` [Intel-wired-lan] [PATCH net-next v2 3/3] ice: " Piotr Gardocki
2023-06-13 12:24   ` Piotr Gardocki
2023-06-13 13:13   ` Maciej Fijalkowski [this message]
2023-06-13 13:13     ` Maciej Fijalkowski
2023-06-13 14:02   ` [Intel-wired-lan] " Przemek Kitszel
2023-06-13 14:02     ` Przemek Kitszel
2023-06-13 15:10     ` [Intel-wired-lan] " Przemek Kitszel
2023-06-13 15:10       ` Przemek Kitszel
2023-06-13 15:16       ` Piotr Gardocki
2023-06-13 15:16         ` Piotr Gardocki
2023-06-13 15:24         ` Przemek Kitszel
2023-06-13 15:24           ` Przemek Kitszel
2023-06-13 15:32           ` Piotr Gardocki
2023-06-13 15:32             ` Piotr Gardocki
2023-06-13 18:24             ` Jakub Kicinski
2023-06-13 18:24               ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIhrZc0DT78eheL7@boxer \
    --to=maciej.fijalkowski@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=piotrx.gardocki@intel.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.