From: Lee Jones <lee@kernel.org>
To: Amelie Delaunay <amelie.delaunay@foss.st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Amelie Delaunay <amelie.delaunay@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error
Date: Thu, 15 Jun 2023 15:05:57 +0100 [thread overview]
Message-ID: <20230615140557.GG3635807@google.com> (raw)
In-Reply-To: <20230609092804.793100-2-amelie.delaunay@foss.st.com>
On Fri, 09 Jun 2023, Amelie Delaunay wrote:
> Nullify stmfx->vdd in case devm_regulator_get_optional() returns an error.
> And simplify code by returning an error only if return code is not -ENODEV,
> which means there is no vdd regulator and it is not an issue.
>
> Fixes: d75846ed08e6 ("mfd: stmfx: Fix dev_err_probe() call in stmfx_chip_init()")
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
> drivers/mfd/stmfx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Amelie Delaunay <amelie.delaunay@foss.st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Amelie Delaunay <amelie.delaunay@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error
Date: Thu, 15 Jun 2023 15:05:57 +0100 [thread overview]
Message-ID: <20230615140557.GG3635807@google.com> (raw)
In-Reply-To: <20230609092804.793100-2-amelie.delaunay@foss.st.com>
On Fri, 09 Jun 2023, Amelie Delaunay wrote:
> Nullify stmfx->vdd in case devm_regulator_get_optional() returns an error.
> And simplify code by returning an error only if return code is not -ENODEV,
> which means there is no vdd regulator and it is not an issue.
>
> Fixes: d75846ed08e6 ("mfd: stmfx: Fix dev_err_probe() call in stmfx_chip_init()")
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
> drivers/mfd/stmfx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-06-15 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 9:28 [RESEND PATCH 1/2] mfd: stmfx: Fix error path in stmfx_chip_init Amelie Delaunay
2023-06-09 9:28 ` Amelie Delaunay
2023-06-09 9:28 ` [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error Amelie Delaunay
2023-06-09 9:28 ` Amelie Delaunay
2023-06-15 14:05 ` Lee Jones [this message]
2023-06-15 14:05 ` Lee Jones
2023-06-15 14:05 ` [RESEND PATCH 1/2] mfd: stmfx: Fix error path in stmfx_chip_init Lee Jones
2023-06-15 14:05 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2023-04-12 10:55 [RESEND PATCH 0/2] STMFX chip init couple of fixes Amelie Delaunay
2023-04-12 10:55 ` [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error Amelie Delaunay
2023-04-12 10:55 ` Amelie Delaunay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615140557.GG3635807@google.com \
--to=lee@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=amelie.delaunay@st.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.