All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-comment@lists.oasis-open.org, cohuck@redhat.com,
	david.edmondson@oracle.com, virtio-dev@lists.oasis-open.org,
	sburla@marvell.com, jasowang@redhat.com, yishaih@nvidia.com,
	maorg@nvidia.com, shahafs@nvidia.com
Subject: [virtio-comment] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access
Date: Mon, 19 Jun 2023 13:04:25 -0400	[thread overview]
Message-ID: <20230619124042-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230613173015.1244486-5-parav@nvidia.com>

On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote:
> +Even though virtqueue driver notifications can be communicated through
> +administration virtqueue, if the group member device support such
> +notifications using a memory-mapped operation, such driver notifications
> +are sent using a group member device defined notification region.

I still feel we should support sending notifications to owner
at least optionally. For example:


\begin{lstlisting}
struct virtio_pci_owner_legacy_notify_cap {
        struct virtio_pci_cap cap;
        le32 notify_off_multiplier; /* Multiplier for member id. */
};
\end{lstlisting}

\field{notify_off_multiplier} is combined with the \field{member id} to
derive an address within a BAR.

\begin{lstlisting}
        cap.offset + member_id * notify_off_multiplier
\end{lstlisting}



We also need, as part of theory of operation, text that reads
something like "accessing the member device legacy interface
using one of XYZ commands has the same effect as accessing
it using the legacy interface".



Also, do all VFs support legacy interface with these
commands or none at all?


Also these devices will use non-transitional ID but they in fact
do have a legacy interface so using this definition they are
transitional devices. Maybe we need to add
when we describe the device ID text like "non transitional
devices and transitional devices utilizing commands XYZ" ...?


-- 
MST


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-comment@lists.oasis-open.org, cohuck@redhat.com,
	david.edmondson@oracle.com, virtio-dev@lists.oasis-open.org,
	sburla@marvell.com, jasowang@redhat.com, yishaih@nvidia.com,
	maorg@nvidia.com, shahafs@nvidia.com
Subject: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access
Date: Mon, 19 Jun 2023 13:04:25 -0400	[thread overview]
Message-ID: <20230619124042-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230613173015.1244486-5-parav@nvidia.com>

On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote:
> +Even though virtqueue driver notifications can be communicated through
> +administration virtqueue, if the group member device support such
> +notifications using a memory-mapped operation, such driver notifications
> +are sent using a group member device defined notification region.

I still feel we should support sending notifications to owner
at least optionally. For example:


\begin{lstlisting}
struct virtio_pci_owner_legacy_notify_cap {
        struct virtio_pci_cap cap;
        le32 notify_off_multiplier; /* Multiplier for member id. */
};
\end{lstlisting}

\field{notify_off_multiplier} is combined with the \field{member id} to
derive an address within a BAR.

\begin{lstlisting}
        cap.offset + member_id * notify_off_multiplier
\end{lstlisting}



We also need, as part of theory of operation, text that reads
something like "accessing the member device legacy interface
using one of XYZ commands has the same effect as accessing
it using the legacy interface".



Also, do all VFs support legacy interface with these
commands or none at all?


Also these devices will use non-transitional ID but they in fact
do have a legacy interface so using this definition they are
transitional devices. Maybe we need to add
when we describe the device ID text like "non transitional
devices and transitional devices utilizing commands XYZ" ...?


-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2023-06-19 17:12 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13 17:30 [virtio-comment] [PATCH v6 0/4] admin: Introduce legacy registers access using AQ Parav Pandit
2023-06-13 17:30 ` [virtio-dev] " Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 1/4] admin: Split opcode table rows with a line Parav Pandit
2023-06-13 17:30   ` [virtio-dev] " Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 2/4] admin: Fix section numbering Parav Pandit
2023-06-13 17:30   ` [virtio-dev] " Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 3/4] admin: Add group member legacy register access commands Parav Pandit
2023-06-13 17:30   ` [virtio-dev] " Parav Pandit
2023-06-19 16:20   ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:20     ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 16:29     ` [virtio-comment] " Parav Pandit
2023-06-19 16:29       ` [virtio-dev] " Parav Pandit
2023-06-19 16:40       ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:40         ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 16:45         ` [virtio-comment] " Parav Pandit
2023-06-19 16:45           ` [virtio-dev] " Parav Pandit
2023-06-19 17:10           ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:10             ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 17:21             ` [virtio-comment] " Parav Pandit
2023-06-19 17:21               ` Parav Pandit
2023-06-19 17:33               ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:33                 ` Michael S. Tsirkin
2023-06-19 17:38                 ` [virtio-comment] " Parav Pandit
2023-06-19 17:38                   ` Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access Parav Pandit
2023-06-13 17:30   ` [virtio-dev] " Parav Pandit
2023-06-19 16:16   ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:16     ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 21:07     ` [virtio-comment] " Parav Pandit
2023-06-19 21:07       ` [virtio-dev] " Parav Pandit
2023-06-21 20:05       ` [virtio-comment] " Michael S. Tsirkin
2023-06-21 20:05         ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 20:22         ` Parav Pandit
2023-06-21 20:22           ` [virtio-dev] " Parav Pandit
2023-06-21 20:31           ` Michael S. Tsirkin
2023-06-21 20:31             ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 20:43             ` Parav Pandit
2023-06-21 20:43               ` [virtio-dev] " Parav Pandit
2023-06-19 16:37   ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:37     ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 16:39     ` [virtio-comment] " Parav Pandit
2023-06-19 16:39       ` [virtio-dev] " Parav Pandit
2023-06-19 17:19       ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:19         ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 17:26         ` [virtio-comment] " Parav Pandit
2023-06-19 17:26           ` [virtio-dev] " Parav Pandit
2023-06-19 17:37           ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:37             ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 17:45             ` [virtio-comment] " Parav Pandit
2023-06-19 17:45               ` [virtio-dev] " Parav Pandit
2023-06-19 17:57               ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:57                 ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 18:07                 ` [virtio-comment] " Parav Pandit
2023-06-19 18:07                   ` [virtio-dev] " Parav Pandit
2023-06-20 14:12                   ` [virtio-comment] " Parav Pandit
2023-06-20 14:12                     ` [virtio-dev] " Parav Pandit
2023-06-21 15:50                     ` [virtio-comment] " Parav Pandit
2023-06-21 15:50                       ` [virtio-dev] " Parav Pandit
2023-06-21 15:56                       ` [virtio-comment] " Michael S. Tsirkin
2023-06-21 15:56                         ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 16:01                         ` [virtio-comment] " Parav Pandit
2023-06-21 16:01                           ` [virtio-dev] " Parav Pandit
2023-06-21 19:43                           ` [virtio-comment] " Michael S. Tsirkin
2023-06-21 19:43                             ` [virtio-dev] " Michael S. Tsirkin
2023-06-21 20:04                             ` Parav Pandit
2023-06-21 20:04                               ` [virtio-dev] " Parav Pandit
2023-06-21 20:08                               ` Michael S. Tsirkin
2023-06-21 20:08                                 ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 18:00               ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 18:00                 ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 18:12                 ` [virtio-comment] " Parav Pandit
2023-06-19 18:12                   ` [virtio-dev] " Parav Pandit
2023-06-21 19:47                   ` [virtio-comment] " Michael S. Tsirkin
2023-06-21 19:47                     ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 17:04   ` Michael S. Tsirkin [this message]
2023-06-19 17:04     ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 17:11     ` [virtio-comment] " Parav Pandit
2023-06-19 17:11       ` Parav Pandit
2023-06-19 17:26       ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:26         ` Michael S. Tsirkin
2023-06-19 17:35         ` [virtio-comment] " Parav Pandit
2023-06-19 17:35           ` Parav Pandit
2023-06-19 17:46           ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:46             ` Michael S. Tsirkin
2023-06-20  0:14             ` [virtio-comment] " Parav Pandit
2023-06-20  0:14               ` Parav Pandit
2023-06-20 10:21               ` [virtio-comment] " Michael S. Tsirkin
2023-06-20 10:21                 ` Michael S. Tsirkin
2023-06-21  1:09                 ` [virtio-comment] " Parav Pandit
2023-06-21  1:09                   ` Parav Pandit
2023-06-21  5:05                   ` [virtio-comment] " Michael S. Tsirkin
2023-06-21  5:05                     ` Michael S. Tsirkin
2023-06-19 12:38 ` [virtio-comment] RE: [PATCH v6 0/4] admin: Introduce legacy registers access using AQ Parav Pandit
2023-06-19 12:38   ` [virtio-dev] " Parav Pandit
2023-06-19 15:18   ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 15:18     ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 15:58     ` [virtio-comment] " Parav Pandit
2023-06-19 15:58       ` [virtio-dev] " Parav Pandit
2023-06-19 16:28 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:28   ` [virtio-dev] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230619124042-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david.edmondson@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=maorg@nvidia.com \
    --cc=parav@nvidia.com \
    --cc=sburla@marvell.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.