From: Daniel Thompson <daniel.thompson@linaro.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
Helge Deller <deller@gmx.de>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Maximilian Weigand <mweigand@mweigand.net>
Subject: Re: [PATCH 1/3] backlight: lm3630a: add support for changing the boost frequency
Date: Mon, 26 Jun 2023 15:39:38 +0100 [thread overview]
Message-ID: <20230626143938.GC95170@aspen.lan> (raw)
In-Reply-To: <20230602-lm3630a_boost_frequency-v1-1-076472036d1a@mweigand.net>
On Wed, Jun 14, 2023 at 09:08:52PM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> The led driver supports changing the switching frequency of the boost
> converter by two means: the base switching frequency can be changed from
> 500 kHz to 1 MHz, and a frequency shift can be activated, leading to
> switching frequencies of 560 kHz or 1.12 Mhz, respectively.
>
> Add this functionality to the led driver by introducing two dts entries
> that control the boost frequency (500 kHz by default) and the frequency
> shift (no shift by default).
>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Driver changes look ok (or at least will be when the DT bindings are
finalized).
However... I think patches 1 and 2 of this series are in the wrong
order. See #5 in
https://docs.kernel.org/devicetree/bindings/submitting-patches.html
for details.
Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
Helge Deller <deller@gmx.de>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Maximilian Weigand <mweigand@mweigand.net>
Subject: Re: [PATCH 1/3] backlight: lm3630a: add support for changing the boost frequency
Date: Mon, 26 Jun 2023 15:39:38 +0100 [thread overview]
Message-ID: <20230626143938.GC95170@aspen.lan> (raw)
In-Reply-To: <20230602-lm3630a_boost_frequency-v1-1-076472036d1a@mweigand.net>
On Wed, Jun 14, 2023 at 09:08:52PM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> The led driver supports changing the switching frequency of the boost
> converter by two means: the base switching frequency can be changed from
> 500 kHz to 1 MHz, and a frequency shift can be activated, leading to
> switching frequencies of 560 kHz or 1.12 Mhz, respectively.
>
> Add this functionality to the led driver by introducing two dts entries
> that control the boost frequency (500 kHz by default) and the frequency
> shift (no shift by default).
>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Driver changes look ok (or at least will be when the DT bindings are
finalized).
However... I think patches 1 and 2 of this series are in the wrong
order. See #5 in
https://docs.kernel.org/devicetree/bindings/submitting-patches.html
for details.
Daniel.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
Helge Deller <deller@gmx.de>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Maximilian Weigand <mweigand@mweigand.net>
Subject: Re: [PATCH 1/3] backlight: lm3630a: add support for changing the boost frequency
Date: Mon, 26 Jun 2023 15:39:38 +0100 [thread overview]
Message-ID: <20230626143938.GC95170@aspen.lan> (raw)
In-Reply-To: <20230602-lm3630a_boost_frequency-v1-1-076472036d1a@mweigand.net>
On Wed, Jun 14, 2023 at 09:08:52PM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> The led driver supports changing the switching frequency of the boost
> converter by two means: the base switching frequency can be changed from
> 500 kHz to 1 MHz, and a frequency shift can be activated, leading to
> switching frequencies of 560 kHz or 1.12 Mhz, respectively.
>
> Add this functionality to the led driver by introducing two dts entries
> that control the boost frequency (500 kHz by default) and the frequency
> shift (no shift by default).
>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Driver changes look ok (or at least will be when the DT bindings are
finalized).
However... I think patches 1 and 2 of this series are in the wrong
order. See #5 in
https://docs.kernel.org/devicetree/bindings/submitting-patches.html
for details.
Daniel.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Jingoo Han <jingoohan1@gmail.com>,
Helge Deller <deller@gmx.de>, Lee Jones <lee@kernel.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maximilian Weigand <mweigand@mweigand.net>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/3] backlight: lm3630a: add support for changing the boost frequency
Date: Mon, 26 Jun 2023 15:39:38 +0100 [thread overview]
Message-ID: <20230626143938.GC95170@aspen.lan> (raw)
In-Reply-To: <20230602-lm3630a_boost_frequency-v1-1-076472036d1a@mweigand.net>
On Wed, Jun 14, 2023 at 09:08:52PM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> The led driver supports changing the switching frequency of the boost
> converter by two means: the base switching frequency can be changed from
> 500 kHz to 1 MHz, and a frequency shift can be activated, leading to
> switching frequencies of 560 kHz or 1.12 Mhz, respectively.
>
> Add this functionality to the led driver by introducing two dts entries
> that control the boost frequency (500 kHz by default) and the frequency
> shift (no shift by default).
>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Driver changes look ok (or at least will be when the DT bindings are
finalized).
However... I think patches 1 and 2 of this series are in the wrong
order. See #5 in
https://docs.kernel.org/devicetree/bindings/submitting-patches.html
for details.
Daniel.
next prev parent reply other threads:[~2023-06-26 14:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 19:08 [PATCH 0/3] backlight: lm3630a: add functionality to change boost converter frequency Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` [PATCH 1/3] backlight: lm3630a: add support for changing the boost frequency Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-26 14:39 ` Daniel Thompson [this message]
2023-06-26 14:39 ` Daniel Thompson
2023-06-26 14:39 ` Daniel Thompson
2023-06-26 14:39 ` Daniel Thompson
2023-06-14 19:08 ` [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control " Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-17 10:12 ` Krzysztof Kozlowski
2023-06-17 10:12 ` Krzysztof Kozlowski
2023-06-17 10:12 ` Krzysztof Kozlowski
2023-06-17 10:12 ` Krzysztof Kozlowski
2023-06-17 16:34 ` Heiko Stübner
2023-06-17 16:34 ` Heiko Stübner
2023-06-17 16:34 ` Heiko Stübner
2023-06-17 16:34 ` Heiko Stübner
2023-06-17 17:42 ` Krzysztof Kozlowski
2023-06-17 17:42 ` Krzysztof Kozlowski
2023-06-17 17:42 ` Krzysztof Kozlowski
2023-06-17 17:42 ` Krzysztof Kozlowski
2023-06-17 18:15 ` Maximilian Weigand
2023-06-17 18:15 ` Maximilian Weigand
2023-06-17 18:15 ` Maximilian Weigand
2023-06-17 18:15 ` Maximilian Weigand
2023-06-14 19:08 ` [PATCH 3/3] arm64: dts: rockchip: shift boost frequency for rk3566-pinenote backlight Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
2023-06-14 19:08 ` Maximilian Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626143938.GC95170@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=conor+dt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mweigand2017@gmail.com \
--cc=mweigand@mweigand.net \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.